Re: [ PATCH v2 1/1] dell smbios driver : Consider Alienware a valid OEM String

[Hans de Goede <hdegoede@redhat.com>]

Hi,

On 10/6/20 5:23 AM, Gerardo Esteban Malazdrewicz wrote:
>  From bda6b6db0d76186ff37ffce8ac836379447ef2bc Mon Sep 17 00:00:00 2001
> From: Gerardo Malazdrewicz <36243997+GerMalaz@users.noreply.github.com>
> Date: Sat, 3 Oct 2020 07:43:02 -0300
> Subject: [PATCH] dell-smbios-base: Consider Alienware a Dell system

These lines are no supposed to be part of the body of the email
and the actual patch itself has been line-wrapped breaking it.

I've fixed this up manually this time. But next time please use
git send-email to submit patches to avoid breakage like this.

Thank you for your patch, I've applied this patch to me review-hans branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

Note it will show up there once I've pushed my local branch there,
which might take a while.

Once I've run some tests on this branch the patches there will be added
to the platform-drivers-x86/for-next branch and eventually will be
included in the pdx86 pull-request to Linus for the next merge-window.

Regards,

Hans



> 
> Alienware has been a subsidiary of Dell since 2006.
> 
> 2020 Alienware laptop:
> $ sudo dmidecode | head -3
> # dmidecode 3.2
> Getting SMBIOS data from sysfs.
> SMBIOS 3.2.0 present.
> $ sudo dmidecode | grep -A 29 "OEM Strings"
> OEM Strings
> 	String 1: Alienware
> 	String 2: 1[099B]
> 	String 3: 3[1.0]
> 	String 4: 4[0001]
> 	String 5: 5[0000]
> 	String 6: 6[D0, D4, D8, DA, DE]
> 	String 7: 7[]
> 	String 8: 8[]
> 	String 9: 9[]
> 	String 10: 10[1.3.0]
> 	String 11: 11[]
> 	String 12: 12[]
> 	String 13: 13[P38E002]
> 	String 14: 14[0]
> 	String 15: 15[0]
> 	String 16: 16[0]
> 	String 17: 17[0000000000000000]
> 	String 18: 18[0]
> 	String 19: 19[1]
> 	String 20: 20[]
> 	String 21: 21[]
> 	String 22: <BAD INDEX>
> 	String 23: <BAD INDEX>
> 	String 24: <BAD INDEX>
> 	String 25: <BAD INDEX>
> 	String 26: <BAD INDEX>
> 	String 27: <BAD INDEX>
> 	String 28: <BAD INDEX>
> 
> 2013 Alienware laptop:
> OEM Strings
>          String 1: Dell System
>          String 2: 1[05AA]
>          String 3: 14[2]
>          String 4: 15[0]
>          String 5: String5 for Original Equipment Manufacturer
> 
> Don't know when the OEM String changed.
> Change tested in the 2020 laptop, loads dell_smbios without further
> issues.
> 
> Signed-off-by: Gerardo E. Malazdrewicz <gerardo@malazdrewicz.com.ar>
> Reviewed-by: Mario Limonciello <mario.limonciello@dell.com>
> ---
>   drivers/platform/x86/dell-smbios-base.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/x86/dell-smbios-base.c
> b/drivers/platform/x86/dell-smbios-base.c
> index 2e2cd565926aa..5ad6f7c105cf3 100644
> --- a/drivers/platform/x86/dell-smbios-base.c
> +++ b/drivers/platform/x86/dell-smbios-base.c
> @@ -564,7 +564,8 @@ static int __init dell_smbios_init(void)
>   	int ret, wmi, smm;
>   
>   	if (!dmi_find_device(DMI_DEV_TYPE_OEM_STRING, "Dell System",
> NULL) &&
> -	    !dmi_find_device(DMI_DEV_TYPE_OEM_STRING, "www.dell.com",
> NULL)) {
> +	    !dmi_find_device(DMI_DEV_TYPE_OEM_STRING, "www.dell.com",
> NULL) &&
> +	    !dmi_find_device(DMI_DEV_TYPE_OEM_STRING, "Alienware",
> NULL)) {
>   		pr_err("Unable to run on non-Dell system\n");
>   		return -ENODEV;
>   	}
> 
> 
>