* [PATCH] platform/x86: thinkpad_acpi: Use false to set acpi_send_ev to false
@ 2024-04-29 9:34 Hans de Goede
2024-04-29 9:38 ` Ilpo Järvinen
2024-04-29 10:03 ` Hans de Goede
0 siblings, 2 replies; 3+ messages in thread
From: Hans de Goede @ 2024-04-29 9:34 UTC (permalink / raw)
To: Ilpo Järvinen, Andy Shevchenko; +Cc: Hans de Goede, platform-driver-x86
acpi_send_ev is a bool and everywhere else true/false is used
to set it. Replace the one instance using 0 with false.
Suggested-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
drivers/platform/x86/thinkpad_acpi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
index 7e2288009063..e2e6c4d3dff7 100644
--- a/drivers/platform/x86/thinkpad_acpi.c
+++ b/drivers/platform/x86/thinkpad_acpi.c
@@ -3912,7 +3912,7 @@ static void hotkey_notify(struct ibm_struct *ibm, u32 event)
if (tp_features.hotkey_wlsw &&
hkey == TP_HKEY_EV_RFKILL_CHANGED) {
tpacpi_send_radiosw_update();
- send_acpi_ev = 0;
+ send_acpi_ev = false;
known_ev = true;
}
break;
--
2.44.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] platform/x86: thinkpad_acpi: Use false to set acpi_send_ev to false
2024-04-29 9:34 [PATCH] platform/x86: thinkpad_acpi: Use false to set acpi_send_ev to false Hans de Goede
@ 2024-04-29 9:38 ` Ilpo Järvinen
2024-04-29 10:03 ` Hans de Goede
1 sibling, 0 replies; 3+ messages in thread
From: Ilpo Järvinen @ 2024-04-29 9:38 UTC (permalink / raw)
To: Hans de Goede; +Cc: Andy Shevchenko, platform-driver-x86
[-- Attachment #1: Type: text/plain, Size: 1018 bytes --]
On Mon, 29 Apr 2024, Hans de Goede wrote:
> acpi_send_ev is a bool and everywhere else true/false is used
> to set it. Replace the one instance using 0 with false.
>
> Suggested-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
> drivers/platform/x86/thinkpad_acpi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
> index 7e2288009063..e2e6c4d3dff7 100644
> --- a/drivers/platform/x86/thinkpad_acpi.c
> +++ b/drivers/platform/x86/thinkpad_acpi.c
> @@ -3912,7 +3912,7 @@ static void hotkey_notify(struct ibm_struct *ibm, u32 event)
> if (tp_features.hotkey_wlsw &&
> hkey == TP_HKEY_EV_RFKILL_CHANGED) {
> tpacpi_send_radiosw_update();
> - send_acpi_ev = 0;
> + send_acpi_ev = false;
> known_ev = true;
> }
> break;
>
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
--
i.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] platform/x86: thinkpad_acpi: Use false to set acpi_send_ev to false
2024-04-29 9:34 [PATCH] platform/x86: thinkpad_acpi: Use false to set acpi_send_ev to false Hans de Goede
2024-04-29 9:38 ` Ilpo Järvinen
@ 2024-04-29 10:03 ` Hans de Goede
1 sibling, 0 replies; 3+ messages in thread
From: Hans de Goede @ 2024-04-29 10:03 UTC (permalink / raw)
To: Ilpo Järvinen, Andy Shevchenko; +Cc: platform-driver-x86
Hi,
On 4/29/24 11:34 AM, Hans de Goede wrote:
> acpi_send_ev is a bool and everywhere else true/false is used
> to set it. Replace the one instance using 0 with false.
>
> Suggested-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
I've added this to my review-hans (soon to be for-next) branch now.
Regards,
Hans
> ---
> drivers/platform/x86/thinkpad_acpi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
> index 7e2288009063..e2e6c4d3dff7 100644
> --- a/drivers/platform/x86/thinkpad_acpi.c
> +++ b/drivers/platform/x86/thinkpad_acpi.c
> @@ -3912,7 +3912,7 @@ static void hotkey_notify(struct ibm_struct *ibm, u32 event)
> if (tp_features.hotkey_wlsw &&
> hkey == TP_HKEY_EV_RFKILL_CHANGED) {
> tpacpi_send_radiosw_update();
> - send_acpi_ev = 0;
> + send_acpi_ev = false;
> known_ev = true;
> }
> break;
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-04-29 10:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-29 9:34 [PATCH] platform/x86: thinkpad_acpi: Use false to set acpi_send_ev to false Hans de Goede
2024-04-29 9:38 ` Ilpo Järvinen
2024-04-29 10:03 ` Hans de Goede
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox