Re: [PATCH v3 12/19] platform/x86: x86-android-tablets: replace bat_swnode with swnode_group

[Hans de Goede <hansg@kernel.org>]

Hi Andy,

On 20-Sep-25 1:09 PM, Andy Shevchenko wrote:
> On Fri, Sep 19, 2025 at 11:48 PM Hans de Goede <hansg@kernel.org> wrote:
>>
>> Now that we are using software-nodes are used in more places it is
>> useful to have a more generic mechanism to have the core code register
>> software-nodes.
>>
>> Replace the bat_swnode registration mechanism with a more generic
>> swnode_group registration mechanism.
> 
> ...
> 
>> -       if (bat_swnode)
>> -               software_node_unregister(bat_swnode);
> 
>> +       if (swnode_group)
> 
> Now this check is a dup and hence redundant.

Good point, the same goes for the other 2 already
existing software_node_unregister() calls which pattern
this change is following.

So instead of fixing this in this commit I'm going to
add in a follow-up commit to fix all 3 cases.

> 
>> +               software_node_unregister_node_group(swnode_group);
> 
> ...
> 
>> -       if (dev_info->bat_swnode) {
>> -               ret = software_node_register(dev_info->bat_swnode);
>> +       if (dev_info->swnode_group) {
> 
> Ditto.

Same here, I'll also fix this in a follow-up commit to this patch,
to make the same change to all 3 used swnode-groups in one go.

I'll post a v4 with this changed soon.

Regards,

Hans




> 
>> +               ret = software_node_register_node_group(dev_info->swnode_group);
>>                 if (ret) {
>>                         x86_android_tablet_remove(pdev);
>>                         return ret;
>>                 }
>> -               bat_swnode = dev_info->bat_swnode;
>> +               swnode_group = dev_info->swnode_group;
>>         }
> 
>