Re: [PATCH v3 00/19] x86-android-tablets: convert to use GPIO references + Acer A1-840 support

[Hans de Goede <hansg@kernel.org>]

Hi Andy,

On 20-Sep-25 1:22 PM, Andy Shevchenko wrote:
> On Fri, Sep 19, 2025 at 11:47 PM Hans de Goede <hansg@kernel.org> wrote:
>>
>> Dmitry's v2 cover-letter:
>>
>> "This series came about because now software nodes can be used to
>> describe GPIOs (via PROPERTY_ENTRY_GPIO() macros) and I would like to
>> eventually get rid of gpio_keys_platform_data structure.
>>
>> So while I was doing the conversions from GPIO_LOOKUP() tables for
>> gpio_keys devices I decided to convert the rest of them as well. Maybe
>> some time in the future we can drop support for GPIO_LOOKUP() and rely
>> on device properties exclusively."
>>
>> Changes in v3:
>> - Add missing pinctrl_put() in lenovo_yoga_tab2_830_1050_init_codec()
>>   error-exit paths after the pinctrl_get_select() succeeds
>>
>> - Adding a swnode to the yt3 spi device changes the name of the SPI/codec
>>   device and the sound/soc/intel/boards/bytcr_wm5102.c machine driver looks
>>   up the code by name, update the machine driver to use the new name.
>>
>> - Make yoga-tab2-pro-1380-fastcharger.c propagate the fwnode set on
>>   the platform-device to the serdev it creates to fix this.
>>
>> - Fix the commit message of "platform/x86: x86-android-tablets: convert
>>   gpio_keys devices to GPIO references" which contained a stray reference
>>   to wm5102.
>>
>> New patches in v3:
>>
>> - Change sw_bat register mechanism into a generic swnode_group mechanism
>>
>> - Use swnode_group mechanism to register groups needed, instead of having
>>   init() callbacks manually do this
>>
>> - Changed my email address in the driver to hansg@kernel.org
>>
>> - Rebased "platform/x86: x86-android-tablets: Add support for Acer A1-840
>>   tablet" on top, switched that to also use software-nodes for GPIOs and
>>   added it to this series
>>
>> - Some Lenovo Yoga Tab 2 support fixes
> 
> I'm in favour of this series,
> Reviewed-by: Andy Shevchenko <andy@kernel.org>
> with some nit-picks here and there.

Thank you. I'll post a v4 to address your remarks soon.

Regards,

Hans