X86 platform drivers
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: "Limonciello, Mario" <Mario.Limonciello@dell.com>,
	"Barnabás Pőcze" <pobrn@protonmail.com>,
	"Takashi Iwai" <tiwai@suse.de>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	"platform-driver-x86@vger.kernel.org" 
	<platform-driver-x86@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: Keyboard regression by intel-vbtn
Date: Tue, 29 Sep 2020 14:54:25 +0200	[thread overview]
Message-ID: <55e021b7-5e1b-986b-07ec-279398570e40@redhat.com> (raw)
In-Reply-To: <DM6PR19MB2636C7C411E220565F39E741FA320@DM6PR19MB2636.namprd19.prod.outlook.com>

Hi,

On 9/29/20 2:27 PM, Limonciello, Mario wrote:
>> I'm afraid that the only answer which I have to these questions
>> is not helpful, but in my experience it is true: "firmware sucks".
> 
> So FWIW there is a Dell 2-in-1 that has been conflated into this same issue.
> https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1822394

That is what a somewhat old kernel (5.0.0) which I guess may
lack your fix to check the chassis-type.

Interesting that this actually is a 2-in-1 though.

Also interesting that according to the reporter this was
triggered by a BIOS update.

If you by any chance can provide an acpidump with both the
1.2.0 and 1.4.0 BIOS versions that would be very interesting.

> Something that is confusing to me is that on the Windows side all these
> machines use the same Intel driver for this infrastructure no matter the
> OEM.
> So they can't possibly be putting in quirk specific stuff in the driver side
> can they?
> 
> It has to make you wonder if some baseline assumptions made in the
> driver early on around tablet mode support are completely false.

I'm not saying your wrong. If you can get Intel to provide
us with some documentation, or Windows driver source code
for this, then that would be great.

AFAICT the Linux driver currently is entirely based on
reverse engineering.

Regards,

Hans


  reply	other threads:[~2020-09-29 12:54 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-29  8:48 Keyboard regression by intel-vbtn Takashi Iwai
2020-09-29  9:21 ` Hans de Goede
2020-09-29  9:29   ` Takashi Iwai
2020-09-29  9:59     ` Barnabás Pőcze
2020-09-29 10:17       ` Hans de Goede
2020-09-29 12:27         ` Limonciello, Mario
2020-09-29 12:54           ` Hans de Goede [this message]
2020-09-29 14:25             ` Limonciello, Mario
2020-09-29 16:53               ` Andy Shevchenko
2020-09-29 20:37                 ` Limonciello, Mario
2020-09-29 20:47               ` Limonciello, Mario
2020-09-30 13:28                 ` Hans de Goede
2020-09-30 15:12                   ` Limonciello, Mario
2020-09-30 15:36                     ` Hans de Goede
2020-09-30 16:02                       ` Limonciello, Mario
2020-09-29 14:19   ` Hans de Goede
2020-09-30 13:21 ` Hans de Goede
2020-09-30 13:21 ` Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55e021b7-5e1b-986b-07ec-279398570e40@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=Mario.Limonciello@dell.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=pobrn@protonmail.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox