* [PATCH] tools/power/x86/intel-speed-select: Fix the wrong format specifier
@ 2024-11-21 13:00 liujing
2024-11-21 16:49 ` srinivas pandruvada
0 siblings, 1 reply; 2+ messages in thread
From: liujing @ 2024-11-21 13:00 UTC (permalink / raw)
To: srinivas.pandruvada; +Cc: platform-driver-x86, linux-kernel, liujing
Because clos_config->clos_min and clos_config->clos_max
are unsigned int types, the output format should be %u.
Signed-off-by: liujing <liujing@cmss.chinamobile.com>
diff --git a/tools/power/x86/intel-speed-select/isst-display.c b/tools/power/x86/intel-speed-select/isst-display.c
index 07ebd08f3202..5ecf24bda6dd 100644
--- a/tools/power/x86/intel-speed-select/isst-display.c
+++ b/tools/power/x86/intel-speed-select/isst-display.c
@@ -617,14 +617,14 @@ void isst_clos_display_information(struct isst_id *id, FILE *outf, int clos,
format_and_print(outf, level + 2, header, value);
snprintf(header, sizeof(header), "clos-min");
- snprintf(value, sizeof(value), "%d MHz", clos_config->clos_min * isst_get_disp_freq_multiplier());
+ snprintf(value, sizeof(value), "%u MHz", clos_config->clos_min * isst_get_disp_freq_multiplier());
format_and_print(outf, level + 2, header, value);
snprintf(header, sizeof(header), "clos-max");
if ((clos_config->clos_max * isst_get_disp_freq_multiplier()) == 25500)
snprintf(value, sizeof(value), "Max Turbo frequency");
else
- snprintf(value, sizeof(value), "%d MHz", clos_config->clos_max * isst_get_disp_freq_multiplier());
+ snprintf(value, sizeof(value), "%u MHz", clos_config->clos_max * isst_get_disp_freq_multiplier());
format_and_print(outf, level + 2, header, value);
snprintf(header, sizeof(header), "clos-desired");
--
2.27.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] tools/power/x86/intel-speed-select: Fix the wrong format specifier
2024-11-21 13:00 [PATCH] tools/power/x86/intel-speed-select: Fix the wrong format specifier liujing
@ 2024-11-21 16:49 ` srinivas pandruvada
0 siblings, 0 replies; 2+ messages in thread
From: srinivas pandruvada @ 2024-11-21 16:49 UTC (permalink / raw)
To: liujing; +Cc: platform-driver-x86, linux-kernel
On Thu, 2024-11-21 at 21:00 +0800, liujing wrote:
> Because clos_config->clos_min and clos_config->clos_max
> are unsigned int types, the output format should be %u.
>
> Signed-off-by: liujing <liujing@cmss.chinamobile.com>
You need to have for your tag:
Full Name <email address>
Thanks,
Srinivas
>
> diff --git a/tools/power/x86/intel-speed-select/isst-display.c
> b/tools/power/x86/intel-speed-select/isst-display.c
> index 07ebd08f3202..5ecf24bda6dd 100644
> --- a/tools/power/x86/intel-speed-select/isst-display.c
> +++ b/tools/power/x86/intel-speed-select/isst-display.c
> @@ -617,14 +617,14 @@ void isst_clos_display_information(struct
> isst_id *id, FILE *outf, int clos,
> format_and_print(outf, level + 2, header, value);
>
> snprintf(header, sizeof(header), "clos-min");
> - snprintf(value, sizeof(value), "%d MHz", clos_config-
> >clos_min * isst_get_disp_freq_multiplier());
> + snprintf(value, sizeof(value), "%u MHz", clos_config-
> >clos_min * isst_get_disp_freq_multiplier());
> format_and_print(outf, level + 2, header, value);
>
> snprintf(header, sizeof(header), "clos-max");
> if ((clos_config->clos_max *
> isst_get_disp_freq_multiplier()) == 25500)
> snprintf(value, sizeof(value), "Max Turbo
> frequency");
> else
> - snprintf(value, sizeof(value), "%d MHz",
> clos_config->clos_max * isst_get_disp_freq_multiplier());
> + snprintf(value, sizeof(value), "%u MHz",
> clos_config->clos_max * isst_get_disp_freq_multiplier());
> format_and_print(outf, level + 2, header, value);
>
> snprintf(header, sizeof(header), "clos-desired");
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-11-21 16:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-11-21 13:00 [PATCH] tools/power/x86/intel-speed-select: Fix the wrong format specifier liujing
2024-11-21 16:49 ` srinivas pandruvada
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox