From: "Yong, Jonathan" <jonathan.yong@intel.com>
To: Guenter Roeck <linux@roeck-us.net>,
linux-watchdog@vger.kernel.org,
platform-driver-x86@vger.kernel.org
Cc: qipeng.zha@intel.com
Subject: Re: [PATCH 2/2] x86: Fix Apollo Lake Watchdog address in PMC driver
Date: Wed, 18 May 2016 12:48:33 +0800 [thread overview]
Message-ID: <573BF421.2020503@intel.com> (raw)
In-Reply-To: <573BE985.1000306@roeck-us.net>
On 05/18/2016 12:03, Guenter Roeck wrote:
> On 05/17/2016 08:26 PM, Yong, Jonathan wrote:
>> The TCO I/O base is 40h rather than the usual 30h, and the
>> re_reboot bit is at ACPIBASE+8.
>>
>
> Does this mean that the code never worked, or in other words that it
> was never tested, or are there now other chips which used the old
> definitions which no longer work after this patch has been applied ?
To my knowledge, it has never worked since 30h is claimed by ACPI GPE0_BLK.
With this patch, watchdog ioctl is working properly with
WDIOC_SETTIMEOUT, WDIOC_GETTIMEOUT and WDIOC_GETTIMELEFT as expected.
next prev parent reply other threads:[~2016-05-18 4:48 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-18 3:26 [PATCH 0/2] Correct iTCO Watchdog for Apollo Lake Yong, Jonathan
2016-05-18 3:26 ` [PATCH 1/2] watchdog: iTCO-wdt handle 5th variation " Yong, Jonathan
2016-05-18 14:37 ` Guenter Roeck
[not found] ` <1463541972-19758-1-git-send-email-jonathan.yong-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-05-18 3:26 ` [PATCH 2/2] x86: Fix Apollo Lake Watchdog address in PMC driver Yong, Jonathan
[not found] ` <1463541972-19758-3-git-send-email-jonathan.yong-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-05-18 4:03 ` Guenter Roeck
2016-05-18 4:48 ` Yong, Jonathan [this message]
[not found] ` <573BF421.2020503-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-05-18 14:37 ` Guenter Roeck
[not found] ` <573C7E0C.7050304-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
2016-05-24 20:13 ` Darren Hart
[not found] ` <20160524201316.GA5857-EK61lajVJsRSq9BJjBFyUp/QNRX+jHPU@public.gmane.org>
2016-05-25 7:55 ` Yong, Jonathan
[not found] ` <57455A8B.1090807-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-06-02 8:28 ` Yong, Jonathan
2016-06-07 22:03 ` Darren Hart
[not found] ` <20160607220323.GA28348-EK61lajVJsRSq9BJjBFyUp/QNRX+jHPU@public.gmane.org>
2016-06-13 4:42 ` Yong, Jonathan
2016-06-17 0:33 ` [PATCH v2 0/2] Correct iTCO Watchdog for Apollo Lake Yong, Jonathan
2016-06-17 0:33 ` [PATCH v2 1/2] watchdog: iTCO-wdt handle 5th variation " Yong, Jonathan
2016-06-23 13:39 ` Guenter Roeck
[not found] ` <1466123612-50633-1-git-send-email-jonathan.yong-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-06-17 0:33 ` [PATCH v2 2/2] x86: Fix Apollo Lake Watchdog address in PMC driver Yong, Jonathan
2016-06-23 13:39 ` Guenter Roeck
2016-07-17 20:16 ` [PATCH v2 0/2] Correct iTCO Watchdog for Apollo Lake Wim Van Sebroeck
2016-07-18 0:00 ` Yong, Jonathan
2016-06-17 0:36 ` Yong, Jonathan
2016-06-17 0:36 ` [PATCH v2 1/2] watchdog: iTCO-wdt handle 5th variation " Yong, Jonathan
2016-06-17 0:36 ` [PATCH v2 2/2] x86: Fix Apollo Lake Watchdog address in PMC driver Yong, Jonathan
[not found] ` <1466123817-50679-1-git-send-email-jonathan.yong-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-06-22 4:53 ` [PATCH v2 0/2] Correct iTCO Watchdog for Apollo Lake Yong, Jonathan
2016-06-22 6:01 ` Guenter Roeck
[not found] ` <576A299D.5010300-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
2016-06-23 5:02 ` Darren Hart
[not found] ` <20160623050218.GC3379-EK61lajVJsRSq9BJjBFyUp/QNRX+jHPU@public.gmane.org>
2016-06-23 13:37 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=573BF421.2020503@intel.com \
--to=jonathan.yong@intel.com \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=platform-driver-x86@vger.kernel.org \
--cc=qipeng.zha@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox