* [PATCH] platform/x86: intel-vbtn: Log event code on unexpected button events
@ 2024-03-27 19:57 Hans de Goede
2024-03-27 23:36 ` Kuppuswamy Sathyanarayanan
0 siblings, 1 reply; 2+ messages in thread
From: Hans de Goede @ 2024-03-27 19:57 UTC (permalink / raw)
To: Ilpo Järvinen, Andy Shevchenko
Cc: Hans de Goede, AceLan Kao, platform-driver-x86
When logging the warning about receiving a button event on a device
without buttons log the event code which triggered the warning.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
drivers/platform/x86/intel/vbtn.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/platform/x86/intel/vbtn.c b/drivers/platform/x86/intel/vbtn.c
index 084c355c86f5..de4decbb13ba 100644
--- a/drivers/platform/x86/intel/vbtn.c
+++ b/drivers/platform/x86/intel/vbtn.c
@@ -158,7 +158,8 @@ static void notify_handler(acpi_handle handle, u32 event, void *context)
if ((ke = sparse_keymap_entry_from_scancode(priv->buttons_dev, event))) {
if (!priv->has_buttons) {
- dev_warn(&device->dev, "Warning: received a button event on a device without buttons, please report this.\n");
+ dev_warn(&device->dev, "Warning: received 0x%02x button event on a device without buttons, please report this.\n",
+ event);
return;
}
input_dev = priv->buttons_dev;
--
2.44.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] platform/x86: intel-vbtn: Log event code on unexpected button events
2024-03-27 19:57 [PATCH] platform/x86: intel-vbtn: Log event code on unexpected button events Hans de Goede
@ 2024-03-27 23:36 ` Kuppuswamy Sathyanarayanan
0 siblings, 0 replies; 2+ messages in thread
From: Kuppuswamy Sathyanarayanan @ 2024-03-27 23:36 UTC (permalink / raw)
To: Hans de Goede, Ilpo Järvinen, Andy Shevchenko
Cc: AceLan Kao, platform-driver-x86
On 3/27/24 12:57 PM, Hans de Goede wrote:
> When logging the warning about receiving a button event on a device
> without buttons log the event code which triggered the warning.
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
Looks good to me.
Reviewed-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
> drivers/platform/x86/intel/vbtn.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/intel/vbtn.c b/drivers/platform/x86/intel/vbtn.c
> index 084c355c86f5..de4decbb13ba 100644
> --- a/drivers/platform/x86/intel/vbtn.c
> +++ b/drivers/platform/x86/intel/vbtn.c
> @@ -158,7 +158,8 @@ static void notify_handler(acpi_handle handle, u32 event, void *context)
>
> if ((ke = sparse_keymap_entry_from_scancode(priv->buttons_dev, event))) {
> if (!priv->has_buttons) {
> - dev_warn(&device->dev, "Warning: received a button event on a device without buttons, please report this.\n");
> + dev_warn(&device->dev, "Warning: received 0x%02x button event on a device without buttons, please report this.\n",
> + event);
> return;
> }
> input_dev = priv->buttons_dev;
--
Sathyanarayanan Kuppuswamy
Linux Kernel Developer
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-03-27 23:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-27 19:57 [PATCH] platform/x86: intel-vbtn: Log event code on unexpected button events Hans de Goede
2024-03-27 23:36 ` Kuppuswamy Sathyanarayanan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox