Re: [PATCH 0/2] platform/x86: Add ACPI quickstart button driver

[Hans de Goede <hdegoede@redhat.com>]

Hi,

On 2/1/24 15:58, Dennis Nezic wrote:
> On 01 Feb 15:44, Hans de Goede wrote:
>> Hi Dennis,
>>
>> On 2/1/24 15:09, Dennis Nezic wrote:
>>> On 31 Jan 18:36, Armin Wolf wrote:
>>>> Am 31.01.24 um 18:17 schrieb Dennis Nezic:
>>>>
>>>>> On 31 Jan 18:07, Armin Wolf wrote:
>>>>>> The issue is that you machine does not support runtime button events on the quickstart button,
>>>>>> only wake events.
>>>>>>
>>>>>> Can you check if you can now use the unresponsive button to wake the system?
>>>>> Nope, only the main power button can wake it from a sleep state, those
>>>>> quickstart buttons do nothing.
>>>>
>>>> Can you check if this is still the case when you configure the PNP0C32 ACPI device to be able
>>>> to generate wakeup events (from S5, S4 and S3)?
>>>> Maybe you should unload the quickstart driver for this test.
>>>>
>>>> If the button still does nothing, then it could be that the quickstart device is not handling
>>>> this button. Then we need some new ideas.
>>>
>>> Yea I don't think quickstart/hp-wmi is handling it. As I said, the
>>> behavior is exactly the same as if I didn't have it compiled at all.
>>>
>>> I enabled it via /proc/acpi/wakeup (it was disabled initially) (the
>>> S-state in that file only mentions S5, but I guess that should include
>>> all the less sleepy states too). No effect. I tried with and without the
>>> quickstart device.
>>
>> Perhaps this is simply a hw defect, have you seen the button
>> working under Windows? Maybe at some point some liquid
>> got inside the keyboard around that button?
> 
> Unlikely. I have 2 of these laptops, same behavior. Never saw them with
> Windows.
> 
>> The main keyboard buttons are typically membrane style buttons.
>>
>> But extra media keys might be more remote control style, where
>> there are not rubber domes beneath hard plastic keys, but the
>> keys themselves are rubber, with some carbon conductor on
>> the bottom and they directly connect 2 copper pads on the PCB.
>>
>> These remote style buttons are quite sensitive to dirt getting
>> underneath (just like the buttons in a typical TV remote).
>>
>> Assuming you can get things disassembled easily you may want
>> to try and clean things.
> 
> These ones are more like a phone touchscreen ... it's just a long solid
> plastic sheet, no distinct edges (annoying), with leds underneath. All
> the led's get illuminated when touched, even this mysterious "info" key.

Interesting. If the LED underneath lights up when touching then
I agree that it is unlikely that this is a hw defect.

Regards.

Hans