RE: [PATCH v4 06/12] platform/mellanox: Rename field to improve code readability

["Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>]

[-- Attachment #1: Type: text/plain, Size: 1716 bytes --]

On Fri, 24 Jan 2025, Vadim Pasternak wrote:
> 
> > -----Original Message-----
> > From: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> > Sent: Friday, 24 January 2025 10:14
> > To: Vadim Pasternak <vadimp@nvidia.com>
> > Cc: Hans de Goede <hdegoede@redhat.com>; Michael Shych
> > <michaelsh@nvidia.com>; Ciju Rajan K <crajank@nvidia.com>; Felix Radensky
> > <fradensky@nvidia.com>; Oleksandr Shamray <oleksandrs@nvidia.com>;
> > platform-driver-x86@vger.kernel.org
> > Subject: Re: [PATCH v4 06/12] platform/mellanox: Rename field to improve
> > code readability
> > 
> > On Thu, 23 Jan 2025, Vadim Pasternak wrote:
> > 
> > > Rename filed 'item' in structure 'mlxreg_core_item' to 'item_count'.
> > 
> > field -> field
> > 
> > 'item' -> 'count'
> > 
> > However, this did not rename 'counter' (that's in the other struct) which was
> > what I suggested you should consider changing.
> > 
> > Also in mlxreg_core_item, 'count' field seems to be the number of elements in
> > 'data' so 'item_count' doesn't sound so good name in this particular case (in
> > the other case 'counter' counts the number of items in 'item', thus my
> > suggestion to use 'item_count').
> 
> Hi Ilpo,
> 
> I think better to rename counter filed in 'mlxreg_core_item' to same 'counter' name as in 
> 'mlxreg_core_platform_data'.
> Thus, 'item->counter' will be number of 'data' elements (struct 'mlxreg_core_item')and 
> 'pdata->counter' will be like it is now number of 'item' elements: 'item->counter' 
> (struct 'mlxreg_core_platform_data').

No. "Counter" means something that is counting something which is not 
really the case here. Just use "count" if you want have them the same.

--
 i.