[PATCH] platform/x86: intel-vbtn: Stop calling "VBDL" from notify_handler

[PATCH] platform/x86: intel-vbtn: Stop calling "VBDL" from notify_handler

[Hans de Goede]

Commit 14c200b7ca46 ("platform/x86: intel-vbtn: Fix missing
tablet-mode-switch events") causes 2 issues on the ThinkPad X1 Tablet Gen2:

1. The ThinkPad will wake up immediately from suspend
2. When put in tablet mode SW_TABLET_MODE reverts to 0 after about 1 second

Both these issues are caused by the "VBDL" ACPI method call added
at the end of the notify_handler.

And it never became entirely clear if this call is even necessary to fix
the issue of missing tablet-mode-switch events on the Dell Inspiron 7352.

Drop the "VBDL" ACPI method call again to fix the 2 issues this is
causing on the ThinkPad X1 Tablet Gen2.

Fixes: 14c200b7ca46 ("platform/x86: intel-vbtn: Fix missing tablet-mode-switch events")
Reported-by: Alexander Kobel <a-kobel@a-kobel.de>
Closes: https://lore.kernel.org/platform-driver-x86/295984ce-bd4b-49bd-adc5-ffe7c898d7f0@a-kobel.de/
Cc: regressions@lists.linux.dev
Cc: Arnold Gozum <arngozum@gmail.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 drivers/platform/x86/intel/vbtn.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/platform/x86/intel/vbtn.c b/drivers/platform/x86/intel/vbtn.c
index 210b0a81b7ec..084c355c86f5 100644
--- a/drivers/platform/x86/intel/vbtn.c
+++ b/drivers/platform/x86/intel/vbtn.c
@@ -200,9 +200,6 @@ static void notify_handler(acpi_handle handle, u32 event, void *context)
 	autorelease = val && (!ke_rel || ke_rel->type == KE_IGNORE);
 
 	sparse_keymap_report_event(input_dev, event, val, autorelease);
-
-	/* Some devices need this to report further events */
-	acpi_evaluate_object(handle, "VBDL", NULL, NULL);
 }
 
 /*
-- 
2.43.0

Re: [PATCH] platform/x86: intel-vbtn: Stop calling "VBDL" from notify_handler

[Hans de Goede]

Hi,

On 2/16/24 21:33, Hans de Goede wrote:
> Commit 14c200b7ca46 ("platform/x86: intel-vbtn: Fix missing
> tablet-mode-switch events") causes 2 issues on the ThinkPad X1 Tablet Gen2:
> 
> 1. The ThinkPad will wake up immediately from suspend
> 2. When put in tablet mode SW_TABLET_MODE reverts to 0 after about 1 second
> 
> Both these issues are caused by the "VBDL" ACPI method call added
> at the end of the notify_handler.
> 
> And it never became entirely clear if this call is even necessary to fix
> the issue of missing tablet-mode-switch events on the Dell Inspiron 7352.
> 
> Drop the "VBDL" ACPI method call again to fix the 2 issues this is
> causing on the ThinkPad X1 Tablet Gen2.
> 
> Fixes: 14c200b7ca46 ("platform/x86: intel-vbtn: Fix missing tablet-mode-switch events")
> Reported-by: Alexander Kobel <a-kobel@a-kobel.de>
> Closes: https://lore.kernel.org/platform-driver-x86/295984ce-bd4b-49bd-adc5-ffe7c898d7f0@a-kobel.de/
> Cc: regressions@lists.linux.dev
> Cc: Arnold Gozum <arngozum@gmail.com>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>

I've added this to my review-hans (soon to be fixes) branch now.

Regards,

Hans

> ---
>  drivers/platform/x86/intel/vbtn.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/platform/x86/intel/vbtn.c b/drivers/platform/x86/intel/vbtn.c
> index 210b0a81b7ec..084c355c86f5 100644
> --- a/drivers/platform/x86/intel/vbtn.c
> +++ b/drivers/platform/x86/intel/vbtn.c
> @@ -200,9 +200,6 @@ static void notify_handler(acpi_handle handle, u32 event, void *context)
>  	autorelease = val && (!ke_rel || ke_rel->type == KE_IGNORE);
>  
>  	sparse_keymap_report_event(input_dev, event, val, autorelease);
> -
> -	/* Some devices need this to report further events */
> -	acpi_evaluate_object(handle, "VBDL", NULL, NULL);
>  }
>  
>  /*