From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Yen-Chi Huang <jesse.huang@portwell.com.tw>
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>,
platform-driver-x86@vger.kernel.org,
Hans de Goede <hansg@kernel.org>
Subject: Re: [PATCH v2] platform/x86: portwell-ec: don't print superfluous errors
Date: Mon, 18 Aug 2025 14:50:59 +0300 (EEST) [thread overview]
Message-ID: <85b8b88c-de22-737e-0fa1-827376116d06@linux.intel.com> (raw)
In-Reply-To: <ac110365-e631-4182-9936-c346d5c05f1c@portwell.com.tw>
On Fri, 15 Aug 2025, Yen-Chi Huang wrote:
> Hi Wolfram,
>
> Thanks for your cleanup.
>
> Yen-Chi
Hi Yen-Chi,
Since you're relatively new you might not know this:
The usual custom is to include your Reviewed-by tag into the reply if you
think the patch is fine and useful. That being said, it is not mandatory
to provide tag for anything nor should it be used as a rubber stamp for
everything, there could well be patches which need more work or should be
rejected, obviously don't give your tag for those (but reply with your
concerns instead if that's the case).
The Reviewed-by tags will be recorded into the commits and it's also a
way to credit the reviewers for their work.
--
i.
next prev parent reply other threads:[~2025-08-18 11:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-13 19:13 [PATCH v2] platform/x86: portwell-ec: don't print superfluous errors Wolfram Sang
2025-08-15 15:50 ` Yen-Chi Huang
2025-08-18 11:50 ` Ilpo Järvinen [this message]
2025-08-20 11:01 ` Yen-Chi Huang
2025-08-28 12:08 ` Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85b8b88c-de22-737e-0fa1-827376116d06@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=hansg@kernel.org \
--cc=jesse.huang@portwell.com.tw \
--cc=platform-driver-x86@vger.kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox