[PATCH v2] platform/x86: portwell-ec: don't print superfluous errors

[PATCH v2] platform/x86: portwell-ec: don't print superfluous errors

[Wolfram Sang]

The watchdog core will handle error messages already.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---

Change since v1: simplified more into a single return statement

 drivers/platform/x86/portwell-ec.c | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/drivers/platform/x86/portwell-ec.c b/drivers/platform/x86/portwell-ec.c
index 322f296e9315..b603e68c82e9 100644
--- a/drivers/platform/x86/portwell-ec.c
+++ b/drivers/platform/x86/portwell-ec.c
@@ -237,13 +237,7 @@ static int pwec_probe(struct platform_device *pdev)
 	}
 
 	ec_wdt_dev.parent = &pdev->dev;
-	ret = devm_watchdog_register_device(&pdev->dev, &ec_wdt_dev);
-	if (ret < 0) {
-		dev_err(&pdev->dev, "failed to register Portwell EC Watchdog\n");
-		return ret;
-	}
-
-	return 0;
+	return devm_watchdog_register_device(&pdev->dev, &ec_wdt_dev);
 }
 
 static struct platform_driver pwec_driver = {
-- 
2.47.2

Re: [PATCH v2] platform/x86: portwell-ec: don't print superfluous errors

[Yen-Chi Huang]

Hi Wolfram,

Thanks for your cleanup.

Yen-Chi

Re: [PATCH v2] platform/x86: portwell-ec: don't print superfluous errors

[Ilpo Järvinen]

On Fri, 15 Aug 2025, Yen-Chi Huang wrote:

> Hi Wolfram,
> 
> Thanks for your cleanup.
> 
> Yen-Chi

Hi Yen-Chi,

Since you're relatively new you might not know this:

The usual custom is to include your Reviewed-by tag into the reply if you 
think the patch is fine and useful. That being said, it is not mandatory 
to provide tag for anything nor should it be used as a rubber stamp for 
everything, there could well be patches which need more work or should be 
rejected, obviously don't give your tag for those (but reply with your 
concerns instead if that's the case).

The Reviewed-by tags will be recorded into the commits and it's also a 
way to credit the reviewers for their work.

-- 
 i.

Re: [PATCH v2] platform/x86: portwell-ec: don't print superfluous errors

[Yen-Chi Huang]

Hi Ilpo,

When I replied earlier, I thought Wolfram's change was correct, but I had
not yet built and run the patch on hardware, so I did not provide any tags
at that time. Thanks for the clarification about the convention; I'll keep
that in mind for future reviews.

I have now built and tested this patch on NANO-6064, and it works fine.

Thanks Wolfram for the fix.

Reviewed-by: Yen-Chi Huang <jesse.huang@portwell.com.tw>
Tested-by: Yen-Chi Huang <jesse.huang@portwell.com.tw>

Best,
Yen-Chi

Re: [PATCH v2] platform/x86: portwell-ec: don't print superfluous errors

[Ilpo Järvinen]

On Wed, 13 Aug 2025 21:13:44 +0200, Wolfram Sang wrote:

> The watchdog core will handle error messages already.
> 
> 


Thank you for your contribution, it has been applied to my local
review-ilpo-next branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-next branch only once I've pushed my
local branch there, which might take a while.

The list of commits applied:
[1/1] platform/x86: portwell-ec: don't print superfluous errors
      commit: ba9eddc43f2f05a99d3f7535c9367845aca35904

--
 i.