[PATCH] platform/x86: alieneware-wmi-wmax: Add AWCC support to Alienware 16 Aurora

[PATCH] platform/x86: alieneware-wmi-wmax: Add AWCC support to Alienware 16 Aurora

[Anthony Wong]

From: Anthony Wong <anthony.wong@ubuntu.com>

Add AWCC support to Alienware 16 Aurora AC16250.

CC: stable@vger.kernel.org
Signed-off-by: Anthony Wong <anthony.wong@ubuntu.com>
---
 drivers/platform/x86/dell/alienware-wmi-wmax.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/platform/x86/dell/alienware-wmi-wmax.c b/drivers/platform/x86/dell/alienware-wmi-wmax.c
index 31f9643a6a3b5..eb7c3fb6b078d 100644
--- a/drivers/platform/x86/dell/alienware-wmi-wmax.c
+++ b/drivers/platform/x86/dell/alienware-wmi-wmax.c
@@ -89,6 +89,14 @@ static struct awcc_quirks generic_quirks = {
 static struct awcc_quirks empty_quirks;
 
 static const struct dmi_system_id awcc_dmi_table[] __initconst = {
+	{
+		.ident = "Alienware 16 Aurora AC16250",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "Alienware"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "Alienware 16 Aurora AC16250"),
+		},
+		.driver_data = &generic_quirks,
+	},
 	{
 		.ident = "Alienware Area-51m",
 		.matches = {
-- 
2.43.0

Re: [PATCH] platform/x86: alieneware-wmi-wmax: Add AWCC support to Alienware 16 Aurora

[Kurt Borja]

Hi Anthony,

On Tue Oct 7, 2025 at 3:47 AM -05, Anthony Wong wrote:
> From: Anthony Wong <anthony.wong@ubuntu.com>
>
> Add AWCC support to Alienware 16 Aurora AC16250.

Thanks you!

>
> CC: stable@vger.kernel.org
> Signed-off-by: Anthony Wong <anthony.wong@ubuntu.com>
> ---
>  drivers/platform/x86/dell/alienware-wmi-wmax.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/drivers/platform/x86/dell/alienware-wmi-wmax.c b/drivers/platform/x86/dell/alienware-wmi-wmax.c
> index 31f9643a6a3b5..eb7c3fb6b078d 100644
> --- a/drivers/platform/x86/dell/alienware-wmi-wmax.c
> +++ b/drivers/platform/x86/dell/alienware-wmi-wmax.c
> @@ -89,6 +89,14 @@ static struct awcc_quirks generic_quirks = {
>  static struct awcc_quirks empty_quirks;
>  
>  static const struct dmi_system_id awcc_dmi_table[] __initconst = {
> +	{
> +		.ident = "Alienware 16 Aurora AC16250",
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "Alienware"),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "Alienware 16 Aurora AC16250"),
> +		},
> +		.driver_data = &generic_quirks,

Can you perhaps send me the acpidump of this model?

Some newer Alienware laptops support G-Mode and if that's the case
g_series_quirks would be better.

> +	},
>  	{
>  		.ident = "Alienware Area-51m",
>  		.matches = {


-- 
 ~ Kurt

Re: [PATCH] platform/x86: alieneware-wmi-wmax: Add AWCC support to Alienware 16 Aurora

[Kurt Borja]

On Tue Oct 7, 2025 at 3:47 AM -05, Anthony Wong wrote:
> From: Anthony Wong <anthony.wong@ubuntu.com>
>
> Add AWCC support to Alienware 16 Aurora AC16250.

Hi Anthony,

I'm very interested in getting this merged.

Do you have access to this model? If so, either testing the
`force_gmode` module parameter or attaching the acpidump of this laptop
would be amazing.

Either way, I have a couple of comments that I missed. First there is a
typo in the title: alieneware-wmi-wmax -> alienware-wmi-wmax.

>
> CC: stable@vger.kernel.org

CC -> Cc.

> Signed-off-by: Anthony Wong <anthony.wong@ubuntu.com>
> ---
>  drivers/platform/x86/dell/alienware-wmi-wmax.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/drivers/platform/x86/dell/alienware-wmi-wmax.c b/drivers/platform/x86/dell/alienware-wmi-wmax.c
> index 31f9643a6a3b5..eb7c3fb6b078d 100644
> --- a/drivers/platform/x86/dell/alienware-wmi-wmax.c
> +++ b/drivers/platform/x86/dell/alienware-wmi-wmax.c
> @@ -89,6 +89,14 @@ static struct awcc_quirks generic_quirks = {
>  static struct awcc_quirks empty_quirks;
>  
>  static const struct dmi_system_id awcc_dmi_table[] __initconst = {
> +	{
> +		.ident = "Alienware 16 Aurora AC16250",
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "Alienware"),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "Alienware 16 Aurora AC16250"),

I suggest we drop the "AC16250" so we won't need additional patches if
Dell releases Alienware 16 Aurora R1, R2, etc.

> +		},
> +		.driver_data = &generic_quirks,
> +	},
>  	{
>  		.ident = "Alienware Area-51m",
>  		.matches = {

Thanks!

-- 
 ~ Kurt

Re: [PATCH] platform/x86: alieneware-wmi-wmax: Add AWCC support to Alienware 16 Aurora

[Anthony Wong]

Hi Kurt,

On Sat, Nov 15, 2025 at 6:23 AM Kurt Borja <kuurtb@gmail.com> wrote:
>
> On Tue Oct 7, 2025 at 3:47 AM -05, Anthony Wong wrote:
> > From: Anthony Wong <anthony.wong@ubuntu.com>
> >
> > Add AWCC support to Alienware 16 Aurora AC16250.
>
> Hi Anthony,
>
> I'm very interested in getting this merged.
>
> Do you have access to this model? If so, either testing the
> `force_gmode` module parameter or attaching the acpidump of this laptop
> would be amazing.

Here's the acpidump of the machine:
https://people.canonical.com/~ypwong/alienware16-aurora-acpidump

I tried the `force_gmode` module parameter but it doesn't seem to do
anything, how to check if it's really in effect?

Once this is cleared up, I can send a v2 with the suggestions you
provided below.

Thanks,
Anthony

>
> Either way, I have a couple of comments that I missed. First there is a
> typo in the title: alieneware-wmi-wmax -> alienware-wmi-wmax.
>
> >
> > CC: stable@vger.kernel.org
>
> CC -> Cc.
>
> > Signed-off-by: Anthony Wong <anthony.wong@ubuntu.com>
> > ---
> >  drivers/platform/x86/dell/alienware-wmi-wmax.c | 8 ++++++++
> >  1 file changed, 8 insertions(+)
> >
> > diff --git a/drivers/platform/x86/dell/alienware-wmi-wmax.c b/drivers/platform/x86/dell/alienware-wmi-wmax.c
> > index 31f9643a6a3b5..eb7c3fb6b078d 100644
> > --- a/drivers/platform/x86/dell/alienware-wmi-wmax.c
> > +++ b/drivers/platform/x86/dell/alienware-wmi-wmax.c
> > @@ -89,6 +89,14 @@ static struct awcc_quirks generic_quirks = {
> >  static struct awcc_quirks empty_quirks;
> >
> >  static const struct dmi_system_id awcc_dmi_table[] __initconst = {
> > +     {
> > +             .ident = "Alienware 16 Aurora AC16250",
> > +             .matches = {
> > +                     DMI_MATCH(DMI_SYS_VENDOR, "Alienware"),
> > +                     DMI_MATCH(DMI_PRODUCT_NAME, "Alienware 16 Aurora AC16250"),
>
> I suggest we drop the "AC16250" so we won't need additional patches if
> Dell releases Alienware 16 Aurora R1, R2, etc.
>
> > +             },
> > +             .driver_data = &generic_quirks,
> > +     },
> >       {
> >               .ident = "Alienware Area-51m",
> >               .matches = {
>
> Thanks!
>
> --
>  ~ Kurt
>

Re: [PATCH] platform/x86: alieneware-wmi-wmax: Add AWCC support to Alienware 16 Aurora

[Kurt Borja]

On Sat Nov 15, 2025 at 7:44 PM -05, Anthony Wong wrote:
> Hi Kurt,
>
> On Sat, Nov 15, 2025 at 6:23 AM Kurt Borja <kuurtb@gmail.com> wrote:
>>
>> On Tue Oct 7, 2025 at 3:47 AM -05, Anthony Wong wrote:
>> > From: Anthony Wong <anthony.wong@ubuntu.com>
>> >
>> > Add AWCC support to Alienware 16 Aurora AC16250.
>>
>> Hi Anthony,
>>
>> I'm very interested in getting this merged.
>>
>> Do you have access to this model? If so, either testing the
>> `force_gmode` module parameter or attaching the acpidump of this laptop
>> would be amazing.
>
> Here's the acpidump of the machine:
> https://people.canonical.com/~ypwong/alienware16-aurora-acpidump
>
> I tried the `force_gmode` module parameter but it doesn't seem to do
> anything, how to check if it's really in effect?

It maps the 'performance' profile to G-Mode. In some laptops this
toggles the led of the G-Mode/Performance key and performance may be
better.

I checked the acpidump you provided and your model does support it,
thus we should use `g_series_quirks` instead of `generic_quirks`.

>
> Once this is cleared up, I can send a v2 with the suggestions you
> provided below.
>
> Thanks,
> Anthony
>
>>
>> Either way, I have a couple of comments that I missed. First there is a
>> typo in the title: alieneware-wmi-wmax -> alienware-wmi-wmax.
>>
>> >
>> > CC: stable@vger.kernel.org
>>
>> CC -> Cc.
>>
>> > Signed-off-by: Anthony Wong <anthony.wong@ubuntu.com>
>> > ---
>> >  drivers/platform/x86/dell/alienware-wmi-wmax.c | 8 ++++++++
>> >  1 file changed, 8 insertions(+)
>> >
>> > diff --git a/drivers/platform/x86/dell/alienware-wmi-wmax.c b/drivers/platform/x86/dell/alienware-wmi-wmax.c
>> > index 31f9643a6a3b5..eb7c3fb6b078d 100644
>> > --- a/drivers/platform/x86/dell/alienware-wmi-wmax.c
>> > +++ b/drivers/platform/x86/dell/alienware-wmi-wmax.c
>> > @@ -89,6 +89,14 @@ static struct awcc_quirks generic_quirks = {
>> >  static struct awcc_quirks empty_quirks;
>> >
>> >  static const struct dmi_system_id awcc_dmi_table[] __initconst = {
>> > +     {
>> > +             .ident = "Alienware 16 Aurora AC16250",
>> > +             .matches = {
>> > +                     DMI_MATCH(DMI_SYS_VENDOR, "Alienware"),
>> > +                     DMI_MATCH(DMI_PRODUCT_NAME, "Alienware 16 Aurora AC16250"),
>>
>> I suggest we drop the "AC16250" so we won't need additional patches if
>> Dell releases Alienware 16 Aurora R1, R2, etc.
>>
>> > +             },
>> > +             .driver_data = &generic_quirks,
>> > +     },
>> >       {
>> >               .ident = "Alienware Area-51m",
>> >               .matches = {
>>
>> Thanks!
>>
>> --
>>  ~ Kurt
>>


-- 
 ~ Kurt