public inbox for platform-driver-x86@vger.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Mark Gross <markgross@kernel.org>,
	Andy Shevchenko <andy@kernel.org>,
	Mika Westerberg <mika.westerberg@linux.intel.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	platform-driver-x86@vger.kernel.org, linux-gpio@vger.kernel.org
Subject: Re: [PATCH 4/5] platform/x86: x86-android-tablets: Workaround Lenovo Yoga Tablet 2 830/1050 poweroff hang
Date: Fri, 25 Feb 2022 18:35:13 +0200	[thread overview]
Message-ID: <YhkFQa82XVsu37xN@smile.fi.intel.com> (raw)
In-Reply-To: <0568e484-4ab2-5641-53ae-29ff48e952e6@redhat.com>

On Thu, Feb 24, 2022 at 05:57:11PM +0100, Hans de Goede wrote:
> Hi,
> 
> On 2/23/22 15:58, Andy Shevchenko wrote:
> > On Wed, Feb 23, 2022 at 02:31:52PM +0100, Hans de Goede wrote:
> >> These tablets' DSDT does not set acpi_gbl_reduced_hardware, so
> >> acpi_power_off gets used as pm_power_off handler. This causes "poweroff"
> >> on these tablets to hang hard. Requiring pressing the powerbutton for
> >> 30 seconds *twice* followed by a normal 3 second press to recover.
> >>
> >> Avoid this by overriding the global pm_power_off handler to do
> >> an EFI poweroff instead.
> > 
> > Oh, you eventually found the root cause (reduced HW bit)?
> 
> I'm not sure, it is possible that not setting the reduced HW bit
> is actually correct for this hw, but that does lead to using
> acpi_power_off which seems broken on this system.
> 
> I've updated the commit message while merging this to reflect
> that using acpi_power_off is the problem, rather then not setting
> the reduced HW bit.

Understood. Thanks!

> Also note that the issue of reboot being the same as poweroff once
> the system has been rebooted at least once is still unresolved.

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2022-02-25 16:36 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-23 13:31 [PATCH 0/5] pinctrl/baytrail platform/x86: SUS6 mux / Lenovo Yoga Tablet 2 support Hans de Goede
2022-02-23 13:31 ` [PATCH 1/5] pinctrl: baytrail: Add pinconf group + function for the pmu_clk Hans de Goede
2022-02-23 14:54   ` Andy Shevchenko
2022-02-23 15:27     ` Andy Shevchenko
2022-02-23 13:31 ` [PATCH 2/5] platform/x86: x86-android-tablets: Fix EBUSY error when requesting IOAPIC IRQs Hans de Goede
2022-02-23 14:56   ` Andy Shevchenko
2022-02-23 15:16     ` Hans de Goede
2022-02-23 15:38       ` Andy Shevchenko
2022-02-24 16:49         ` Hans de Goede
2022-02-23 13:31 ` [PATCH 3/5] platform/x86: x86-android-tablets: Add Lenovo Yoga Tablet 2 830 / 1050 data Hans de Goede
2022-02-23 15:04   ` Andy Shevchenko
2022-02-23 13:31 ` [PATCH 4/5] platform/x86: x86-android-tablets: Workaround Lenovo Yoga Tablet 2 830/1050 poweroff hang Hans de Goede
2022-02-23 14:58   ` Andy Shevchenko
2022-02-24 16:57     ` Hans de Goede
2022-02-25 16:35       ` Andy Shevchenko [this message]
2022-02-23 13:31 ` [PATCH 5/5] platform/x86: x86-android-tablets: Lenovo Yoga Tablet 2 830/1050 sound support Hans de Goede
2022-02-23 15:04   ` Andy Shevchenko
2022-02-23 14:55 ` [PATCH 0/5] pinctrl/baytrail platform/x86: SUS6 mux / Lenovo Yoga Tablet 2 support Andy Shevchenko
2022-02-24 16:43   ` Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YhkFQa82XVsu37xN@smile.fi.intel.com \
    --to=andriy.shevchenko@intel.com \
    --cc=andy@kernel.org \
    --cc=hdegoede@redhat.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=markgross@kernel.org \
    --cc=mika.westerberg@linux.intel.com \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox