* [PATCH] platform/x86/intel/ifs: Mark as BROKEN
@ 2022-07-10 14:07 Hans de Goede
2022-07-10 14:13 ` Greg Kroah-Hartman
2022-07-10 15:38 ` Hans de Goede
0 siblings, 2 replies; 3+ messages in thread
From: Hans de Goede @ 2022-07-10 14:07 UTC (permalink / raw)
To: Mark Gross, Andy Shevchenko, Greg Kroah-Hartman
Cc: Hans de Goede, platform-driver-x86, Jithu Joseph, Ashok Raj,
Tony Luck
A recent suggested change to the IFS code has shown that the userspace
API needs a bit more work, see:
https://lore.kernel.org/platform-driver-x86/20220708151938.986530-1-jithu.joseph@intel.com/
Mark it as BROKEN before 5.19 ships, to give ourselves one more
kernel-devel cycle to get the userspace API right.
Link: https://lore.kernel.org/platform-driver-x86/20220708151938.986530-1-jithu.joseph@intel.com/
Cc: Jithu Joseph <jithu.joseph@intel.com>
Cc: Ashok Raj <ashok.raj@intel.com>
Cc: Tony Luck <tony.luck@intel.com>
Suggested-by: Greg KH <gregkh@linuxfoundation.org>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
drivers/platform/x86/intel/ifs/Kconfig | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/platform/x86/intel/ifs/Kconfig b/drivers/platform/x86/intel/ifs/Kconfig
index 7ce896434b8f..c341a27cc1a3 100644
--- a/drivers/platform/x86/intel/ifs/Kconfig
+++ b/drivers/platform/x86/intel/ifs/Kconfig
@@ -1,6 +1,9 @@
config INTEL_IFS
tristate "Intel In Field Scan"
depends on X86 && CPU_SUP_INTEL && 64BIT && SMP
+ # Discussion on the list has shown that the sysfs API needs a bit
+ # more work, mark this as broken for now
+ depends on BROKEN
select INTEL_IFS_DEVICE
help
Enable support for the In Field Scan capability in select
--
2.36.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] platform/x86/intel/ifs: Mark as BROKEN
2022-07-10 14:07 [PATCH] platform/x86/intel/ifs: Mark as BROKEN Hans de Goede
@ 2022-07-10 14:13 ` Greg Kroah-Hartman
2022-07-10 15:38 ` Hans de Goede
1 sibling, 0 replies; 3+ messages in thread
From: Greg Kroah-Hartman @ 2022-07-10 14:13 UTC (permalink / raw)
To: Hans de Goede
Cc: Mark Gross, Andy Shevchenko, platform-driver-x86, Jithu Joseph,
Ashok Raj, Tony Luck
On Sun, Jul 10, 2022 at 04:07:36PM +0200, Hans de Goede wrote:
> A recent suggested change to the IFS code has shown that the userspace
> API needs a bit more work, see:
> https://lore.kernel.org/platform-driver-x86/20220708151938.986530-1-jithu.joseph@intel.com/
>
> Mark it as BROKEN before 5.19 ships, to give ourselves one more
> kernel-devel cycle to get the userspace API right.
>
> Link: https://lore.kernel.org/platform-driver-x86/20220708151938.986530-1-jithu.joseph@intel.com/
> Cc: Jithu Joseph <jithu.joseph@intel.com>
> Cc: Ashok Raj <ashok.raj@intel.com>
> Cc: Tony Luck <tony.luck@intel.com>
> Suggested-by: Greg KH <gregkh@linuxfoundation.org>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
> drivers/platform/x86/intel/ifs/Kconfig | 3 +++
> 1 file changed, 3 insertions(+)
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] platform/x86/intel/ifs: Mark as BROKEN
2022-07-10 14:07 [PATCH] platform/x86/intel/ifs: Mark as BROKEN Hans de Goede
2022-07-10 14:13 ` Greg Kroah-Hartman
@ 2022-07-10 15:38 ` Hans de Goede
1 sibling, 0 replies; 3+ messages in thread
From: Hans de Goede @ 2022-07-10 15:38 UTC (permalink / raw)
To: Mark Gross, Andy Shevchenko, Greg Kroah-Hartman
Cc: platform-driver-x86, Jithu Joseph, Ashok Raj, Tony Luck
Hi,
On 7/10/22 16:07, Hans de Goede wrote:
> A recent suggested change to the IFS code has shown that the userspace
> API needs a bit more work, see:
> https://lore.kernel.org/platform-driver-x86/20220708151938.986530-1-jithu.joseph@intel.com/
>
> Mark it as BROKEN before 5.19 ships, to give ourselves one more
> kernel-devel cycle to get the userspace API right.
>
> Link: https://lore.kernel.org/platform-driver-x86/20220708151938.986530-1-jithu.joseph@intel.com/
> Cc: Jithu Joseph <jithu.joseph@intel.com>
> Cc: Ashok Raj <ashok.raj@intel.com>
> Cc: Tony Luck <tony.luck@intel.com>
> Suggested-by: Greg KH <gregkh@linuxfoundation.org>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
I've added this to my review-hans (soon to be for-next) branch now.
Regards,
Hans
> ---
> drivers/platform/x86/intel/ifs/Kconfig | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/platform/x86/intel/ifs/Kconfig b/drivers/platform/x86/intel/ifs/Kconfig
> index 7ce896434b8f..c341a27cc1a3 100644
> --- a/drivers/platform/x86/intel/ifs/Kconfig
> +++ b/drivers/platform/x86/intel/ifs/Kconfig
> @@ -1,6 +1,9 @@
> config INTEL_IFS
> tristate "Intel In Field Scan"
> depends on X86 && CPU_SUP_INTEL && 64BIT && SMP
> + # Discussion on the list has shown that the sysfs API needs a bit
> + # more work, mark this as broken for now
> + depends on BROKEN
> select INTEL_IFS_DEVICE
> help
> Enable support for the In Field Scan capability in select
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-07-10 15:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-07-10 14:07 [PATCH] platform/x86/intel/ifs: Mark as BROKEN Hans de Goede
2022-07-10 14:13 ` Greg Kroah-Hartman
2022-07-10 15:38 ` Hans de Goede
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox