From: Andy Shevchenko <andy@kernel.org>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: Hans de Goede <hdegoede@redhat.com>, platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH v2 2/2] platform/x86: x86-android-tablets: Add Vexia EDU ATLA 10 EC battery driver
Date: Mon, 2 Dec 2024 20:45:29 +0200 [thread overview]
Message-ID: <Z04ASf0znID9C1FN@smile.fi.intel.com> (raw)
In-Reply-To: <b5b40432-77ed-2466-7d30-ce35a239d0ae@linux.intel.com>
On Mon, Dec 02, 2024 at 08:34:01PM +0200, Ilpo Järvinen wrote:
> On Sat, 16 Nov 2024, Hans de Goede wrote:
...
> > +struct atla10_ec_battery_state {
> > + u8 status; /* Using ACPI Battery spec status bits */
> > + u8 capacity; /* Percent */
> > + __le16 charge_now_mAh;
> > + __le16 voltage_now_mV;
> > + __le16 current_now_mA;
> > + __le16 charge_full_mAh;
> > + __le16 temp; /* centi degrees Celsius */
> > +} __packed;
> > +
> > +struct atla10_ec_battery_info {
> > + __le16 charge_full_design_mAh;
> > + __le16 voltage_now_mV; /* Should be design voltage, but is not ? */
> > + __le16 charge_full_design2_mAh;
> > +} __packed;
>
> Both struct have only naturally aligned members. Why is __packed needed?
Wouldn't the second one give sizeof() == 8 rather than 6? Sorry, my memory
about this in C is always flaky.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-12-02 18:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-16 12:16 [PATCH v2 1/2] platform/x86/intel: bytcrc_pwrsrc: Optionally register a power_supply dev Hans de Goede
2024-11-16 12:16 ` [PATCH v2 2/2] platform/x86: x86-android-tablets: Add Vexia EDU ATLA 10 EC battery driver Hans de Goede
2024-12-02 18:34 ` Ilpo Järvinen
2024-12-02 18:45 ` Andy Shevchenko [this message]
2024-12-02 21:48 ` Hans de Goede
2024-12-03 12:58 ` Andy Shevchenko
2024-12-03 15:38 ` Ilpo Järvinen
2024-12-03 16:09 ` Hans de Goede
2024-12-03 19:24 ` Andy Shevchenko
2024-11-16 15:16 ` [PATCH v2 1/2] platform/x86/intel: bytcrc_pwrsrc: Optionally register a power_supply dev Hans de Goede
2024-11-17 20:11 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z04ASf0znID9C1FN@smile.fi.intel.com \
--to=andy@kernel.org \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox