From: Hans de Goede <hdegoede@redhat.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "Andy Shevchenko" <andy@kernel.org>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH v2 2/2] platform/x86: x86-android-tablets: Add Vexia EDU ATLA 10 EC battery driver
Date: Tue, 3 Dec 2024 17:09:57 +0100 [thread overview]
Message-ID: <c19e9043-0750-4eb0-b794-521d946317d6@redhat.com> (raw)
In-Reply-To: <CAHp75VdJ_MfRXXX18c+rB943Saare6n_GEEwko+Hf31UW39XpA@mail.gmail.com>
Hi,
On 3-Dec-24 1:58 PM, Andy Shevchenko wrote:
> On Mon, Dec 2, 2024 at 11:48 PM Hans de Goede <hdegoede@redhat.com> wrote:
>> On 2-Dec-24 7:45 PM, Andy Shevchenko wrote:
>>> On Mon, Dec 02, 2024 at 08:34:01PM +0200, Ilpo Järvinen wrote:
>>>> On Sat, 16 Nov 2024, Hans de Goede wrote:
>
> ...
>
>>>>> +struct atla10_ec_battery_state {
>>>>> + u8 status; /* Using ACPI Battery spec status bits */
>>>>> + u8 capacity; /* Percent */
>
> Then an obvious remark based on Hans' reply, why are these internal
> kernel types and not external ones, i.e. __u8?
Because this is not a uapi header?
Regards,
Hans
next prev parent reply other threads:[~2024-12-03 16:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-16 12:16 [PATCH v2 1/2] platform/x86/intel: bytcrc_pwrsrc: Optionally register a power_supply dev Hans de Goede
2024-11-16 12:16 ` [PATCH v2 2/2] platform/x86: x86-android-tablets: Add Vexia EDU ATLA 10 EC battery driver Hans de Goede
2024-12-02 18:34 ` Ilpo Järvinen
2024-12-02 18:45 ` Andy Shevchenko
2024-12-02 21:48 ` Hans de Goede
2024-12-03 12:58 ` Andy Shevchenko
2024-12-03 15:38 ` Ilpo Järvinen
2024-12-03 16:09 ` Hans de Goede [this message]
2024-12-03 19:24 ` Andy Shevchenko
2024-11-16 15:16 ` [PATCH v2 1/2] platform/x86/intel: bytcrc_pwrsrc: Optionally register a power_supply dev Hans de Goede
2024-11-17 20:11 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c19e9043-0750-4eb0-b794-521d946317d6@redhat.com \
--to=hdegoede@redhat.com \
--cc=andy.shevchenko@gmail.com \
--cc=andy@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox