From: Andy Shevchenko <andy@kernel.org>
To: Hans de Goede <hdegoede@redhat.com>
Cc: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH 3/4] platform/x86: int3472: Fix skl_int3472_handle_gpio_resources() return value
Date: Thu, 28 Nov 2024 17:53:48 +0200 [thread overview]
Message-ID: <Z0iSDNyNhh3UPAN5@smile.fi.intel.com> (raw)
In-Reply-To: <20241128154212.6216-3-hdegoede@redhat.com>
On Thu, Nov 28, 2024 at 04:42:11PM +0100, Hans de Goede wrote:
> The INT3472 code never wants a copy of the ACPI resource to be added
> to the list-head passed to acpi_dev_get_resources().
>
> Make skl_int3472_handle_gpio_resources() always return -errno or 1
> and drop the now no longer acpi_dev_free_resource_list() call.
>
> Also update the inaccurate comment about the return value.
> skl_int3472_handle_gpio_resources() was already returning 1 in the case
> of not a GPIO resource or invalid _DSM return and not -EINVAL / -ENODEV
> as the comment claimed.
...
> - acpi_dev_free_resource_list(&resource_list);
Even though it's better to have this (no-op) call. As people may use the driver
as an example and then make the real leakage somewhere else.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-11-28 15:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-28 15:42 [PATCH 1/4] platform/x86: int3472: Check for adev == NULL Hans de Goede
2024-11-28 15:42 ` [PATCH 2/4] platform/x86: int3472: Drop "pin number mismatch" messages Hans de Goede
2024-11-28 15:52 ` Andy Shevchenko
2024-12-04 17:36 ` Hans de Goede
2024-12-04 18:23 ` Andy Shevchenko
2024-11-28 15:42 ` [PATCH 3/4] platform/x86: int3472: Fix skl_int3472_handle_gpio_resources() return value Hans de Goede
2024-11-28 15:53 ` Andy Shevchenko [this message]
2024-12-04 17:37 ` Hans de Goede
2024-11-28 15:42 ` [PATCH 4/4] platform/x86: int3472: Debug log the sensor name Hans de Goede
2024-11-28 15:51 ` [PATCH 1/4] platform/x86: int3472: Check for adev == NULL Andy Shevchenko
2024-12-04 17:40 ` Hans de Goede
2024-12-04 19:15 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z0iSDNyNhh3UPAN5@smile.fi.intel.com \
--to=andy@kernel.org \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox