Re: [PATCH 3/4] platform/x86: int3472: Fix skl_int3472_handle_gpio_resources() return value

[Hans de Goede <hdegoede@redhat.com>]

Hi,

On 28-Nov-24 4:53 PM, Andy Shevchenko wrote:
> On Thu, Nov 28, 2024 at 04:42:11PM +0100, Hans de Goede wrote:
>> The INT3472 code never wants a copy of the ACPI resource to be added
>> to the list-head passed to acpi_dev_get_resources().
>>
>> Make skl_int3472_handle_gpio_resources() always return -errno or 1
>> and drop the now no longer acpi_dev_free_resource_list() call.
>>
>> Also update the inaccurate comment about the return value.
>> skl_int3472_handle_gpio_resources() was already returning 1 in the case
>> of not a GPIO resource or invalid _DSM return and not -EINVAL / -ENODEV
>> as the comment claimed.
> 
> ...
> 
>> -	acpi_dev_free_resource_list(&resource_list);
> 
> Even though it's better to have this (no-op) call. As people may use the driver
> as an example and then make the real leakage somewhere else.

Ok, I'll keep the call for v2 and adjust the commit msg to match.

Regards,

Hans