Re: [PATCH 2/2] platform/x86: x86-android-tablets: Add Vexia Edu Atla 10 tablet 5V data

[Andy Shevchenko <andy@kernel.org>]

On Mon, Apr 07, 2025 at 11:20:16AM +0200, Hans de Goede wrote:
> The Vexia EDU ATLA 10 tablet comes in 2 different versions with
> significantly different mainboards. The only outward difference is that
> the charging barrel on one is marked 5V and the other is marked 9V.
> 
> Both are x86 ACPI tablets which ships with Android x86 as factory OS.
> with a DSDT which contains a bunch of I2C devices which are not actually
> there, causing various resource conflicts. Enumeration of these is skipped
> through the acpi_quirk_skip_i2c_client_enumeration().
> 
> Extend the existing support for the 9V version by adding support for
> manually instantiating the I2C devices which are actually present on
> the 5V version by adding the necessary device info to
> the x86-android-tablets module.

...

> +	{
> +		/* Vexia Edu Atla 10 tablet 5V version */
> +		.matches = {
> +			/* Having all 3 of these not set is somewhat unique */
> +			DMI_MATCH(DMI_SYS_VENDOR, "To be filled by O.E.M."),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "To be filled by O.E.M."),
> +			DMI_MATCH(DMI_BOARD_NAME, "To be filled by O.E.M."),
> +			/* Above strings are too generic, also match on BIOS date */
> +			DMI_MATCH(DMI_BIOS_DATE, "05/14/2015"),
> +		},

Oh, this is unfortunate matching and quite fragile. Do we have other matching
mechanisms in place in addition to this?

I am not against this change, but perhaps we need also add something to check,
say, CPUID before looking into this table or so?

> +		.driver_data = (void *)&vexia_edu_atla10_5v_info,
> +	},

-- 
With Best Regards,
Andy Shevchenko