Re: [PATCH 2/2] platform/x86: x86-android-tablets: Add Vexia Edu Atla 10 tablet 5V data

[Andy Shevchenko <andy@kernel.org>]

On Mon, Apr 07, 2025 at 01:22:31PM +0200, Hans de Goede wrote:
> On 7-Apr-25 12:32, Andy Shevchenko wrote:
> > On Mon, Apr 07, 2025 at 11:20:16AM +0200, Hans de Goede wrote:

...

> >> +	{
> >> +		/* Vexia Edu Atla 10 tablet 5V version */
> >> +		.matches = {
> >> +			/* Having all 3 of these not set is somewhat unique */
> >> +			DMI_MATCH(DMI_SYS_VENDOR, "To be filled by O.E.M."),
> >> +			DMI_MATCH(DMI_PRODUCT_NAME, "To be filled by O.E.M."),
> >> +			DMI_MATCH(DMI_BOARD_NAME, "To be filled by O.E.M."),
> >> +			/* Above strings are too generic, also match on BIOS date */
> >> +			DMI_MATCH(DMI_BIOS_DATE, "05/14/2015"),
> >> +		},
> > 
> > Oh, this is unfortunate matching and quite fragile. Do we have other matching
> > mechanisms in place in addition to this?
> 
> Having both PRODUCT_NAME and BOARD_NAME set to "To be filled by O.E.M." is
> actually pretty rare. Of all the DMI decode's which I've collected only
> 2 other devices have this. Usually at least on of the 2 is set to something
> less generic even if that something is still sometimes not super useful itself
> like "BayTrail".
> 
> So IMHO combined with the BIOS date this should be plenty unique IMHO.

Sounds like a relief to me. Thanks for digging into this!

-- 
With Best Regards,
Andy Shevchenko