From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: "Shinichiro Kawasaki" <shinichiro.kawasaki@wdc.com>,
"platform-driver-x86@vger.kernel.org"
<platform-driver-x86@vger.kernel.org>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"danilrybakov249@gmail.com" <danilrybakov249@gmail.com>,
"Lukas Wunner" <lukas@wunner.de>,
"Klara Modin" <klarasmodin@gmail.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>
Subject: Re: [PATCH v2] platform/x86: p2sb: Defer P2SB device scan when P2SB device has func 0
Date: Mon, 4 Mar 2024 16:09:49 +0200 [thread overview]
Message-ID: <ZeXWLVHxOAZCHoJZ@smile.fi.intel.com> (raw)
In-Reply-To: <8afa1f78-8b89-4bbc-95e5-35eea76356e4@redhat.com>
On Mon, Mar 04, 2024 at 02:59:57PM +0100, Hans de Goede wrote:
> On 3/4/24 1:13 PM, Shinichiro Kawasaki wrote:
> > On Mar 04, 2024 / 12:04, Hans de Goede wrote:
...
> > Thanks for sharing the insights.
>
> Looking closer at the actual unhiding I don't think accessing func 0
> is the problem. The unhiding is always done on function 0 even when
> retreiving the bar for function 2 (the SPI function).
>
> So taking that into account, as mentioned in the bugzilla, I think
> the problem is probing the other functions (1, 3-7) by calling
> pci_scan_single_device() on them.
So, why we can't simply call pci_dev_present() on the function in a loop?
Will be even simpler fix, no?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-03-04 14:09 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-02 1:28 [PATCH v2] platform/x86: p2sb: Defer P2SB device scan when P2SB device has func 0 Shin'ichiro Kawasaki
2024-03-02 7:28 ` Shinichiro Kawasaki
2024-03-02 11:43 ` Hans de Goede
2024-03-02 23:37 ` Shinichiro Kawasaki
2024-03-03 19:35 ` Hans de Goede
2024-03-04 3:19 ` Shinichiro Kawasaki
2024-03-04 9:55 ` Hans de Goede
2024-03-04 11:04 ` Hans de Goede
2024-03-04 12:13 ` Shinichiro Kawasaki
2024-03-04 13:59 ` Hans de Goede
2024-03-04 14:09 ` Andy Shevchenko [this message]
2024-03-04 14:16 ` Hans de Goede
2024-03-04 14:17 ` Andy Shevchenko
2024-03-04 14:20 ` Andy Shevchenko
2024-03-04 14:24 ` Hans de Goede
2024-03-04 14:35 ` Andy Shevchenko
2024-03-04 14:39 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZeXWLVHxOAZCHoJZ@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=danilrybakov249@gmail.com \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=klarasmodin@gmail.com \
--cc=linux-pci@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=platform-driver-x86@vger.kernel.org \
--cc=shinichiro.kawasaki@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox