[PATCH] Fix Asus B2402FBA internal keyboard and track point

[PATCH] Fix Asus B2402FBA internal keyboard and track point

[Stefan Blum]

By default the internal keyboard and track point on the Asus Expertbook
B2 Flip B2402FVA are not functional.

Similar to the Asus board B2402FBA, on the B2402FVA the internal keyboard
is only functional by adding it to the irq1_level_low_skip_override array.

For the internal elan track point, i have found out that setting the class to
MT_CLS_WIN_8_FORCE_MULTI_INPUT_NSM makes the track point function as expected.

Signed-off-by: Stefan Blum <stefan.blum@gmail.com>

---
 drivers/acpi/resource.c      | 8 ++++++++
 drivers/hid/hid-multitouch.c | 4 ++++
 2 files changed, 12 insertions(+)

diff --git a/drivers/acpi/resource.c b/drivers/acpi/resource.c
index df5d5a554..c29e71401 100644
--- a/drivers/acpi/resource.c
+++ b/drivers/acpi/resource.c
@@ -489,6 +489,14 @@ static const struct dmi_system_id irq1_level_low_skip_override[] = {
 			DMI_MATCH(DMI_BOARD_NAME, "B2402FBA"),
 		},
 	},
+	{
+		/* Asus ExpertBook B2402FVA */
+		.ident = "Asus ExpertBook B2402FVA",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+			DMI_MATCH(DMI_BOARD_NAME, "B2402FVA"),
+		},
+	},
 	{
 		/* Asus ExpertBook B2502 */
 		.matches = {
diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
index 56fc78841..3f93c5ef6 100644
--- a/drivers/hid/hid-multitouch.c
+++ b/drivers/hid/hid-multitouch.c
@@ -1992,6 +1992,10 @@ static const struct hid_device_id mt_devices[] = {
 		HID_DEVICE(BUS_I2C, HID_GROUP_MULTITOUCH_WIN_8,
 			USB_VENDOR_ID_ELAN, 0x3148) },
 
+	{ .driver_data = MT_CLS_WIN_8_FORCE_MULTI_INPUT_NSMU,
+		HID_DEVICE(BUS_I2C, HID_GROUP_MULTITOUCH_WIN_8,
+			USB_VENDOR_ID_ELAN, 0x32ae) },
+
 	/* Elitegroup panel */
 	{ .driver_data = MT_CLS_SERIAL,
 		MT_USB_DEVICE(USB_VENDOR_ID_ELITEGROUP,
-- 
2.39.5

Re: [PATCH] Fix Asus B2402FBA internal keyboard and track point

[Hans de Goede]

Hi Stefan,

Thank you for your patch.

Note you got the model wrong in the subject of this thread,
I'm pretty sure you meant to put "B2402FVA" in the subject.

On 28-Sep-24 6:17 PM, Stefan Blum wrote:
> By default the internal keyboard and track point on the Asus Expertbook
> B2 Flip B2402FVA are not functional.
> 
> Similar to the Asus board B2402FBA, on the B2402FVA the internal keyboard
> is only functional by adding it to the irq1_level_low_skip_override array.
> 
> For the internal elan track point, i have found out that setting the class to
> MT_CLS_WIN_8_FORCE_MULTI_INPUT_NSM makes the track point function as expected.
> 
> Signed-off-by: Stefan Blum <stefan.blum@gmail.com>

Currently this patch touches 2 completely unrelated files. Please
submit a v2 patch series breaking this into 2 patches each for one file.

For adding the "B2402FVA" to drivers/acpi/resource.c we already have
"B2402CBA" (12th gen intel non flip) and "B2402FBA" (12th gen intel flip)
listed. Your "B2402FVA" is the (13th gen intel flip) and there
also exists a "B2402CVA" which is the 13th gen non flip.

So I think it would be best to just fold the 2 existing entries
into 1 entry covering all 4 matching on just "B2402".

Actually writing this has made me take a closer look at all the existing
Asus quirks and I have just posted a series which simplifies the quirks,
dropping 8 quirk table entries while adding support for 3 more Asus
models including your "B2402FVA" model, see:

https://lore.kernel.org/linux-acpi/20241005212819.354681-1-hdegoede@redhat.com/

So there is no need to include the drivers/acpi/resource.c bits in
your v2.

Please do send a v2 for the drivers/hid/hid-multitouch.c change and
please make sure to use the right subject-prefix for that, e.g.
use this as subject:

HID: multitouch: Add support for B2402FBA touchpad

and send that patch to the HID maintainers:

[hans@shalem linux]$ scripts/get_maintainer.pl -f drivers/hid/hid-multitouch.c
Jiri Kosina <jikos@kernel.org> (maintainer:HID CORE LAYER)
Benjamin Tissoires <bentiss@kernel.org> (maintainer:HID CORE LAYER)
linux-input@vger.kernel.org (open list:HID CORE LAYER)

Regards,

Hans





> 
> ---
>  drivers/acpi/resource.c      | 8 ++++++++
>  drivers/hid/hid-multitouch.c | 4 ++++
>  2 files changed, 12 insertions(+)
> 
> diff --git a/drivers/acpi/resource.c b/drivers/acpi/resource.c
> index df5d5a554..c29e71401 100644
> --- a/drivers/acpi/resource.c
> +++ b/drivers/acpi/resource.c
> @@ -489,6 +489,14 @@ static const struct dmi_system_id irq1_level_low_skip_override[] = {
>  			DMI_MATCH(DMI_BOARD_NAME, "B2402FBA"),
>  		},
>  	},
> +	{
> +		/* Asus ExpertBook B2402FVA */
> +		.ident = "Asus ExpertBook B2402FVA",
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> +			DMI_MATCH(DMI_BOARD_NAME, "B2402FVA"),
> +		},
> +	},
>  	{
>  		/* Asus ExpertBook B2502 */
>  		.matches = {
> diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
> index 56fc78841..3f93c5ef6 100644
> --- a/drivers/hid/hid-multitouch.c
> +++ b/drivers/hid/hid-multitouch.c
> @@ -1992,6 +1992,10 @@ static const struct hid_device_id mt_devices[] = {
>  		HID_DEVICE(BUS_I2C, HID_GROUP_MULTITOUCH_WIN_8,
>  			USB_VENDOR_ID_ELAN, 0x3148) },
>  
> +	{ .driver_data = MT_CLS_WIN_8_FORCE_MULTI_INPUT_NSMU,
> +		HID_DEVICE(BUS_I2C, HID_GROUP_MULTITOUCH_WIN_8,
> +			USB_VENDOR_ID_ELAN, 0x32ae) },
> +
>  	/* Elitegroup panel */
>  	{ .driver_data = MT_CLS_SERIAL,
>  		MT_USB_DEVICE(USB_VENDOR_ID_ELITEGROUP,