Re: [PATCH v5 00/10] platform/x86/amd/pmc: Updates to AMD PMC driver

["Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>]

On Fri, 8 Nov 2024, Shyam Sundar S K wrote:

> Updates include:
> - Rework STB code and move into a separate file
> - Update the code with new IP block information for newer SoCs
> - Add STB support for new generation
> - Add STB support for Ryzen desktop variants
> - Updates to MAINTAINERS record.
> 
> v5:
> ----
>  - Merge patch1 and 2 of v4
>  - Update Ilpo tags
>  - drop explicit typecasting.
>  - Use switch() for getting the message port
>  - Rename function names

Thanks for the update. I applied v5 to review-ilpo-next branch. I ended up 
reordering ips_ptr and active_ips members in the struct amd_pmc_dev to 
group them together.

While checking this series out, I notice there's also one sparse warning
in amd/pmc dir:

drivers/platform/x86/amd/pmc/mp2_stb.c:105:30: warning: incorrect type in 
assignment (different address spaces)
drivers/platform/x86/amd/pmc/mp2_stb.c:105:30:    expected void [noderef] 
__iomem *vslbase
drivers/platform/x86/amd/pmc/mp2_stb.c:105:30:    got void *

If you could fix that please.

-- 
 i.

> 
> v4:
> ----
>   - Reorder patches as suggested by Mario and Ilpo
>   - Squash patches
>   - Update tags
> 
> v3:
> ----
>  - Split patch 1/8 of v2 into two more patches
>  - Add helper for printing S2D/PMC ports
>  - Use ARRAY_SIZE() for getting the number of IPs
>  - Address other remarks from Ilpo.
> 
> v2:
> ----
>  - Add Mario's Reviewed-by tags
>  - Add amd_stb_update_args() to simplify code handling
>  - use cpu_feature_enabled() instead of root port's cpu_id information.
> 
> Shyam Sundar S K (10):
>   platform/x86/amd/pmc: Move STB block into amd_pmc_s2d_init()
>   platform/x86/amd/pmc: Move STB functionality to a new file for better
>     code organization
>   platform/x86/amd/pmc: Update function names to align with new STB file
>   platform/x86/amd/pmc: Define enum for S2D/PMC msg_port and add helper
>     function
>   platform/x86/amd/pmc: Isolate STB code changes to a new file
>   platform/x86/amd/pmc: Use ARRAY_SIZE() to fill num_ips information
>   platform/x86/amd/pmc: Update IP information structure for newer SoCs
>   platform/x86/amd/pmc: Update S2D message id for 1Ah Family 70h model
>   platform/x86/amd/pmc: Add STB support for AMD Desktop variants
>   MAINTAINERS: Change AMD PMC driver status to "Supported"
> 
>  MAINTAINERS                            |   2 +-
>  drivers/platform/x86/amd/pmc/Makefile  |   2 +-
>  drivers/platform/x86/amd/pmc/mp1_stb.c | 332 ++++++++++++++++++++++
>  drivers/platform/x86/amd/pmc/pmc.c     | 377 +++++--------------------
>  drivers/platform/x86/amd/pmc/pmc.h     |  22 +-
>  5 files changed, 424 insertions(+), 311 deletions(-)
>  create mode 100644 drivers/platform/x86/amd/pmc/mp1_stb.c
> 
>