Re: [PATCH v5 00/10] platform/x86/amd/pmc: Updates to AMD PMC driver

[Shyam Sundar S K <Shyam-sundar.S-k@amd.com>]

On 12/2/2024 23:23, Ilpo Järvinen wrote:
> On Fri, 8 Nov 2024, Shyam Sundar S K wrote:
> 
>> Updates include:
>> - Rework STB code and move into a separate file
>> - Update the code with new IP block information for newer SoCs
>> - Add STB support for new generation
>> - Add STB support for Ryzen desktop variants
>> - Updates to MAINTAINERS record.
>>
>> v5:
>> ----
>>  - Merge patch1 and 2 of v4
>>  - Update Ilpo tags
>>  - drop explicit typecasting.
>>  - Use switch() for getting the message port
>>  - Rename function names
> 
> Thanks for the update. I applied v5 to review-ilpo-next branch. I ended up 
> reordering ips_ptr and active_ips members in the struct amd_pmc_dev to 
> group them together.
> 
> While checking this series out, I notice there's also one sparse warning
> in amd/pmc dir:
> 
> drivers/platform/x86/amd/pmc/mp2_stb.c:105:30: warning: incorrect type in 
> assignment (different address spaces)
> drivers/platform/x86/amd/pmc/mp2_stb.c:105:30:    expected void [noderef] 
> __iomem *vslbase
> drivers/platform/x86/amd/pmc/mp2_stb.c:105:30:    got void *
> 
> If you could fix that please.
> 

Thank you, Ilpo. Sure, I will send out a fix in a while.

Thanks,
Shyam