[PATCH] platform/x86/hp: hp-bioscfg: Fix kobject warnings for empty attribute names

[PATCH] platform/x86/hp: hp-bioscfg: Fix kobject warnings for empty attribute names

[Mario Limonciello]

The hp-bioscfg driver attempts to register kobjects with empty names when
the HP BIOS returns attributes with empty name strings. This causes
multiple kernel warnings:

  kobject: (00000000135fb5e6): attempted to be registered with empty name!
  WARNING: CPU: 14 PID: 3336 at lib/kobject.c:219 kobject_add_internal+0x2eb/0x310

Add validation in hp_init_bios_buffer_attribute() to check if the
attribute name is empty after parsing it from the WMI buffer. If empty,
log a debug message and skip registration of that attribute, allowing the
module to continue processing other valid attributes.

Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
---
 drivers/platform/x86/hp/hp-bioscfg/bioscfg.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/platform/x86/hp/hp-bioscfg/bioscfg.c b/drivers/platform/x86/hp/hp-bioscfg/bioscfg.c
index 5bfa7159f5bc..5bee916429aa 100644
--- a/drivers/platform/x86/hp/hp-bioscfg/bioscfg.c
+++ b/drivers/platform/x86/hp/hp-bioscfg/bioscfg.c
@@ -781,6 +781,12 @@ static int hp_init_bios_buffer_attribute(enum hp_wmi_data_type attr_type,
 	if (ret < 0)
 		goto buff_attr_exit;
 
+	if (strlen(str) == 0) {
+		pr_debug("Ignoring attribute with empty name\n");
+		ret = 0;
+		goto buff_attr_exit;
+	}
+
 	if (attr_type == HPWMI_PASSWORD_TYPE ||
 	    attr_type == HPWMI_SECURE_PLATFORM_TYPE)
 		temp_kset = bioscfg_drv.authentication_dir_kset;
-- 
2.52.0

Re: [PATCH] platform/x86/hp: hp-bioscfg: Fix kobject warnings for empty attribute names

[Ilpo Järvinen]

On Wed, 14 Jan 2026, Mario Limonciello wrote:

> The hp-bioscfg driver attempts to register kobjects with empty names when
> the HP BIOS returns attributes with empty name strings. This causes
> multiple kernel warnings:
> 
>   kobject: (00000000135fb5e6): attempted to be registered with empty name!
>   WARNING: CPU: 14 PID: 3336 at lib/kobject.c:219 kobject_add_internal+0x2eb/0x310
> 
> Add validation in hp_init_bios_buffer_attribute() to check if the
> attribute name is empty after parsing it from the WMI buffer. If empty,
> log a debug message and skip registration of that attribute, allowing the
> module to continue processing other valid attributes.
> 
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>

A Fixes tag?

> ---
>  drivers/platform/x86/hp/hp-bioscfg/bioscfg.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/platform/x86/hp/hp-bioscfg/bioscfg.c b/drivers/platform/x86/hp/hp-bioscfg/bioscfg.c
> index 5bfa7159f5bc..5bee916429aa 100644
> --- a/drivers/platform/x86/hp/hp-bioscfg/bioscfg.c
> +++ b/drivers/platform/x86/hp/hp-bioscfg/bioscfg.c
> @@ -781,6 +781,12 @@ static int hp_init_bios_buffer_attribute(enum hp_wmi_data_type attr_type,
>  	if (ret < 0)
>  		goto buff_attr_exit;
>  
> +	if (strlen(str) == 0) {

+ #include.

> +		pr_debug("Ignoring attribute with empty name\n");

This too seems to lack an include.

(Both problems seem to pre-exist.)

> +		ret = 0;
> +		goto buff_attr_exit;
> +	}
> +
>  	if (attr_type == HPWMI_PASSWORD_TYPE ||
>  	    attr_type == HPWMI_SECURE_PLATFORM_TYPE)
>  		temp_kset = bioscfg_drv.authentication_dir_kset;
> 

-- 
 i.