[Bug 216647] New: first hibernate to disk fails on HP EliteBook 845 G8

[Bug 216647] New: first hibernate to disk fails on HP EliteBook 845 G8

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=216647

            Bug ID: 216647
           Summary: first hibernate to disk fails on HP EliteBook 845 G8
           Product: Drivers
           Version: 2.5
    Kernel Version: 6.0.6
          Hardware: AMD
                OS: Linux
              Tree: Mainline
            Status: NEW
          Severity: normal
          Priority: P1
         Component: Platform_x86
          Assignee: drivers_platform_x86@kernel-bugs.osdl.org
          Reporter: kolAflash@kolahilft.de
        Regression: No

Created attachment 303115
  --> https://bugzilla.kernel.org/attachment.cgi?id=303115&action=edit
dmesg log (kernel.org 6.0.6)

On my HP EliteBook 845 G8 the first hibernate to disk after a fresh boot often
fails.

See attached dmesg log at position 141.752276.
The second hibernate to disk at position 161.315363 is successful.



= System =

Model: HP EliteBook 845 G8 (notebook)
CPU+GPU: Ryzen 5650U incl. Radeon GPU
Kernel: 6.0.6 compiled from kernel.org
OS: openSUSE-15.4
Memory: 64 GB
SWAP: 64 GB in a file: /swap

Partitions:
NAME                MAJ:MIN RM  SIZE RO TYPE  MOUNTPOINTS
nvme0n1             259:0    0  1,8T  0 disk  
├─nvme0n1p1         259:1    0  512M  0 part  /boot/efi
├─nvme0n1p2         259:2    0   16M  0 part  
├─nvme0n1p3         259:3    0    2G  0 part  /boot
└─nvme0n1p4         259:4    0  1,8T  0 part  
  └─nvme0n1p4_crypt 254:0    0  1,8T  0 crypt /
(nvme0n1p2 is a "BIOS boot" partition)



Maybe related:
Bug 216516 - s2ram freezes screen (Ryzen-5650U incl. Radeon GPU)
Bug 216574 - Hybrid System Suspend broken HP EliteBook 845 G8 (a.k.a. Hybrid
Sleep / s2both) (s2idle Notebook)

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 216647] first hibernate to disk fails on HP EliteBook 845 G8

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=216647

Mario Limonciello (AMD) (mario.limonciello@amd.com) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mario.limonciello@amd.com

--- Comment #1 from Mario Limonciello (AMD) (mario.limonciello@amd.com) ---
2022-10-31T14:01:20.603318+01:00 myhost kernel: [  150.051133][ T5939] amdgpu
0000:05:00.0: amdgpu: 00000000604fe5dc pin failed
2022-10-31T14:01:20.603321+01:00 myhost kernel: [  150.051137][ T5939]
[drm:dm_plane_helper_prepare_fb [amdgpu]] *ERROR* Failed to pin framebuffer
with error -19

This is probably at least partially:

https://gitlab.freedesktop.org/drm/amd/-/issues/2213

You should keep an eye for when the solution for that comes around if it
improves your problem.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 216647] first hibernate to disk fails on HP EliteBook 845 G8

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=216647

--- Comment #2 from Mario Limonciello (AMD) (mario.limonciello@amd.com) ---
Please try the stuff listed in this comment

https://gitlab.freedesktop.org/drm/amd/-/issues/2213#note_1618476

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 216647] first hibernate to disk fails on HP EliteBook 845 G8

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=216647

Mario Limonciello (AMD) (mario.limonciello@amd.com) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |NEEDINFO

--- Comment #3 from Mario Limonciello (AMD) (mario.limonciello@amd.com) ---
Two of those three patches are in 6.0.7, would be good to know if that helps
your problem.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 216647] first hibernate to disk fails on HP EliteBook 845 G8

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=216647

--- Comment #4 from Mario Limonciello (AMD) (mario.limonciello@amd.com) ---
OK 6.0.7 +
https://cgit.freedesktop.org/drm/drm-misc/commit/?h=drm-misc-fixes&id=e0b26b9482461e9528552f54fa662c2269f75b3f
please.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 216647] first hibernate to disk fails on HP EliteBook 845 G8

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=216647

--- Comment #5 from kolAflash (kolAflash@kolahilft.de) ---
Created attachment 303251
  --> https://bugzilla.kernel.org/attachment.cgi?id=303251&action=edit
kernel logs for hibernation with platform and with shutdown (Linux 6.0.9)

@Mario

(In reply to Mario Limonciello (AMD) from comment #4)
> OK 6.0.7 +
> https://cgit.freedesktop.org/drm/drm-misc/commit/?h=drm-misc-
> fixes&id=e0b26b9482461e9528552f54fa662c2269f75b3f please.

I've just tested 6.0.9.
Looks like that commit is already included in 6.0.9. So I didn't apply it.

In the meantime I figured out, that
  /sys/power/disk = shutdown
seems to work better than the default
  /sys/power/disk = platform

So I did a test with "shutdown" and one with "platform".
Result:
"shutdown" worked fine!
With "platform" the first hibernation still fails.
I've attached logs with the test results.

Before I used 6.0.8 which also had good results with "shutdown", but bad
behavior with "platform".
Note:
For everyday use I changed /etc/systemd/sleep.conf -> HibernateMode=shutdown

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 216647] first hibernate to disk fails on HP EliteBook 845 G8

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=216647

--- Comment #6 from Mario Limonciello (AMD) (mario.limonciello@amd.com) ---
Can you please better describe the symptoms of the failure you're seeing with
"platform".  I don't see anything immediately obvious jumping out.

You can try to take these two commits and see if it helps.
https://github.com/torvalds/linux/commit/4f2bea62cf3874c5a58e987b0b472f9fb57117a2
https://patchwork.freedesktop.org/patch/512917/

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 216647] first hibernate to disk fails on HP EliteBook 845 G8

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=216647

--- Comment #7 from kolAflash (kolAflash@kolahilft.de) ---
Created attachment 303358
  --> https://bugzilla.kernel.org/attachment.cgi?id=303358&action=edit
kernel log for hibernation with platform (Linux 6.0.11)

Hi Mario,

thank you very much for your patience!


(In reply to Mario Limonciello (AMD) from comment #6)
> Can you please better describe the symptoms of the failure you're seeing
> with "platform".  I don't see anything immediately obvious jumping out.

With "platform" the system doesn't really enter hibernation. So the notebook
stays on and doesn't turn off as expected for hibernation. (power led stays on)

The screen just becomes black for a few seconds. But then the system continues
normally. (not crashed, still usable, but not powered off as expected for
hibernation)


You can see that there are just 10 seconds between
  PM: hibernation: hibernation entry
and
  PM: hibernation: hibernation exit
in the
  hibernate_broken_via_platform_v6.0.9.txt
(see attachment 303251 in comment 5)
In this time the screen was black.



> You can try to take these two commits and see if it helps.
> https://github.com/torvalds/linux/commit/
> 4f2bea62cf3874c5a58e987b0b472f9fb57117a2
> https://patchwork.freedesktop.org/patch/512917/

I've just tested 6.0.11.
Looks like both commits are already included in 6.0.11. So I didn't apply them.

Problem persists. See attached log.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 216647] first hibernate to disk fails on HP EliteBook 845 G8

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=216647

--- Comment #8 from Mario Limonciello (AMD) (mario.limonciello@amd.com) ---
Oh I must have missed this the first time:

> Wakeup pending. Abort CPU freeze

So we need to figure out what event is causing the aborted hibernate when it's
set to platform.

Can you please share a log with /sys/power/pm_debug_messages set?
Also when the failure happens what does /sys/power/pm_wakeup_irq indicate the
IRQ was?

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 216647] first hibernate to disk fails on HP EliteBook 845 G8

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=216647

Mario Limonciello (AMD) (mario.limonciello@amd.com) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Platform_x86                |Hibernation/Suspend
           Assignee|drivers_platform_x86@kernel |rjw@rjwysocki.net
                   |-bugs.osdl.org              |
            Product|Drivers                     |Power Management

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.