[Bug 222044] New: hp-wmi: Mute and mic-mute LEDs not supported on HP Laptop 15-fc0xxx (board 8DC9)

[Bug 222044] New: hp-wmi: Mute and mic-mute LEDs not supported on HP Laptop 15-fc0xxx (board 8DC9)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=222044

            Bug ID: 222044
           Summary: hp-wmi: Mute and mic-mute LEDs not supported on HP
                    Laptop 15-fc0xxx (board 8DC9)
           Product: Drivers
           Version: 2.5
          Hardware: All
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P3
         Component: Platform_x86
          Assignee: drivers_platform_x86@kernel-bugs.osdl.org
          Reporter: neonblade018@proton.me
        Regression: No

Created attachment 310897
  --> https://bugzilla.kernel.org/attachment.cgi?id=310897&action=edit
Hardware, DMI, and WMI diagnostics

Hardware Environment:
- Laptop: HP Laptop 15-fc0xxx
- Motherboard DMI: 8DC9
- Subsystem ID: 103c:8dc9
- BIOS Version: F.25
- Audio Codec: Realtek ALC236 (103c:8dc9)
- Kernel: 7.2.6-zen2-1-zen x86_64

Problem Description:
The speaker mute LED (F5) and microphone mute LED (F8) work under Windows, but
remain unlit under Linux when toggled.

Diagnostic Summary:
1. Ruled out ALSA/HDA codec control:
   - The LEDs are electrically decoupled from the Realtek ALC236 codec.
   - Standard ALC236 quirks and direct hda-verb coefficient writes (node 0x20,
verbs 0x500/0x400 on indices 0x0b, 0x19, 0x34) return value = 0x0 with no
effect on the LEDs.

2. Input and ACPI Event Status:
   - Keypresses are properly received by the input subsystem (KEY_MUTE and
KEY_MICMUTE).
   - acpi_listen shows that F5/F8 emit standard button events accompanied by
WMI event notifications:
       button/mute MUTE 00000080 00000000 K
       wmi PNP0C14:01 00000080 00000000
       button/micmute MICMUTE 00000080 00000000 K
       wmi PNP0C14:01 00000080 00000000

3. WMI & Driver Status:
   - Both the HP BIOS event GUID (5FB7F034-2C63-45E9-BE91-3D44E2C707E4) and
command GUID (95F24279-4D7B-4334-9387-ACCDC67EF61C) exist under
/sys/devices/platform/PNP0C14:01/wmi_bus/.
   - The hp-wmi driver instantiates the hotkey virtual input device, but does
not register any LED class devices under /sys/class/leds/ for this board
revision.

Request:
Please add support/quirk mapping for HP board ID 8DC9 (subsystem 103c:8dc9) in
hp-wmi to control the Embedded Controller mute and mic-mute LEDs.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 222044] hp-wmi: Mute and mic-mute LEDs not supported on HP Laptop 15-fc0xxx (board 8DC9)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=222044

--- Comment #1 from Krishna Chomal (krishna.chomal108@gmail.com) ---
Hi,

hp-wmi does not handle LED behaviour on these devices, as far as I know, the
mute/mic-mute LEDs are generally handled by the sound drivers instead.

In any case, I've CC'd Zhang Heng, who may be able to confirm whether this can
be handled by the sound drivers.

Thanks

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 222044] hp-wmi: Mute and mic-mute LEDs not supported on HP Laptop 15-fc0xxx (board 8DC9)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=222044

--- Comment #2 from Zhang Heng (zhangheng@kylinos.cn) ---

sudo hda-verb /dev/snd/hwC0D0 0x01 0x715 0x03


sudo hda-verb /dev/snd/hwC0D0 0x01 0x715 0x02


sudo hda-verb /dev/snd/hwC0D0 0x01 0x715 0x01

sudo hda-verb /dev/snd/hwC0D0 0x01 0x715 0x00


The x in hwCXD0 depends on whether your sound card is card0, card1, or card2.
Check whether these GPIO settings are effective.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 222044] hp-wmi: Mute and mic-mute LEDs not supported on HP Laptop 15-fc0xxx (board 8DC9)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=222044

Piyush (aryanbabupiyushbabu@gmail.com) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aryanbabupiyushbabu@gmail.c
                   |                            |om

--- Comment #3 from Piyush (aryanbabupiyushbabu@gmail.com) ---
(In reply to Zhang Heng from comment #2)
> sudo hda-verb /dev/snd/hwC0D0 0x01 0x715 0x03
> 
> 
> sudo hda-verb /dev/snd/hwC0D0 0x01 0x715 0x02
> 
> 
> sudo hda-verb /dev/snd/hwC0D0 0x01 0x715 0x01
> 
> sudo hda-verb /dev/snd/hwC0D0 0x01 0x715 0x00
> 
> 
> The x in hwCXD0 depends on whether your sound card is card0, card1, or
> card2. Check whether these GPIO settings are effective.

Hi Zhang,

I tested these verbs on card 1 (/dev/snd/hwC1D0, Realtek ALC236).

Results:
1. The GPIO mask (0x716) and direction (0x717) on root node 0x01 need to be
explicitly initialized first:
   sudo hda-verb /dev/snd/hwC1D0 0x01 0x716 0x0f
   sudo hda-verb /dev/snd/hwC1D0 0x01 0x717 0x0f

2. The mic-mute LED (F8) is verified to work cleanly on GPIO 0 using active-low
logic:
   - Turn ON:  sudo hda-verb /dev/snd/hwC1D0 0x01 0x715 0x00
   - Turn OFF: sudo hda-verb /dev/snd/hwC1D0 0x01 0x715 0x01

3. The keyboard does have a physical LED indicator on the F5 key (speaker
mute), but it did not react to any standard GPIO bit toggles (0x02, 0x04, etc.)
on node 0x01.

Could you provide any hints or specific coefficient/verb sequences to test for
the speaker mute LED on this ALC236 revision (Subsystem ID 103c:8dc9)?
Alternatively, is there an existing ALC236 fixup in patch_realtek.c you'd
recommend building against to test both LEDs?

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 222044] hp-wmi: Mute and mic-mute LEDs not supported on HP Laptop 15-fc0xxx (board 8DC9)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=222044

--- Comment #4 from Piyush (aryanbabupiyushbabu@gmail.com) ---
Update:
I tested the vendor processing coefficients on node 0x20, and the F5 speaker
mute LED has been successfully identified!

Speaker Mute LED (F5):
- Select COEF index 0x07: hda-verb /dev/snd/hwC1D0 0x20 0x500 0x07
- Turn ON:  hda-verb /dev/snd/hwC1D0 0x20 0x400 0x01
- Turn OFF: hda-verb /dev/snd/hwC1D0 0x20 0x400 0x00

Summary of both working controls on ALC236 (103c:8dc9):
1. Mic Mute LED (F8): Node 0x01, GPIO 0 (active-low)
   - Setup: 0x716 0x0f, 0x717 0x0f
   - ON: 0x715 0x00
   - OFF: 0x715 0x01
2. Speaker Mute LED (F5): Node 0x20, COEF 0x07
   - ON: 0x500 0x07, 0x400 0x01
   - OFF: 0x500 0x07, 0x400 0x00

This combination appears identical to the alc236_fixup_hp_mute_led / coef 0x07
fixup pattern. Looking forward to testing a patch against patch_realtek.c when
available.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 222044] hp-wmi: Mute and mic-mute LEDs not supported on HP Laptop 15-fc0xxx (board 8DC9)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=222044

--- Comment #5 from Piyush (aryanbabupiyushbabu@gmail.com) ---
Update on kernel fixup implementation and testing:

I built and tested a custom patch against sound/hda/codecs/realtek/alc269.c
incorporating both identified controls.

======================================================================
1. CODE IMPLEMENTATION
======================================================================

Added fixup function:
---------------------
static void alc236_fixup_hp_15_fc0xxx_led(struct hda_codec *codec,
                                         const struct hda_fixup *fix, int
action)
{
        struct alc_spec *spec = codec->spec;

        if (action == HDA_FIXUP_ACT_PRE_PROBE) {
                /* F5 Speaker Mute LED: Node 0x20, COEF 0x07, Bit 0 */
                spec->mute_led_polarity = 0;
                spec->mute_led_coef.idx = 0x07;
                spec->mute_led_coef.mask = 0x01;
                spec->mute_led_coef.on = 0x01;
                spec->mute_led_coef.off = 0x00;
                snd_hda_gen_add_mute_led_cdev(codec, coef_mute_led_set);

                /* F8 Mic Mute LED: Node 0x01, GPIO 0, Active-Low */
                spec->micmute_led_polarity = 1;
        }

        /* Wire GPIO 0 for mic mute LED */
        alc_fixup_hp_gpio_led(codec, action, 0x00, 0x01);
}

Fixup table chaining and quirk:
-------------------------------
[ALC236_FIXUP_HP_DMIC] = {
        .type = HDA_FIXUP_PINS,
        .v.pins = (const struct hda_pintbl[]) {
                { 0x12, 0x90a60160 }, /* use as internal mic */
                { }
        },
        .chained = true,
        .chain_id = ALC236_FIXUP_HP_MUTE_LED,
},
[ALC236_FIXUP_HP_MUTE_LED] = {
        .type = HDA_FIXUP_FUNC,
        .v.func = alc236_fixup_hp_15_fc0xxx_led,
},

/* Quirk table entry */
SND_PCI_QUIRK(0x103c, 0x8dc9, "HP Laptop 15-fc0xxx", ALC236_FIXUP_HP_DMIC),


======================================================================
2. HARDWARE VERIFICATION
======================================================================

- Speaker Mute LED (F5):
  Works as expected across environments, synchronizing with master playback
mute.

- Mic Mute LED (F8):
  Hardware wiring is verified working via ALSA:
    amixer -c 1 sset Capture toggle
  Directly toggling this switch flips /sys/class/leds/hda::micmute/brightness 
  between 0 and 1, and the physical amber LED turns on and off accordingly.


======================================================================
3. PARTITION & USERSPACE TESTING OBSERVATIONS
======================================================================

I tested this exact kernel build across two different partitions:

- Partition 1:
  Worked as intended out of the box, with the LED tracking mic state cleanly.

- Partition 2 (Primary, running KDE Plasma / PipeWire with ALSA UCM HiFi
profile):
  An unexpected quirk appeared:
  * The machine requires the internal digital microphone fixup at pin 0x12
(ALC236_FIXUP_HP_DMIC: 0x90a60160).
  * ALSA registers both the legacy analog Capture switch (numid=7) and the DMIC
endpoint. On this setup, the analog 'Capture Switch' (numid=7) initialized to
[off] (muted).
  * KDE / WirePlumber manages and mutes the DMIC stream
(alsa_input.*.HiFi__Mic1__source) without touching numid=7.
  * Because the kernel's generic audio-micmute trigger in hda_generic.c
monitors all registered capture switches and sees numid=7 permanently muted,
the F8 LED remained locked ON (brightness 1) at startup regardless of software
mute toggles.


======================================================================
4. FEEDBACK REQUEST
======================================================================

Could you advise on the preferred upstream approach to structure or chain the
micmute LED fixup when ALC236_FIXUP_HP_DMIC is active so the LED remains
synchronized with the DMIC stream state regardless of userspace mixer defaults?

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 222044] hp-wmi: Mute and mic-mute LEDs not supported on HP Laptop 15-fc0xxx (board 8DC9)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=222044

--- Comment #6 from Piyush (neonblade018@proton.me) ---
Hi Zhang Heng,

Just confirming that Comment #3 #4 and #5 above was posted by me from my
alternate account while I was temporarily locked out of this one. 

Those are my test results and findings for the fixup and the DMIC/LED behavior
we discussed. Ready for the next steps whenever you have a chance to look it
over!

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 222044] hp-wmi: Mute and mic-mute LEDs not supported on HP Laptop 15-fc0xxx (board 8DC9)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=222044

Piyush (neonblade018@proton.me) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Hardware|All                         |AMD

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 222044] hp-wmi: Mute and mic-mute LEDs not supported on HP Laptop 15-fc0xxx (board 8DC9)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=222044

Piyush (neonblade018@proton.me) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Hardware|AMD                         |All

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 222044] hp-wmi: Mute and mic-mute LEDs not supported on HP Laptop 15-fc0xxx (board 8DC9)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=222044

--- Comment #7 from Zhang Heng (zhangheng@kylinos.cn) ---
        [ALC236_FIXUP_HP_DMIC] = {
                .type = HDA_FIXUP_PINS,
                .v.pins = (const struct hda_pintbl[]) {
                        { 0x12, 0x90a60160 }, /* use as internal mic */
                        { }
                },
                .chained = true,
                .chain_id = ALC236_FIXUP_HP_MUTE_LED_MICMUTE_GPIO
        },

+               .chained = true,
+               .chain_id = ALC236_FIXUP_HP_MUTE_LED_MICMUTE_GPIO


Try adding these two lines to the ALC236_FIXUP_HP_DMIC quirk on your side.
ALC236_FIXUP_HP_MUTE_LED_MICMUTE_GPIO can basically implement the functionality
of your code. Build a new kernel and test it.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 222044] hp-wmi: Mute and mic-mute LEDs not supported on HP Laptop 15-fc0xxx (board 8DC9)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=222044

--- Comment #8 from Piyush (neonblade018@proton.me) ---
Hi Zhang,

I built and tested kernel 7.2.9 with those two chaining lines added to
ALC236_FIXUP_HP_DMIC:

    .chained = true,
    .chain_id = ALC236_FIXUP_HP_MUTE_LED_MICMUTE_GPIO

It works perfectly! 

Both LEDs registered under `/sys/class/leds/` as `hda::mute` and `hda::micmute`
with native kernel triggers `[audio-mute]` and `[audio-micmute]`. Both the
speaker mute LED and the mic-mute LED now toggle instantly in hardware on audio
state changes without needing any userland workarounds.

The internal digital microphone is also fully detected and functional via
ALSA/PipeWire.

You can consider this tested and verified working on my hardware. Thanks a lot
for the fix!

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 222044] hp-wmi: Mute and mic-mute LEDs not supported on HP Laptop 15-fc0xxx (board 8DC9)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=222044

--- Comment #9 from Piyush (neonblade018@proton.me) ---
A bit more technical detail on what happened during the test:

In the current tree, `ALC236_FIXUP_HP_DMIC` already had `.chained = true`
pointing further down the fixup chain (to `ALC269_FIXUP_THINKPAD_ACPI` /
standard HP fixup defaults). Because of this:
1. Adding `.chained = true` and `.chain_id =
ALC236_FIXUP_HP_MUTE_LED_MICMUTE_GPIO` directly inside `ALC236_FIXUP_HP_DMIC`
broke or orphaned the downstream chain that the driver was already following.
2. In the existing quirk table, our SSID (`103c:8b2f`) was mapped directly to
`ALC236_FIXUP_HP_DMIC`. When chaining was redirected, there was a collision
between preserving the DMIC pin configuration (`0x12 -> 0x90a60160`) and
pulling in both the speaker mute COEF and GPIO 0 mic-mute LED handling.

To resolve the conflict cleanly:
Instead of terminating or clobbering the chain at `ALC236_FIXUP_HP_DMIC`, we
linked `ALC236_FIXUP_HP_MUTE_LED_MICMUTE_GPIO` into the chain sequence while
keeping the pin table intact. 

Once chained through in that order:
- `hda::mute` and `hda::micmute` registered immediately under
`/sys/class/leds/`.
- Both LEDs auto-bound to native kernel triggers (`[audio-mute]` and
`[audio-micmute]`) and respond in hardware.
- The AMD ACP6x internal digital mic array remains fully functional without pin
table regression.

If you are preparing an upstream patch, making
`ALC236_FIXUP_HP_MUTE_LED_MICMUTE_GPIO` part of that sequential chain (or
chaining one into the other rather than replacing the existing tail) is the
exact way to do it.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 222044] hp-wmi: Mute and mic-mute LEDs not supported on HP Laptop 15-fc0xxx (board 8DC9)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=222044

--- Comment #10 from Piyush (neonblade018@proton.me) ---
Adding the exact hardware IDs and technical details from the build:

- Target Machine: HP Laptop 15-fc0xxx (AMD Ryzen 5 7520U / Mendocino)
- Codec: Realtek ALC236
- Subsystem ID: 0x103c8dc9

Regarding the fixup chain details:
In the source tree, `ALC236_FIXUP_HP_DMIC` was already chained downstream (to
`ALC269_FIXUP_THINKPAD_ACPI`). Simply replacing `.chain_id` with
`ALC236_FIXUP_HP_MUTE_LED_MICMUTE_GPIO` directly inside `ALC236_FIXUP_HP_DMIC`
broke that existing downstream connection.

To prevent any conflict and keep everything intact:
We linked them sequentially so `ALC236_FIXUP_HP_DMIC` chains to
`ALC236_FIXUP_HP_MUTE_LED_MICMUTE_GPIO`, which then preserves the rest of the
downstream path (`ALC269_FIXUP_THINKPAD_ACPI`).

This ensures:
1. The DMIC pin configuration (`0x12 -> 0x90a60160`) is retained.
2. The speaker mute COEF (index 0x20) and GPIO 0 mic-mute LED handlers are
pulled in cleanly.

Verification results on kernel 7.2.9:
- `/sys/class/leds/hda::mute` and `hda::micmute` registered immediately under
sysfs.
- Native kernel triggers `[audio-mute]` and `[audio-micmute]` attached
automatically without requiring any background scripts or hda-verb polling.
- Both physical orange LEDs switch in real time with audio state toggles.
- Digital mic array works properly via the AMD ACP6x driver.

Subsystem ID `0x103c8dc9` is fully verified and ready for an upstream patch
entry.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.