[PATCH v2 0/3] Fixes for hp-bioscfg

[PATCH v2 0/3] Fixes for hp-bioscfg

[Mario Limonciello]

When working on fwupd code on an HP system I noticed that all the BIOS
settings were missing in fwupd.  I thought I forgot to compile the
hp-bioscfg module, but actually it was compiled just not loading.

Once I loaded it, I found various problems with boundary handling and
attributes on an HP Z2 Mini G1a. 

This series fixes automatic loading as well as those boundary problems.

Mario Limonciello (3):
  platform/x86: hp-bioscfg: Fix kobject warnings for empty attribute
    names
  platform/x86: hp-bioscfg: Fix kernel panic in GET_INSTANCE_ID macro
  platform/x86: hp-bioscfg: Fix automatic module loading

 drivers/platform/x86/hp/hp-bioscfg/bioscfg.c |  8 ++++++++
 drivers/platform/x86/hp/hp-bioscfg/bioscfg.h | 12 +++++++-----
 2 files changed, 15 insertions(+), 5 deletions(-)

-- 
2.52.0

Re: [PATCH v2 0/3] Fixes for hp-bioscfg

[Ilpo Järvinen]

On Thu, 15 Jan 2026 14:31:09 -0600, Mario Limonciello wrote:

> When working on fwupd code on an HP system I noticed that all the BIOS
> settings were missing in fwupd.  I thought I forgot to compile the
> hp-bioscfg module, but actually it was compiled just not loading.
> 
> Once I loaded it, I found various problems with boundary handling and
> attributes on an HP Z2 Mini G1a.
> 
> [...]


Thank you for your contribution, it has been applied to my local
review-ilpo-fixes branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-fixes branch only once I've pushed my
local branch there, which might take a while.

The list of commits applied:
[1/3] platform/x86: hp-bioscfg: Fix kobject warnings for empty attribute names
      commit: fdee1b09721605f532352628d0a24623e7062efb
[2/3] platform/x86: hp-bioscfg: Fix kernel panic in GET_INSTANCE_ID macro
      commit: bb820f17b68f624547357e207ce9a8c7af3e7845
[3/3] platform/x86: hp-bioscfg: Fix automatic module loading
      commit: 791c3c82091eecd862f0d55a7c7a3302a518f599

--
 i.

Re: [PATCH v2 0/3] Fixes for hp-bioscfg

[Mario Limonciello]

On 1/28/26 12:51 PM, Alain Cousinie wrote:
> In-Reply-To: <20260115203725.828434-1-mario.limonciello@amd.com>
> 
> Hi,
> 
> (Excuse me, I'm not very familiar with the lore.kernel.org forum.)
> 
> The hp-bioscfg patch on 6.19-rc7 is causing my kernel to crash on my HP 
> Spectre 14-eu0xxx with Debian unstable.
> 
> See the dmesg output below.
> 
> I'm available for any help or questions...

Hi,

Can you have a try with this?

diff --git a/drivers/platform/x86/hp/hp-bioscfg/bioscfg.c 
b/drivers/platform/x86/hp/hp-bioscfg/bioscfg.c
index dbe096eefa758..51e8977d3eb4a 100644
--- a/drivers/platform/x86/hp/hp-bioscfg/bioscfg.c
+++ b/drivers/platform/x86/hp/hp-bioscfg/bioscfg.c
@@ -696,6 +696,11 @@ static int hp_init_bios_package_attribute(enum 
hp_wmi_data_type attr_type,
                 return ret;
         }

+       if (!str_value || !str_value[0]) {
+               pr_debug("Ignoring attribute with empty name\n");
+               goto pack_attr_exit;
+       }
+
         /* All duplicate attributes found are ignored */
         duplicate = kset_find_obj(temp_kset, str_value);
         if (duplicate) {
> 
> [    5.489782] ------------[ cut here ]------------
> [    5.489785] kobject: (00000000e74f4f8b): attempted to be registered 
> with empty name!
> [    5.489787] WARNING: lib/kobject.c:219 at 
> kobject_add_internal+0x420/0x470, CPU#5: (udev-worker)/568
> [    5.489792] Modules linked in: soundwire_generic_allocation 
> snd_sof_intel_hda_sdw_bpt snd_sof_intel_hda_common snd_soc_hdac_hda 
> snd_sof_intel_hda_mlink snd_sof_intel_hda snd_hda_codec_hdmi 
> soundwire_cadence snd_sof_pci snd_sof_xtensa_dsp snd_soc_sdw_utils 
> snd_sof intel_uncore_frequency intel_uncore_frequency_common 
> snd_sof_utils iwlmld(+) x86_pkg_temp_thermal snd_hda_ext_core 
> intel_powerclamp snd_hda_codec coretemp kvm_intel snd_hda_core 
> snd_hda_scodec_cs35l41_spi regmap_spi mac80211 hp_bioscfg(+) 
> intel_ipu6_isys snd_intel_dspcfg snd_intel_sdw_acpi 
> snd_soc_acpi_intel_match videobuf2_dma_sg libarc4 kvm videobuf2_memops 
> snd_soc_acpi_intel_sdca_quirks videobuf2_v4l2 snd_soc_acpi mei_gsc_proxy 
> snd_hwdep videobuf2_common crc8 soundwire_bus intel_rapl_msr 
> snd_soc_sdca btusb snd_soc_core btmtk btrtl firmware_attributes_class 
> snd_hda_scodec_cs35l41_i2c btbcm hid_sensor_gyro_3d snd_compress iwlwifi 
> hid_sensor_accel_3d hid_sensor_magn_3d hid_sensor_rotation irqbypass 
> snd_hda_scodec_cs35l41 btintel ghash_clmulni_intel ac97_bus
> [    5.489812]  spi_nor aesni_intel hid_sensor_trigger snd_pcm_dmaengine 
> processor_thermal_device_pci snd_soc_cs_amp_lib hid_sensor_iio_common 
> processor_thermal_device bluetooth snd_pcm mtd hp_wmi wmi_bmof pcspkr 
> gf128mul industrialio_triggered_buffer snd_soc_cs35l41_lib kfifo_buf 
> processor_thermal_wt_hint mei_me cs_dsp cfg80211 snd_timer 
> platform_temperature_control industrialio snd 
> processor_thermal_soc_slider mei soundcore platform_profile 
> processor_thermal_rfim processor_thermal_rapl intel_vpu 
> intel_rapl_common rfkill intel_ipu6 ov08x40 processor_thermal_wt_req 
> processor_thermal_power_floor v4l2_fwnode drm_shmem_helper igen6_edac 
> ipu_bridge processor_thermal_mbox intel_skl_int3472_tps68470 v4l2_async 
> tps68470_regulator serial_multi_instantiate clk_tps68470 videodev mc 
> joydev intel_pmc_core intel_skl_int3472_discrete int3403_thermal 
> pmt_telemetry int340x_thermal_zone pmt_discovery acpi_tad 
> intel_skl_int3472_common pmt_class button intel_hid 
> intel_pmc_ssram_telemetry soc_button_array acpi_pad sparse_keymap ac evdev
> [    5.489834]  parport_pc ppdev lp parport i2c_dev msr nvme_fabrics 
> efi_pstore nfnetlink efivarfs autofs4 uhci_hcd ehci_pci ehci_hcd xe 
> drm_ttm_helper drm_suballoc_helper gpu_sched drm_gpuvm drm_exec configfs 
> drm_gpusvm_helper usbhid hid_sensor_custom hid_sensor_hub i915 
> hid_multitouch i2c_algo_bit drm_buddy ttm drm_display_helper cec nvme 
> intel_ishtp_hid xhci_pci hid_generic rc_core ucsi_acpi i2c_hid_acpi 
> nvme_core xhci_hcd i2c_hid typec_ucsi drm_client_lib psmouse hid 
> drm_kms_helper typec iTCO_wdt intel_pmc_bxt iTCO_vendor_support 
> nvme_keyring watchdog nvme_auth roles drm usbcore video thunderbolt 
> serio_raw hkdf int3400_thermal intel_lpss_pci i2c_i801 intel_ish_ipc 
> intel_lpss wmi battery fan acpi_thermal_rel intel_ishtp i2c_smbus 
> intel_vsec idma64 usb_common
> [    5.489859] CPU: 5 UID: 0 PID: 568 Comm: (udev-worker) Not tainted 
> 6.19.0-rc7-meteor #39 PREEMPT(full)
> [    5.489861] Hardware name: HP HP Spectre x360 2-in-1 Laptop 14- 
> eu0xxx/8C15, BIOS F.16 12/16/2025
> [    5.489862] RIP: 0010:kobject_add_internal+0x423/0x470
> [    5.489864] Code: 63 20 e9 a4 fc ff ff 48 8d 3d 79 42 a1 00 49 8b 74 
> 24 18 48 89 ea 67 48 0f b9 3a e9 24 ff ff ff 48 8d 3d 70 42 a1 00 48 89 
> de <67> 48 0f b9 3a 41 bc ea ff ff ff e9 d1 fd ff ff be 01 00 00 00 e8
> [    5.489865] RSP: 0018:ffffd044424cfa98 EFLAGS: 00010246
> [    5.489866] RAX: ffff895f026956b0 RBX: ffff895f27c5b840 RCX: 
> ffff895f026956b0
> [    5.489867] RDX: 0000000000000000 RSI: ffff895f27c5b840 RDI: 
> ffffffffb38736a0
> [    5.489867] RBP: ffffd044424cfb38 R08: ffff895f026956b0 R09: 
> ffff895f026956b0
> [    5.489868] R10: 0000000000000000 R11: 00000000ffffffff R12: 
> ffff895f026956b0
> [    5.489869] R13: 0000000000000000 R14: 00000000fffffff4 R15: 
> ffff895f3b6e28a0
> [    5.489869] FS:  00007f7bda352c80(0000) GS:ffff8966ac092000(0000) 
> knlGS:0000000000000000
> [    5.489870] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> [    5.489871] CR2: 000055ac09f17000 CR3: 00000001684a3001 CR4: 
> 0000000000f72ef0
> [    5.489872] PKRU: 55555554
> [    5.489872] Call Trace:
> [    5.489874]  <TASK>
> [    5.489875]  kobject_init_and_add+0x136/0x160
> [    5.489878]  hp_init_bios_attributes+0x265/0x38c [hp_bioscfg]
> [    5.489883]  ? __pfx_hp_init+0x10/0x10 [hp_bioscfg]
> [    5.489886]  hp_init+0x183/0xff0 [hp_bioscfg]
> [    5.489888]  do_one_initcall+0x8d/0x330
> [    5.489892]  do_init_module+0x62/0x230
> [    5.489895]  init_module_from_file+0xd7/0x140
> [    5.489897]  idempotent_init_module+0x148/0x340
> [    5.489899]  __x64_sys_finit_module+0x71/0xe0
> [    5.489901]  ? syscall_trace_enter+0x91/0x1e0
> [    5.489902]  do_syscall_64+0x7c/0xd70
> [    5.489904]  ? __do_sys_newfstatat+0xe0/0x170
> [    5.489907]  ? do_syscall_64+0x7c/0xd70
> [    5.489908]  ? exc_page_fault+0x77/0x170
> [    5.489910]  entry_SYSCALL_64_after_hwframe+0x76/0x7e
> [    5.489912] RIP: 0033:0x7f7bd9d1bc69
> [    5.489914] Code: ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 
> 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 
> 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d 77 51 0d 00 f7 d8 64 89 01 48
> [    5.489914] RSP: 002b:00007ffe11a56348 EFLAGS: 00000246 ORIG_RAX: 
> 0000000000000139
> [    5.489915] RAX: ffffffffffffffda RBX: 000055ee99a48110 RCX: 
> 00007f7bd9d1bc69
> [    5.489916] RDX: 0000000000000004 RSI: 00007f7bda30e44d RDI: 
> 0000000000000067
> [    5.489917] RBP: 0000000000000004 R08: 0000000000000000 R09: 
> 000055ee99899e80
> [    5.489917] R10: 0000000000000000 R11: 0000000000000246 R12: 
> 0000000000020000
> [    5.489919] R13: 00007f7bda30e44d R14: 000055ee99a42060 R15: 
> 0000000000000000
> [    5.489920]  </TASK>
> [    5.489921] ---[ end trace 0000000000000000 ]---
> 

Re: [PATCH v2 0/3] Fixes for hp-bioscfg

[Mario Limonciello]

On 1/28/26 1:30 PM, Alain Cousinie wrote:
> Thank you so much!
> 
> I just recompiled with the patch and restarted, and the error is gone.
> 
> I took the liberty of sending this message because I saw that the update 
> is going to many versions, so there's a risk of a lot of feedback...
> 
> Thanks again!

Thanks a lot for the quick testing.  This was an existing BIOS issue 
that was exposed by it getting loaded on more systems.

I CC'ed you on the formal submission as well.  Would you please reply to 
that with a Tested-by tag? [1]

https://www.kernel.org/doc/html/latest/process/submitting-patches.html#using-reported-by-tested-by-reviewed-by-suggested-by-and-fixes 
[1]

Be sure to reply in plain text format, I think at least some of your 
emails have been HTML.

> 
> Le 28/01/2026 à 19:58, Mario Limonciello a écrit :
>> On 1/28/26 12:51 PM, Alain Cousinie wrote:
>>> In-Reply-To: <20260115203725.828434-1-mario.limonciello@amd.com>
>>>
>>> Hi,
>>>
>>> (Excuse me, I'm not very familiar with the lore.kernel.org forum.)
>>>
>>> The hp-bioscfg patch on 6.19-rc7 is causing my kernel to crash on my 
>>> HP Spectre 14-eu0xxx with Debian unstable.
>>>
>>> See the dmesg output below.
>>>
>>> I'm available for any help or questions...
>>
>> Hi,
>>
>> Can you have a try with this?
>>
>> diff --git a/drivers/platform/x86/hp/hp-bioscfg/bioscfg.c b/drivers/ 
>> platform/x86/hp/hp-bioscfg/bioscfg.c
>> index dbe096eefa758..51e8977d3eb4a 100644
>> --- a/drivers/platform/x86/hp/hp-bioscfg/bioscfg.c
>> +++ b/drivers/platform/x86/hp/hp-bioscfg/bioscfg.c
>> @@ -696,6 +696,11 @@ static int hp_init_bios_package_attribute(enum 
>> hp_wmi_data_type attr_type,
>>                 return ret;
>>         }
>>
>> +       if (!str_value || !str_value[0]) {
>> +               pr_debug("Ignoring attribute with empty name\n");
>> +               goto pack_attr_exit;
>> +       }
>> +
>>         /* All duplicate attributes found are ignored */
>>         duplicate = kset_find_obj(temp_kset, str_value);
>>         if (duplicate) {
>>>
>>> [    5.489782] ------------[ cut here ]------------
>>> [    5.489785] kobject: (00000000e74f4f8b): attempted to be 
>>> registered with empty name!
>>> [    5.489787] WARNING: lib/kobject.c:219 at 
>>> kobject_add_internal+0x420/0x470, CPU#5: (udev-worker)/568
>>> [    5.489792] Modules linked in: soundwire_generic_allocation 
>>> snd_sof_intel_hda_sdw_bpt snd_sof_intel_hda_common snd_soc_hdac_hda 
>>> snd_sof_intel_hda_mlink snd_sof_intel_hda snd_hda_codec_hdmi 
>>> soundwire_cadence snd_sof_pci snd_sof_xtensa_dsp snd_soc_sdw_utils 
>>> snd_sof intel_uncore_frequency intel_uncore_frequency_common 
>>> snd_sof_utils iwlmld(+) x86_pkg_temp_thermal snd_hda_ext_core 
>>> intel_powerclamp snd_hda_codec coretemp kvm_intel snd_hda_core 
>>> snd_hda_scodec_cs35l41_spi regmap_spi mac80211 hp_bioscfg(+) 
>>> intel_ipu6_isys snd_intel_dspcfg snd_intel_sdw_acpi 
>>> snd_soc_acpi_intel_match videobuf2_dma_sg libarc4 kvm 
>>> videobuf2_memops snd_soc_acpi_intel_sdca_quirks videobuf2_v4l2 
>>> snd_soc_acpi mei_gsc_proxy snd_hwdep videobuf2_common crc8 
>>> soundwire_bus intel_rapl_msr snd_soc_sdca btusb snd_soc_core btmtk 
>>> btrtl firmware_attributes_class snd_hda_scodec_cs35l41_i2c btbcm 
>>> hid_sensor_gyro_3d snd_compress iwlwifi hid_sensor_accel_3d 
>>> hid_sensor_magn_3d hid_sensor_rotation irqbypass 
>>> snd_hda_scodec_cs35l41 btintel ghash_clmulni_intel ac97_bus
>>> [    5.489812]  spi_nor aesni_intel hid_sensor_trigger 
>>> snd_pcm_dmaengine processor_thermal_device_pci snd_soc_cs_amp_lib 
>>> hid_sensor_iio_common processor_thermal_device bluetooth snd_pcm mtd 
>>> hp_wmi wmi_bmof pcspkr gf128mul industrialio_triggered_buffer 
>>> snd_soc_cs35l41_lib kfifo_buf processor_thermal_wt_hint mei_me cs_dsp 
>>> cfg80211 snd_timer platform_temperature_control industrialio snd 
>>> processor_thermal_soc_slider mei soundcore platform_profile 
>>> processor_thermal_rfim processor_thermal_rapl intel_vpu 
>>> intel_rapl_common rfkill intel_ipu6 ov08x40 processor_thermal_wt_req 
>>> processor_thermal_power_floor v4l2_fwnode drm_shmem_helper igen6_edac 
>>> ipu_bridge processor_thermal_mbox intel_skl_int3472_tps68470 
>>> v4l2_async tps68470_regulator serial_multi_instantiate clk_tps68470 
>>> videodev mc joydev intel_pmc_core intel_skl_int3472_discrete 
>>> int3403_thermal pmt_telemetry int340x_thermal_zone pmt_discovery 
>>> acpi_tad intel_skl_int3472_common pmt_class button intel_hid 
>>> intel_pmc_ssram_telemetry soc_button_array acpi_pad sparse_keymap ac 
>>> evdev
>>> [    5.489834]  parport_pc ppdev lp parport i2c_dev msr nvme_fabrics 
>>> efi_pstore nfnetlink efivarfs autofs4 uhci_hcd ehci_pci ehci_hcd xe 
>>> drm_ttm_helper drm_suballoc_helper gpu_sched drm_gpuvm drm_exec 
>>> configfs drm_gpusvm_helper usbhid hid_sensor_custom hid_sensor_hub 
>>> i915 hid_multitouch i2c_algo_bit drm_buddy ttm drm_display_helper cec 
>>> nvme intel_ishtp_hid xhci_pci hid_generic rc_core ucsi_acpi 
>>> i2c_hid_acpi nvme_core xhci_hcd i2c_hid typec_ucsi drm_client_lib 
>>> psmouse hid drm_kms_helper typec iTCO_wdt intel_pmc_bxt 
>>> iTCO_vendor_support nvme_keyring watchdog nvme_auth roles drm usbcore 
>>> video thunderbolt serio_raw hkdf int3400_thermal intel_lpss_pci 
>>> i2c_i801 intel_ish_ipc intel_lpss wmi battery fan acpi_thermal_rel 
>>> intel_ishtp i2c_smbus intel_vsec idma64 usb_common
>>> [    5.489859] CPU: 5 UID: 0 PID: 568 Comm: (udev-worker) Not tainted 
>>> 6.19.0-rc7-meteor #39 PREEMPT(full)
>>> [    5.489861] Hardware name: HP HP Spectre x360 2-in-1 Laptop 14- 
>>> eu0xxx/8C15, BIOS F.16 12/16/2025
>>> [    5.489862] RIP: 0010:kobject_add_internal+0x423/0x470
>>> [    5.489864] Code: 63 20 e9 a4 fc ff ff 48 8d 3d 79 42 a1 00 49 8b 
>>> 74 24 18 48 89 ea 67 48 0f b9 3a e9 24 ff ff ff 48 8d 3d 70 42 a1 00 
>>> 48 89 de <67> 48 0f b9 3a 41 bc ea ff ff ff e9 d1 fd ff ff be 01 00 
>>> 00 00 e8
>>> [    5.489865] RSP: 0018:ffffd044424cfa98 EFLAGS: 00010246
>>> [    5.489866] RAX: ffff895f026956b0 RBX: ffff895f27c5b840 RCX: 
>>> ffff895f026956b0
>>> [    5.489867] RDX: 0000000000000000 RSI: ffff895f27c5b840 RDI: 
>>> ffffffffb38736a0
>>> [    5.489867] RBP: ffffd044424cfb38 R08: ffff895f026956b0 R09: 
>>> ffff895f026956b0
>>> [    5.489868] R10: 0000000000000000 R11: 00000000ffffffff R12: 
>>> ffff895f026956b0
>>> [    5.489869] R13: 0000000000000000 R14: 00000000fffffff4 R15: 
>>> ffff895f3b6e28a0
>>> [    5.489869] FS:  00007f7bda352c80(0000) GS:ffff8966ac092000(0000) 
>>> knlGS:0000000000000000
>>> [    5.489870] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
>>> [    5.489871] CR2: 000055ac09f17000 CR3: 00000001684a3001 CR4: 
>>> 0000000000f72ef0
>>> [    5.489872] PKRU: 55555554
>>> [    5.489872] Call Trace:
>>> [    5.489874]  <TASK>
>>> [    5.489875]  kobject_init_and_add+0x136/0x160
>>> [    5.489878]  hp_init_bios_attributes+0x265/0x38c [hp_bioscfg]
>>> [    5.489883]  ? __pfx_hp_init+0x10/0x10 [hp_bioscfg]
>>> [    5.489886]  hp_init+0x183/0xff0 [hp_bioscfg]
>>> [    5.489888]  do_one_initcall+0x8d/0x330
>>> [    5.489892]  do_init_module+0x62/0x230
>>> [    5.489895]  init_module_from_file+0xd7/0x140
>>> [    5.489897]  idempotent_init_module+0x148/0x340
>>> [    5.489899]  __x64_sys_finit_module+0x71/0xe0
>>> [    5.489901]  ? syscall_trace_enter+0x91/0x1e0
>>> [    5.489902]  do_syscall_64+0x7c/0xd70
>>> [    5.489904]  ? __do_sys_newfstatat+0xe0/0x170
>>> [    5.489907]  ? do_syscall_64+0x7c/0xd70
>>> [    5.489908]  ? exc_page_fault+0x77/0x170
>>> [    5.489910]  entry_SYSCALL_64_after_hwframe+0x76/0x7e
>>> [    5.489912] RIP: 0033:0x7f7bd9d1bc69
>>> [    5.489914] Code: ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 
>>> 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 
>>> 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d 77 51 0d 00 f7 d8 64 
>>> 89 01 48
>>> [    5.489914] RSP: 002b:00007ffe11a56348 EFLAGS: 00000246 ORIG_RAX: 
>>> 0000000000000139
>>> [    5.489915] RAX: ffffffffffffffda RBX: 000055ee99a48110 RCX: 
>>> 00007f7bd9d1bc69
>>> [    5.489916] RDX: 0000000000000004 RSI: 00007f7bda30e44d RDI: 
>>> 0000000000000067
>>> [    5.489917] RBP: 0000000000000004 R08: 0000000000000000 R09: 
>>> 000055ee99899e80
>>> [    5.489917] R10: 0000000000000000 R11: 0000000000000246 R12: 
>>> 0000000000020000
>>> [    5.489919] R13: 00007f7bda30e44d R14: 000055ee99a42060 R15: 
>>> 0000000000000000
>>> [    5.489920]  </TASK>
>>> [    5.489921] ---[ end trace 0000000000000000 ]---
>>>
>>