* [PATCH] wmi: Fix spelling
@ 2024-07-29 16:47 Luis Felipe Hernandez
2024-07-29 17:00 ` Ilpo Järvinen
2024-07-29 18:40 ` Randy Dunlap
0 siblings, 2 replies; 3+ messages in thread
From: Luis Felipe Hernandez @ 2024-07-29 16:47 UTC (permalink / raw)
To: W_Armin, corbet
Cc: Luis Felipe Hernandez, platform-driver-x86, linux-doc,
linux-kernel, linux-kernel-mentees
Signed-off-by: Luis Felipe Hernandez <luis.hernandez093@gmail.com>
---
Documentation/wmi/devices/msi-wmi-platform.rst | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/Documentation/wmi/devices/msi-wmi-platform.rst b/Documentation/wmi/devices/msi-wmi-platform.rst
index 29b1b2e6d42c..31a136942892 100644
--- a/Documentation/wmi/devices/msi-wmi-platform.rst
+++ b/Documentation/wmi/devices/msi-wmi-platform.rst
@@ -130,12 +130,12 @@ data using the `bmfdec <https://github.com/pali/bmfdec>`_ utility:
Due to a peculiarity in how Windows handles the ``CreateByteField()`` ACPI operator (errors only
happen when a invalid byte field is ultimately accessed), all methods require a 32 byte input
-buffer, even if the Binay MOF says otherwise.
+buffer, even if the Binary MOF says otherwise.
The input buffer contains a single byte to select the subfeature to be accessed and 31 bytes of
input data, the meaning of which depends on the subfeature being accessed.
-The output buffer contains a singe byte which signals success or failure (``0x00`` on failure)
+The output buffer contains a single byte which signals success or failure (``0x00`` on failure)
and 31 bytes of output data, the meaning if which depends on the subfeature being accessed.
WMI method Get_EC()
@@ -147,7 +147,7 @@ data contains a flag byte and a 28 byte controller firmware version string.
The first 4 bits of the flag byte contain the minor version of the embedded controller interface,
with the next 2 bits containing the major version of the embedded controller interface.
-The 7th bit signals if the embedded controller page chaged (exact meaning is unknown), and the
+The 7th bit signals if the embedded controller page changed (exact meaning is unknown), and the
last bit signals if the platform is a Tigerlake platform.
The MSI software seems to only use this interface when the last bit is set.
--
2.45.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] wmi: Fix spelling
2024-07-29 16:47 [PATCH] wmi: Fix spelling Luis Felipe Hernandez
@ 2024-07-29 17:00 ` Ilpo Järvinen
2024-07-29 18:40 ` Randy Dunlap
1 sibling, 0 replies; 3+ messages in thread
From: Ilpo Järvinen @ 2024-07-29 17:00 UTC (permalink / raw)
To: Luis Felipe Hernandez
Cc: W_Armin, corbet, platform-driver-x86, linux-doc, LKML,
linux-kernel-mentees
On Mon, 29 Jul 2024, Luis Felipe Hernandez wrote:
Thanks for this change but please don't leave the commit message empty,
it's not enough to provide just the shortlog (in subject) even if the
change is obvious/simple. Please resubmit this with the commit message
included.
--
i.
> Signed-off-by: Luis Felipe Hernandez <luis.hernandez093@gmail.com>
> ---
> Documentation/wmi/devices/msi-wmi-platform.rst | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/wmi/devices/msi-wmi-platform.rst b/Documentation/wmi/devices/msi-wmi-platform.rst
> index 29b1b2e6d42c..31a136942892 100644
> --- a/Documentation/wmi/devices/msi-wmi-platform.rst
> +++ b/Documentation/wmi/devices/msi-wmi-platform.rst
> @@ -130,12 +130,12 @@ data using the `bmfdec <https://github.com/pali/bmfdec>`_ utility:
>
> Due to a peculiarity in how Windows handles the ``CreateByteField()`` ACPI operator (errors only
> happen when a invalid byte field is ultimately accessed), all methods require a 32 byte input
> -buffer, even if the Binay MOF says otherwise.
> +buffer, even if the Binary MOF says otherwise.
>
> The input buffer contains a single byte to select the subfeature to be accessed and 31 bytes of
> input data, the meaning of which depends on the subfeature being accessed.
>
> -The output buffer contains a singe byte which signals success or failure (``0x00`` on failure)
> +The output buffer contains a single byte which signals success or failure (``0x00`` on failure)
> and 31 bytes of output data, the meaning if which depends on the subfeature being accessed.
>
> WMI method Get_EC()
> @@ -147,7 +147,7 @@ data contains a flag byte and a 28 byte controller firmware version string.
> The first 4 bits of the flag byte contain the minor version of the embedded controller interface,
> with the next 2 bits containing the major version of the embedded controller interface.
>
> -The 7th bit signals if the embedded controller page chaged (exact meaning is unknown), and the
> +The 7th bit signals if the embedded controller page changed (exact meaning is unknown), and the
> last bit signals if the platform is a Tigerlake platform.
>
> The MSI software seems to only use this interface when the last bit is set.
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] wmi: Fix spelling
2024-07-29 16:47 [PATCH] wmi: Fix spelling Luis Felipe Hernandez
2024-07-29 17:00 ` Ilpo Järvinen
@ 2024-07-29 18:40 ` Randy Dunlap
1 sibling, 0 replies; 3+ messages in thread
From: Randy Dunlap @ 2024-07-29 18:40 UTC (permalink / raw)
To: Luis Felipe Hernandez, W_Armin, corbet
Cc: platform-driver-x86, linux-doc, linux-kernel,
linux-kernel-mentees
On 7/29/24 9:47 AM, Luis Felipe Hernandez wrote:
> Signed-off-by: Luis Felipe Hernandez <luis.hernandez093@gmail.com>
> ---
> Documentation/wmi/devices/msi-wmi-platform.rst | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/wmi/devices/msi-wmi-platform.rst b/Documentation/wmi/devices/msi-wmi-platform.rst
> index 29b1b2e6d42c..31a136942892 100644
> --- a/Documentation/wmi/devices/msi-wmi-platform.rst
> +++ b/Documentation/wmi/devices/msi-wmi-platform.rst
> @@ -130,12 +130,12 @@ data using the `bmfdec <https://github.com/pali/bmfdec>`_ utility:
>
> Due to a peculiarity in how Windows handles the ``CreateByteField()`` ACPI operator (errors only
> happen when a invalid byte field is ultimately accessed), all methods require a 32 byte input
> -buffer, even if the Binay MOF says otherwise.
> +buffer, even if the Binary MOF says otherwise.
>
> The input buffer contains a single byte to select the subfeature to be accessed and 31 bytes of
> input data, the meaning of which depends on the subfeature being accessed.
>
> -The output buffer contains a singe byte which signals success or failure (``0x00`` on failure)
> +The output buffer contains a single byte which signals success or failure (``0x00`` on failure)
> and 31 bytes of output data, the meaning if which depends on the subfeature being accessed.
>
> WMI method Get_EC()
> @@ -147,7 +147,7 @@ data contains a flag byte and a 28 byte controller firmware version string.
> The first 4 bits of the flag byte contain the minor version of the embedded controller interface,
> with the next 2 bits containing the major version of the embedded controller interface.
>
> -The 7th bit signals if the embedded controller page chaged (exact meaning is unknown), and the
> +The 7th bit signals if the embedded controller page changed (exact meaning is unknown), and the
> last bit signals if the platform is a Tigerlake platform.
>
> The MSI software seems to only use this interface when the last bit is set.
Acked-by: Randy Dunlap <rdunlap@infradead.org>
after you add a commit message.
--
~Randy
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-07-29 18:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-29 16:47 [PATCH] wmi: Fix spelling Luis Felipe Hernandez
2024-07-29 17:00 ` Ilpo Järvinen
2024-07-29 18:40 ` Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox