Poky Project Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Khem Raj <raj.khem@gmail.com>
Cc: paul.eggleton@linux.intel.com, poky@pokylinux.org
Subject: Re: [PATCH 2/3] kernel.bbclass: introduce UIMAGE_BASE_NAME
Date: Mon, 20 Dec 2010 21:15:52 +0000	[thread overview]
Message-ID: <1292879752.25087.5050.camel@rex> (raw)
In-Reply-To: <20101220032118.GD26429@gmail.com>

On Sun, 2010-12-19 at 19:21 -0800, Khem Raj wrote:
> On (17/12/10 08:51), Kevin Tian wrote:
> >  addtask sizecheck before do_install after do_compile
> >  
> >  KERNEL_IMAGE_BASE_NAME ?= "${KERNEL_IMAGETYPE}-${PV}-${PR}-${MACHINE}-${DATETIME}"
> > +UIMAGE_BASE_NAME ?= "uImage-${PV}-${PR}-${MACHINE}-${DATETIME}"
> >  # Don't include the DATETIME variable in the sstate package signatures
> >  KERNEL_IMAGE_BASE_NAME[vardepsexclude] = "DATETIME"
> >  KERNEL_IMAGE_SYMLINK_NAME ?= "${KERNEL_IMAGETYPE}-${MACHINE}"
> > @@ -484,16 +485,16 @@ kernel_do_deploy() {
> >  
> >  	if test "x${KERNEL_IMAGETYPE}" = "xuImage" ; then 
> >  		if test -e arch/${ARCH}/boot/uImage ; then
> > -			cp arch/${ARCH}/boot/uImage ${DEPLOYDIR}/uImage-${PV}-${PR}-${MACHINE}-${DATETIME}.bin
> > +			cp arch/${ARCH}/boot/uImage ${DEPLOYDIR}/${UIMAGE_BASE_NAME}.bin
> 
> why using KERNEL_IMAGE_BASE_NAME does not work here ?

Agreed, this doesn't make sense. I've pushed:

http://git.pokylinux.org/cgit.cgi/poky/commit/?id=2e94e9a4fed33b1c7c5b0ce1dbc566e24344280c

since its clear that KERNEL_IMAGETYPE = "uImage".

Cheers,

Richard



  reply	other threads:[~2010-12-20 21:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-17  0:51 [PATCH 2/3] kernel.bbclass: introduce UIMAGE_BASE_NAME Kevin Tian
2010-12-20  3:21 ` Khem Raj
2010-12-20 21:15   ` Richard Purdie [this message]
2010-12-21  0:35     ` Tian, Kevin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1292879752.25087.5050.camel@rex \
    --to=richard.purdie@linuxfoundation.org \
    --cc=paul.eggleton@linux.intel.com \
    --cc=poky@pokylinux.org \
    --cc=raj.khem@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox