From: Khem Raj <raj.khem@gmail.com>
To: Kevin Tian <kevin.tian@intel.com>
Cc: paul.eggleton@linux.intel.com, poky@pokylinux.org
Subject: Re: [PATCH 2/3] kernel.bbclass: introduce UIMAGE_BASE_NAME
Date: Sun, 19 Dec 2010 19:21:18 -0800 [thread overview]
Message-ID: <20101220032118.GD26429@gmail.com> (raw)
In-Reply-To: <b9dded$hdep5f@orsmga002.jf.intel.com>
On (17/12/10 08:51), Kevin Tian wrote:
> Signed-off-by: Kevin Tian <kevin.tian@intel.com>
> ---
> meta/classes/kernel.bbclass | 7 ++++---
> 1 files changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
> index b2f8132..4f7ceba 100644
> --- a/meta/classes/kernel.bbclass
> +++ b/meta/classes/kernel.bbclass
> @@ -472,6 +472,7 @@ do_sizecheck() {
> addtask sizecheck before do_install after do_compile
>
> KERNEL_IMAGE_BASE_NAME ?= "${KERNEL_IMAGETYPE}-${PV}-${PR}-${MACHINE}-${DATETIME}"
> +UIMAGE_BASE_NAME ?= "uImage-${PV}-${PR}-${MACHINE}-${DATETIME}"
> # Don't include the DATETIME variable in the sstate package signatures
> KERNEL_IMAGE_BASE_NAME[vardepsexclude] = "DATETIME"
> KERNEL_IMAGE_SYMLINK_NAME ?= "${KERNEL_IMAGETYPE}-${MACHINE}"
> @@ -484,16 +485,16 @@ kernel_do_deploy() {
>
> if test "x${KERNEL_IMAGETYPE}" = "xuImage" ; then
> if test -e arch/${ARCH}/boot/uImage ; then
> - cp arch/${ARCH}/boot/uImage ${DEPLOYDIR}/uImage-${PV}-${PR}-${MACHINE}-${DATETIME}.bin
> + cp arch/${ARCH}/boot/uImage ${DEPLOYDIR}/${UIMAGE_BASE_NAME}.bin
why using KERNEL_IMAGE_BASE_NAME does not work here ?
> elif test -e arch/${ARCH}/boot/compressed/vmlinux ; then
> ${OBJCOPY} -O binary -R .note -R .comment -S arch/${ARCH}/boot/compressed/vmlinux linux.bin
> - uboot-mkimage -A ${ARCH} -O linux -T kernel -C none -a ${UBOOT_ENTRYPOINT} -e ${UBOOT_ENTRYPOINT} -n "${DISTRO_NAME}/${PV}/${MACHINE}" -d linux.bin ${DEPLOYDIR}/uImage-${PV}-${PR}-${MACHINE}-${DATETIME}.bin
> + uboot-mkimage -A ${ARCH} -O linux -T kernel -C none -a ${UBOOT_ENTRYPOINT} -e ${UBOOT_ENTRYPOINT} -n "${DISTRO_NAME}/${PV}/${MACHINE}" -d linux.bin ${DEPLOYDIR}/${UIMAGE_BASE_NAME}.bin
> rm -f linux.bin
> else
> ${OBJCOPY} -O binary -R .note -R .comment -S vmlinux linux.bin
> rm -f linux.bin.gz
> gzip -9 linux.bin
> - uboot-mkimage -A ${ARCH} -O linux -T kernel -C gzip -a ${UBOOT_ENTRYPOINT} -e ${UBOOT_ENTRYPOINT} -n "${DISTRO_NAME}/${PV}/${MACHINE}" -d linux.bin.gz ${DEPLOYDIR}/uImage-${PV}-${PR}-${MACHINE}-${DATETIME}.bin
> + uboot-mkimage -A ${ARCH} -O linux -T kernel -C gzip -a ${UBOOT_ENTRYPOINT} -e ${UBOOT_ENTRYPOINT} -n "${DISTRO_NAME}/${PV}/${MACHINE}" -d linux.bin.gz ${DEPLOYDIR}/${UIMAGE_BASE_NAME}.bin
> rm -f linux.bin.gz
> fi
> fi
> --
> 1.6.0.4
>
> _______________________________________________
> poky mailing list
> poky@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/poky
next prev parent reply other threads:[~2010-12-20 3:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-17 0:51 [PATCH 2/3] kernel.bbclass: introduce UIMAGE_BASE_NAME Kevin Tian
2010-12-20 3:21 ` Khem Raj [this message]
2010-12-20 21:15 ` Richard Purdie
2010-12-21 0:35 ` Tian, Kevin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101220032118.GD26429@gmail.com \
--to=raj.khem@gmail.com \
--cc=kevin.tian@intel.com \
--cc=paul.eggleton@linux.intel.com \
--cc=poky@pokylinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox