Poky Project Discussions
 help / color / mirror / Atom feed
* Re: [PULL] at: Non root install patch is not necessary (Bug 246)
       [not found]     ` <1287566700.16386.33.camel@rex>
@ 2010-10-21  5:17       ` Mei, Lei
  2010-10-21 12:51         ` Richard Purdie
  0 siblings, 1 reply; 4+ messages in thread
From: Mei, Lei @ 2010-10-21  5:17 UTC (permalink / raw)
  To: Richard Purdie; +Cc: poky@pokylinux.org

Hi Richard,
    I have added the description to the nonstripbinaries.patch, please check it, thank you~

 meta/recipes-extended/at/at_3.1.12.bb                 |    2 
 meta/recipes-extended/at/files/nonrootinstall.patch   |   75 ------------------
 meta/recipes-extended/at/files/nonstripbinaries.patch |   25 ++++++
 3 files changed, 26 insertions(+), 76 deletions(-)

Mei Lei (1):
      at: remove nonrootinstall patch and modify some relevant files

Pull URL: http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=lmei3/distro

commit 3c695d5d210227c5744fa90736feb7c308c6bf15
Author: Mei Lei <lei.mei@intel.com>
Date:   Thu Oct 21 12:36:51 2010 +0800

    at: remove nonrootinstall patch and modify some relevant files
    
    remove nonrootinstall patch, and use a patch named nonstripbinaries to modify the /at-3.1.10.2/Makefile.in, so it can also handles stripping of the binaries
    
    Fix [BUG 246]
    
    Signed-off-by: Mei Lei <lei.mei@intel.com>

Thanks
Lei

-----Original Message-----
From: Richard Purdie [mailto:rpurdie@linux.intel.com] 
Sent: Wednesday, October 20, 2010 5:25 PM
To: Mei, Lei
Subject: RE: [PULL] at: Non root install patch is not necessary (Bug 246)

On Wed, 2010-10-20 at 17:05 +0800, Mei, Lei wrote:
> Hi Richard,
>    I have re-fixed this bug, please check it, thank you~
> 
>  meta/recipes-extended/at/at_3.1.12.bb                 |    2 
>  meta/recipes-extended/at/files/nonrootinstall.patch   |   75 ------------------
>  meta/recipes-extended/at/files/nonstripbinaries.patch |   21 +++++
>  3 files changed, 22 insertions(+), 76 deletions(-)
> 
> Mei Lei (1):
>       at: remove nonrootinstall patch and modify relevant files

Thanks, much better. One more small thing though - could you add a
header to the patch with a description of what it does, why and who made
the change. In this case its fairly obvious but its a good idea in
general as when you come back to a patch six months later you can
remember why its there!

Also, poky pull requests like this should be going to the Poky mailing
list.

Cheers,

Richard




^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PULL] at: Non root install patch is not necessary (Bug 246)
  2010-10-21  5:17       ` [PULL] at: Non root install patch is not necessary (Bug 246) Mei, Lei
@ 2010-10-21 12:51         ` Richard Purdie
  2010-10-21 17:27           ` [PULL] Fix at -- was Re: [PULL] at: Non root install patch is not necessary (Bug246) Mark Hatle
  0 siblings, 1 reply; 4+ messages in thread
From: Richard Purdie @ 2010-10-21 12:51 UTC (permalink / raw)
  To: Mei, Lei; +Cc: poky@pokylinux.org

On Thu, 2010-10-21 at 13:17 +0800, Mei, Lei wrote:
> Hi Richard,
>     I have added the description to the nonstripbinaries.patch, please check it, thank you~
> 
>  meta/recipes-extended/at/at_3.1.12.bb                 |    2 
>  meta/recipes-extended/at/files/nonrootinstall.patch   |   75 ------------------
>  meta/recipes-extended/at/files/nonstripbinaries.patch |   25 ++++++
>  3 files changed, 26 insertions(+), 76 deletions(-)
> 
> Mei Lei (1):
>       at: remove nonrootinstall patch and modify some relevant files
> 
> Pull URL: http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=lmei3/distro

Merged to master, thanks.

As a note for future, no # to comment lines is needed in a patch header.

Cheers,

Richard



^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PULL] Fix at -- was Re: [PULL] at: Non root install patch is not necessary (Bug246)
  2010-10-21 12:51         ` Richard Purdie
@ 2010-10-21 17:27           ` Mark Hatle
  2010-10-22  9:26             ` Richard Purdie
  0 siblings, 1 reply; 4+ messages in thread
From: Mark Hatle @ 2010-10-21 17:27 UTC (permalink / raw)
  To: poky

This commit introduced a bug, the following fixes the issue:

Pull request follows....

The following changes since commit f1a209b142d2319d2594b051c01d9997184bfcb4:

   busybox/sysklogd: syslog.conf files (2010-10-21 14:05:57 +0100)

are available in the git repository at:
   git://git.pokylinux.org/poky-contrib.git mhatle/at

Mark Hatle (1):
       at: Fix nonstripbinaries.patch

  .../at/files/nonstripbinaries.patch                |    6 +++---
  1 files changed, 3 insertions(+), 3 deletions(-)


On 10/21/10 7:51 AM, Richard Purdie wrote:
> On Thu, 2010-10-21 at 13:17 +0800, Mei, Lei wrote:
>> Hi Richard,
>>      I have added the description to the nonstripbinaries.patch, please check it, thank you~
>>
>>   meta/recipes-extended/at/at_3.1.12.bb                 |    2
>>   meta/recipes-extended/at/files/nonrootinstall.patch   |   75 ------------------
>>   meta/recipes-extended/at/files/nonstripbinaries.patch |   25 ++++++
>>   3 files changed, 26 insertions(+), 76 deletions(-)
>>
>> Mei Lei (1):
>>        at: remove nonrootinstall patch and modify some relevant files
>>
>> Pull URL: http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=lmei3/distro
>
> Merged to master, thanks.
>
> As a note for future, no # to comment lines is needed in a patch header.
>
> Cheers,
>
> Richard
>
> _______________________________________________
> poky mailing list
> poky@pokylinux.org
> https://lists.pokylinux.org/listinfo/poky



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PULL] Fix at -- was Re: [PULL] at: Non root install patch is not necessary (Bug246)
  2010-10-21 17:27           ` [PULL] Fix at -- was Re: [PULL] at: Non root install patch is not necessary (Bug246) Mark Hatle
@ 2010-10-22  9:26             ` Richard Purdie
  0 siblings, 0 replies; 4+ messages in thread
From: Richard Purdie @ 2010-10-22  9:26 UTC (permalink / raw)
  To: Mark Hatle; +Cc: poky

On Thu, 2010-10-21 at 12:27 -0500, Mark Hatle wrote:
> This commit introduced a bug, the following fixes the issue:
> 
> Pull request follows....
> 
> The following changes since commit f1a209b142d2319d2594b051c01d9997184bfcb4:
> 
>    busybox/sysklogd: syslog.conf files (2010-10-21 14:05:57 +0100)
> 
> are available in the git repository at:
>    git://git.pokylinux.org/poky-contrib.git mhatle/at
> 
> Mark Hatle (1):
>        at: Fix nonstripbinaries.patch
> 
>   .../at/files/nonstripbinaries.patch                |    6 +++---
>   1 files changed, 3 insertions(+), 3 deletions(-)

Merged into master, thanks.

Richard



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2010-10-22  9:26 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <749B9D3DBF0F054390025D9EAFF47F222FE8FA5E@shsmsx501.ccr.corp.intel.com>
     [not found] ` <1287489755.1720.1284.camel@rex>
     [not found]   ` <749B9D3DBF0F054390025D9EAFF47F222FE8FF87@shsmsx501.ccr.corp.intel.com>
     [not found]     ` <1287566700.16386.33.camel@rex>
2010-10-21  5:17       ` [PULL] at: Non root install patch is not necessary (Bug 246) Mei, Lei
2010-10-21 12:51         ` Richard Purdie
2010-10-21 17:27           ` [PULL] Fix at -- was Re: [PULL] at: Non root install patch is not necessary (Bug246) Mark Hatle
2010-10-22  9:26             ` Richard Purdie

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox