Poky Project Discussions
 help / color / mirror / Atom feed
* [PULL] two sstate fixes
@ 2010-11-05  7:53 Tian, Kevin
  2010-11-07 20:41 ` Richard Purdie
  0 siblings, 1 reply; 4+ messages in thread
From: Tian, Kevin @ 2010-11-05  7:53 UTC (permalink / raw)
  To: poky@pokylinux.org

 meta/classes/package.bbclass |    1 +
 meta/conf/distro/poky.conf   |    2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

commit bb9d4efa4076cfcf0998ecafb6d6b0969b97d224
Author: Kevin Tian <kevin.tian@intel.com>
Date:   Fri Nov 5 15:16:50 2010 +0800

    poky.conf: add PWD to BB_HASHBASE_WHITELIST

    Without doing this I can't reuse prebuilts generated from one directory in another
    build directory which is really not comfortable for developers. Due to difference
    on PWD variable, base hash becomes different for every sstate package.

    So here PWD is added to the hase base whitelist, which makes most prebuilts reusable
    now in a different build directory. However there still remains one issue about
    do_populate_sysroot sstate package. Absolute path is encoded in this task which
    then blocks reuse on them. Perhaps we need some redesign for do_populate_sysroot into
    two stages, with all absolute path related operations moved to the 2nd stage. This
    way then the 1st stage can be reused.

    Partially fix [BUGID #522]

    Signed-off-by Kevin Tian <kevin.tian@intel.com>

commit 599ccdfa9d53e43fb2e44fdfd57de5d91868428b
Author: Kevin Tian <kevin.tian@intel.com>
Date:   Tue Oct 26 15:54:43 2010 +0800

    package.bbclass: make sure 'sysroots' created before lockfile

    package sstate requires a lock under sysroots/, which however may not be
    created when sstate_setscene functions are executed and then causes failures.
    here we make sure 'sysroots' created before do_package_setscene is executed.

    Signed-off-by: Kevin Tian <kevin.tian@intel.com>
Pull URL: http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=tk/master

Thanks
Kevin


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PULL] two sstate fixes
  2010-11-05  7:53 [PULL] two sstate fixes Tian, Kevin
@ 2010-11-07 20:41 ` Richard Purdie
  2010-11-08  0:49   ` Tian, Kevin
  0 siblings, 1 reply; 4+ messages in thread
From: Richard Purdie @ 2010-11-07 20:41 UTC (permalink / raw)
  To: Tian, Kevin; +Cc: poky

On Fri, 2010-11-05 at 15:53 +0800, Tian, Kevin wrote:
> meta/classes/package.bbclass |    1 +
>  meta/conf/distro/poky.conf   |    2 +-
>  2 files changed, 2 insertions(+), 1 deletion(-)
> 
> commit bb9d4efa4076cfcf0998ecafb6d6b0969b97d224
> Author: Kevin Tian <kevin.tian@intel.com>
> Date:   Fri Nov 5 15:16:50 2010 +0800
> 
>     poky.conf: add PWD to BB_HASHBASE_WHITELIST
> 
>     Without doing this I can't reuse prebuilts generated from one directory in another
>     build directory which is really not comfortable for developers. Due to difference
>     on PWD variable, base hash becomes different for every sstate package.
> 
>     So here PWD is added to the hase base whitelist, which makes most prebuilts reusable
>     now in a different build directory. However there still remains one issue about
>     do_populate_sysroot sstate package. Absolute path is encoded in this task which
>     then blocks reuse on them. Perhaps we need some redesign for do_populate_sysroot into
>     two stages, with all absolute path related operations moved to the 2nd stage. This
>     way then the 1st stage can be reused.

>     Partially fix [BUGID #522]
> 
>     Signed-off-by Kevin Tian <kevin.tian@intel.com>
> 
> commit 599ccdfa9d53e43fb2e44fdfd57de5d91868428b
> Author: Kevin Tian <kevin.tian@intel.com>
> Date:   Tue Oct 26 15:54:43 2010 +0800
> 
>     package.bbclass: make sure 'sysroots' created before lockfile
> 
>     package sstate requires a lock under sysroots/, which however may not be
>     created when sstate_setscene functions are executed and then causes failures.
>     here we make sure 'sysroots' created before do_package_setscene is executed.
> 
>     Signed-off-by: Kevin Tian <kevin.tian@intel.com>
> Pull URL: http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=tk/master

Good catches, I've merged these, thanks!

You're right btw, we shouldn't be using hardcoded paths and we should
fix that. Can you confirm you were using staging packages from a recent
poky build though (0.9 release at least) as there were some bugs fixed
in that area coming up to release.

Cheers,

Richard



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PULL] two sstate fixes
  2010-11-07 20:41 ` Richard Purdie
@ 2010-11-08  0:49   ` Tian, Kevin
  2010-11-08 21:31     ` Gary Thomas
  0 siblings, 1 reply; 4+ messages in thread
From: Tian, Kevin @ 2010-11-08  0:49 UTC (permalink / raw)
  To: Richard Purdie; +Cc: poky@yoctoproject.org

>From: Richard Purdie [mailto:rpurdie@linux.intel.com]
>Sent: Monday, November 08, 2010 4:42 AM
>
>On Fri, 2010-11-05 at 15:53 +0800, Tian, Kevin wrote:
>> meta/classes/package.bbclass |    1 +
>>  meta/conf/distro/poky.conf   |    2 +-
>>  2 files changed, 2 insertions(+), 1 deletion(-)
>>
>> commit bb9d4efa4076cfcf0998ecafb6d6b0969b97d224
>> Author: Kevin Tian <kevin.tian@intel.com>
>> Date:   Fri Nov 5 15:16:50 2010 +0800
>>
>>     poky.conf: add PWD to BB_HASHBASE_WHITELIST
>>
>>     Without doing this I can't reuse prebuilts generated from one directory in another
>>     build directory which is really not comfortable for developers. Due to difference
>>     on PWD variable, base hash becomes different for every sstate package.
>>
>>     So here PWD is added to the hase base whitelist, which makes most prebuilts reusable
>>     now in a different build directory. However there still remains one issue about
>>     do_populate_sysroot sstate package. Absolute path is encoded in this task which
>>     then blocks reuse on them. Perhaps we need some redesign for do_populate_sysroot
>into
>>     two stages, with all absolute path related operations moved to the 2nd stage. This
>>     way then the 1st stage can be reused.
>
>>     Partially fix [BUGID #522]
>>
>>     Signed-off-by Kevin Tian <kevin.tian@intel.com>
>>
>> commit 599ccdfa9d53e43fb2e44fdfd57de5d91868428b
>> Author: Kevin Tian <kevin.tian@intel.com>
>> Date:   Tue Oct 26 15:54:43 2010 +0800
>>
>>     package.bbclass: make sure 'sysroots' created before lockfile
>>
>>     package sstate requires a lock under sysroots/, which however may not be
>>     created when sstate_setscene functions are executed and then causes failures.
>>     here we make sure 'sysroots' created before do_package_setscene is executed.
>>
>>     Signed-off-by: Kevin Tian <kevin.tian@intel.com>
>> Pull URL: http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=tk/master
>
>Good catches, I've merged these, thanks!
>
>You're right btw, we shouldn't be using hardcoded paths and we should
>fix that. Can you confirm you were using staging packages from a recent
>poky build though (0.9 release at least) as there were some bugs fixed
>in that area coming up to release.
>

I forgot the exact commit after the rebase before sending pull request, but I know
it's around the 0.9 release. So I'll make another build to make sure it's still the problem. :-)

Thanks
Kevin

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PULL] two sstate fixes
  2010-11-08  0:49   ` Tian, Kevin
@ 2010-11-08 21:31     ` Gary Thomas
  0 siblings, 0 replies; 4+ messages in thread
From: Gary Thomas @ 2010-11-08 21:31 UTC (permalink / raw)
  To: Tian, Kevin; +Cc: poky@yoctoproject.org

On 11/07/2010 05:49 PM, Tian, Kevin wrote:
>> From: Richard Purdie [mailto:rpurdie@linux.intel.com]
>> Sent: Monday, November 08, 2010 4:42 AM
>>
>> On Fri, 2010-11-05 at 15:53 +0800, Tian, Kevin wrote:
>>> meta/classes/package.bbclass |    1 +
>>>   meta/conf/distro/poky.conf   |    2 +-
>>>   2 files changed, 2 insertions(+), 1 deletion(-)
>>>
>>> commit bb9d4efa4076cfcf0998ecafb6d6b0969b97d224
>>> Author: Kevin Tian<kevin.tian@intel.com>
>>> Date:   Fri Nov 5 15:16:50 2010 +0800
>>>
>>>      poky.conf: add PWD to BB_HASHBASE_WHITELIST
>>>
>>>      Without doing this I can't reuse prebuilts generated from one directory in another
>>>      build directory which is really not comfortable for developers. Due to difference
>>>      on PWD variable, base hash becomes different for every sstate package.
>>>
>>>      So here PWD is added to the hase base whitelist, which makes most prebuilts reusable
>>>      now in a different build directory. However there still remains one issue about
>>>      do_populate_sysroot sstate package. Absolute path is encoded in this task which
>>>      then blocks reuse on them. Perhaps we need some redesign for do_populate_sysroot
>> into
>>>      two stages, with all absolute path related operations moved to the 2nd stage. This
>>>      way then the 1st stage can be reused.
>>
>>>      Partially fix [BUGID #522]
>>>
>>>      Signed-off-by Kevin Tian<kevin.tian@intel.com>
>>>
>>> commit 599ccdfa9d53e43fb2e44fdfd57de5d91868428b
>>> Author: Kevin Tian<kevin.tian@intel.com>
>>> Date:   Tue Oct 26 15:54:43 2010 +0800
>>>
>>>      package.bbclass: make sure 'sysroots' created before lockfile
>>>
>>>      package sstate requires a lock under sysroots/, which however may not be
>>>      created when sstate_setscene functions are executed and then causes failures.
>>>      here we make sure 'sysroots' created before do_package_setscene is executed.
>>>
>>>      Signed-off-by: Kevin Tian<kevin.tian@intel.com>
>>> Pull URL: http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=tk/master
>>
>> Good catches, I've merged these, thanks!
>>
>> You're right btw, we shouldn't be using hardcoded paths and we should
>> fix that. Can you confirm you were using staging packages from a recent
>> poky build though (0.9 release at least) as there were some bugs fixed
>> in that area coming up to release.
>>
>
> I forgot the exact commit after the rebase before sending pull request, but I know
> it's around the 0.9 release. So I'll make another build to make sure it's still the problem. :-)

These changes seem to have vastly improved this mechanism.  I'm still
testing, but I was [finally] able to actually use the sstate info to
make a new build.

Hooray :-)

-- 
------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2010-11-08 21:31 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-11-05  7:53 [PULL] two sstate fixes Tian, Kevin
2010-11-07 20:41 ` Richard Purdie
2010-11-08  0:49   ` Tian, Kevin
2010-11-08 21:31     ` Gary Thomas

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox