From: "Michael S. Tsirkin" <mst@redhat.com>
To: Jamin Lin <jamin_lin@aspeedtech.com>
Cc: "Cédric Le Goater" <clg@kaod.org>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Steven Lee" <steven_lee@aspeedtech.com>,
"Troy Lee" <leetroy@gmail.com>,
"Kane Chen" <kane_chen@aspeedtech.com>,
"Andrew Jeffery" <andrew@codeconstruct.com.au>,
"Joel Stanley" <joel@jms.id.au>,
"Pierrick Bouvier" <pierrick.bouvier@oss.qualcomm.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"open list:ASPEED BMCs" <qemu-arm@nongnu.org>,
"open list:All patches CC here" <qemu-devel@nongnu.org>,
"Troy Lee" <troy_lee@aspeedtech.com>
Subject: Re: [PATCH v1 3/7] hw/pci: Add the ASPEED VGA device id
Date: Mon, 7 Sep 2026 05:24:14 -0400 [thread overview]
Message-ID: <20260907052308-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20260907092004.2590015-4-jamin_lin@aspeedtech.com>
On Mon, Sep 07, 2026 at 09:20:08AM +0000, Jamin Lin wrote:
> The ASPEED vendor id is already listed. Add 0x2000, the device id the
> display controller of the ASPEED BMC SoCs reports, so that the model
> added by the next patch can use it.
>
> No functional change.
>
> Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
> ---
> include/hw/pci/pci_ids.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/hw/pci/pci_ids.h b/include/hw/pci/pci_ids.h
> index 16034aaa2c..e16d93dd13 100644
> --- a/include/hw/pci/pci_ids.h
> +++ b/include/hw/pci/pci_ids.h
> @@ -292,5 +292,6 @@
> #define PCI_VENDOR_ID_NVIDIA 0x10de
>
> #define PCI_VENDOR_ID_ASPEED 0x1A03
> +#define PCI_DEVICE_ID_ASPEED_VGA 0x2000
>
> #endif
you do not really need it, it should only be used
in one place. open-code the dev id in the implementation.
subsystem id will be copied automatically if not set.
> --
> 2.53.0
>
next prev parent reply other threads:[~2026-09-07 9:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-07 9:20 [PATCH v1 0/7] Add ASPEED VGA PCI device support Jamin Lin
2026-09-07 9:20 ` [PATCH v1 1/7] hw/display/vga: Allow a device to report vendor specific blanking Jamin Lin
2026-09-07 9:20 ` [PATCH v1 2/7] hw/display/vga: Move VGA_HPEL_NEUTRAL to vga_int.h Jamin Lin
2026-09-07 9:20 ` [PATCH v1 3/7] hw/pci: Add the ASPEED VGA device id Jamin Lin
2026-09-07 9:24 ` Michael S. Tsirkin [this message]
2026-09-08 0:44 ` Jamin Lin
2026-09-07 9:20 ` [PATCH v1 4/7] hw/display/aspeed-vga: Add ASPEED VGA display controller Jamin Lin
2026-09-07 9:20 ` [PATCH v1 5/7] hw/display/aspeed-vga: Add the hardware overlay cursor Jamin Lin
2026-09-07 9:20 ` [PATCH v1 6/7] hw/display/aspeed-vga: Add the 2D graphics engine Jamin Lin
2026-09-07 9:20 ` [PATCH v1 7/7] docs/system/arm/aspeed: Document the VGA display controller Jamin Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260907052308-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=andrew@codeconstruct.com.au \
--cc=clg@kaod.org \
--cc=jamin_lin@aspeedtech.com \
--cc=joel@jms.id.au \
--cc=kane_chen@aspeedtech.com \
--cc=kraxel@redhat.com \
--cc=leetroy@gmail.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=pierrick.bouvier@oss.qualcomm.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=steven_lee@aspeedtech.com \
--cc=troy_lee@aspeedtech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox