QEMU-Arm Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jamin Lin <jamin_lin@aspeedtech.com>
To: "Cédric Le Goater" <clg@kaod.org>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"Steven Lee" <steven_lee@aspeedtech.com>,
	"Troy Lee" <leetroy@gmail.com>,
	"Kane Chen" <kane_chen@aspeedtech.com>,
	"Andrew Jeffery" <andrew@codeconstruct.com.au>,
	"Joel Stanley" <joel@jms.id.au>,
	"Pierrick Bouvier" <pierrick.bouvier@oss.qualcomm.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Gerd Hoffmann" <kraxel@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	"open list:ASPEED BMCs" <qemu-arm@nongnu.org>,
	"open list:All patches CC here" <qemu-devel@nongnu.org>
Cc: Jamin Lin <jamin_lin@aspeedtech.com>, Troy Lee <troy_lee@aspeedtech.com>
Subject: [PATCH v1 2/7] hw/display/vga: Move VGA_HPEL_NEUTRAL to vga_int.h
Date: Mon, 7 Sep 2026 09:20:07 +0000	[thread overview]
Message-ID: <20260907092004.2590015-3-jamin_lin@aspeedtech.com> (raw)
In-Reply-To: <20260907092004.2590015-1-jamin_lin@aspeedtech.com>

VGA_HPEL_NEUTRAL is the pel panning value that means no shift. Move it
to the header so that other VGA devices can use it.

No functional change.

Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
---
 hw/display/vga_int.h | 8 ++++++++
 hw/display/vga.c     | 7 -------
 2 files changed, 8 insertions(+), 7 deletions(-)

diff --git a/hw/display/vga_int.h b/hw/display/vga_int.h
index 68f082acba..978b05e7eb 100644
--- a/hw/display/vga_int.h
+++ b/hw/display/vga_int.h
@@ -38,6 +38,14 @@
 #define CH_ATTR_SIZE (160 * 100)
 #define VGA_MAX_HEIGHT 2048
 
+/*
+ * This value corresponds to a shift of zero pixels
+ * in 9-dot text mode.  In other modes, bit 3 is undefined;
+ * we just ignore it, so that 8 corresponds to zero pixels
+ * in all modes.
+ */
+#define VGA_HPEL_NEUTRAL 8
+
 struct vga_precise_retrace {
     int64_t ticks_per_char;
     int64_t total_chars;
diff --git a/hw/display/vga.c b/hw/display/vga.c
index b273244cd5..b951d84736 100644
--- a/hw/display/vga.c
+++ b/hw/display/vga.c
@@ -53,13 +53,6 @@ bool have_vga = true;
 /* Address mask for non-VESA modes.  */
 #define VGA_VRAM_SIZE                   (256 * KiB)
 
-/* This value corresponds to a shift of zero pixels
- * in 9-dot text mode.  In other modes, bit 3 is undefined;
- * we just ignore it, so that 8 corresponds to zero pixels
- * in all modes.
- */
-#define VGA_HPEL_NEUTRAL		8
-
 /*
  * Video Graphics Array (VGA)
  *
-- 
2.53.0


  parent reply	other threads:[~2026-09-07  9:21 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-07  9:20 [PATCH v1 0/7] Add ASPEED VGA PCI device support Jamin Lin
2026-09-07  9:20 ` [PATCH v1 1/7] hw/display/vga: Allow a device to report vendor specific blanking Jamin Lin
2026-09-07  9:20 ` Jamin Lin [this message]
2026-09-07  9:20 ` [PATCH v1 3/7] hw/pci: Add the ASPEED VGA device id Jamin Lin
2026-09-07  9:24   ` Michael S. Tsirkin
2026-09-08  0:44     ` Jamin Lin
2026-09-07  9:20 ` [PATCH v1 4/7] hw/display/aspeed-vga: Add ASPEED VGA display controller Jamin Lin
2026-09-07  9:20 ` [PATCH v1 5/7] hw/display/aspeed-vga: Add the hardware overlay cursor Jamin Lin
2026-09-07  9:20 ` [PATCH v1 6/7] hw/display/aspeed-vga: Add the 2D graphics engine Jamin Lin
2026-09-07  9:20 ` [PATCH v1 7/7] docs/system/arm/aspeed: Document the VGA display controller Jamin Lin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260907092004.2590015-3-jamin_lin@aspeedtech.com \
    --to=jamin_lin@aspeedtech.com \
    --cc=andrew@codeconstruct.com.au \
    --cc=clg@kaod.org \
    --cc=joel@jms.id.au \
    --cc=kane_chen@aspeedtech.com \
    --cc=kraxel@redhat.com \
    --cc=leetroy@gmail.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=pierrick.bouvier@oss.qualcomm.com \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=steven_lee@aspeedtech.com \
    --cc=troy_lee@aspeedtech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox