From: Matthew Rosato <mjrosato@linux.ibm.com>
To: Farhan Ali <alifm@linux.ibm.com>,
Konstantin Shkolnyy <kshk@linux.ibm.com>
Cc: farman@linux.ibm.com, richard.henderson@linaro.org,
iii@linux.ibm.com, david@kernel.org, cohuck@redhat.com,
pasic@linux.ibm.com, borntraeger@linux.ibm.com,
qemu-s390x@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [PATCH v6 14/15] s390x/pci: Implement migration for emulated devices
Date: Tue, 11 Aug 2026 14:41:11 -0400 [thread overview]
Message-ID: <1d4cf0e9-343a-4ff1-82bf-da62762e57ce@linux.ibm.com> (raw)
In-Reply-To: <d4ee50cf-df97-48ee-9b5f-81de236b2451@linux.ibm.com>
>> +static void s390_clear_emul_dev_migration_blocker(S390PCIBusDevice
>> *pbdev,
>> + S390pciState *s)
>
> I don't think we need to pass the S390pciState here, as it's not used
> anymore. So we should remove it and update the callsites.
>
> With this fixed
> Reviewed-by: Farhan Ali<alifm@linux.ibm.com>
I haven't reviewed this version yet, but don't forget that you will also
need to move the fence to virtio-11.2
next prev parent reply other threads:[~2026-08-11 18:41 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-07 17:07 [PATCH v6 00/15] s390x/pci: Implement migration for emulated devices Konstantin Shkolnyy
2026-08-07 17:07 ` [PATCH v6 01/15] s390x/pci: implement IOMMU replay Konstantin Shkolnyy
2026-08-07 17:07 ` [PATCH v6 02/15] s390x/pci: Create function to contain translation status check Konstantin Shkolnyy
2026-08-07 17:08 ` [PATCH v6 03/15] s390x/pci: Move iommu_mr from S390PCIIOMMU to S390PCIBusDevice Konstantin Shkolnyy
2026-08-07 17:08 ` [PATCH v6 04/15] s390x/pci: Move dm_mr " Konstantin Shkolnyy
2026-08-07 17:08 ` [PATCH v6 05/15] s390x/pci: Move iotlb " Konstantin Shkolnyy
2026-08-11 17:17 ` Farhan Ali
2026-08-07 17:08 ` [PATCH v6 06/15] s390x/pci: Remove a ptr to S390PCIBusDevice from S390PCIIOMMU Konstantin Shkolnyy
2026-08-11 17:17 ` Farhan Ali
2026-08-07 17:08 ` [PATCH v6 07/15] s390x/pci: Move/rename enabled from S390PCIIOMMU to S390PCIBusDevice Konstantin Shkolnyy
2026-08-11 17:18 ` Farhan Ali
2026-08-07 17:08 ` [PATCH v6 08/15] s390x/pci: Move dma_limit " Konstantin Shkolnyy
2026-08-11 17:23 ` Farhan Ali
2026-08-07 17:08 ` [PATCH v6 09/15] s390x/pci: Move g_iota " Konstantin Shkolnyy
2026-08-11 17:25 ` Farhan Ali
2026-08-07 17:08 ` [PATCH v6 10/15] s390x/pci: Move pba " Konstantin Shkolnyy
2026-08-11 17:27 ` Farhan Ali
2026-08-07 17:08 ` [PATCH v6 11/15] s390x/pci: Move pal " Konstantin Shkolnyy
2026-08-11 17:37 ` Farhan Ali
2026-08-07 17:08 ` [PATCH v6 12/15] s390x/pci: Move max_dma_limit " Konstantin Shkolnyy
2026-08-11 17:39 ` Farhan Ali
2026-08-07 17:08 ` [PATCH v6 13/15] s390x/pci: Add a comment explaining S390PCIIOMMU purpose Konstantin Shkolnyy
2026-08-11 17:46 ` Farhan Ali
2026-08-07 17:08 ` [PATCH v6 14/15] s390x/pci: Implement migration for emulated devices Konstantin Shkolnyy
2026-08-11 18:17 ` Farhan Ali
2026-08-11 18:41 ` Matthew Rosato [this message]
2026-08-07 17:08 ` [PATCH v6 15/15] s390x/pci: Create function to contain fmb_timer start Konstantin Shkolnyy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d4cf0e9-343a-4ff1-82bf-da62762e57ce@linux.ibm.com \
--to=mjrosato@linux.ibm.com \
--cc=alifm@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@kernel.org \
--cc=farman@linux.ibm.com \
--cc=iii@linux.ibm.com \
--cc=kshk@linux.ibm.com \
--cc=pasic@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox