QEMU-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Konstantin Shkolnyy <kshk@linux.ibm.com>
To: mjrosato@linux.ibm.com
Cc: alifm@linux.ibm.com, farman@linux.ibm.com,
	richard.henderson@linaro.org, iii@linux.ibm.com,
	david@kernel.org, cohuck@redhat.com, pasic@linux.ibm.com,
	borntraeger@linux.ibm.com, qemu-s390x@nongnu.org,
	qemu-devel@nongnu.org, Konstantin Shkolnyy <kshk@linux.ibm.com>
Subject: [PATCH v6 13/15] s390x/pci: Add a comment explaining S390PCIIOMMU purpose
Date: Fri,  7 Aug 2026 12:08:10 -0500	[thread overview]
Message-ID: <20260807170812.658820-14-kshk@linux.ibm.com> (raw)
In-Reply-To: <20260807170812.658820-1-kshk@linux.ibm.com>

Because S390PCIIOMMU has just been cleaned up of fields it didn't have to
carry, add a comment explaining why it exists in the first place and
discouraging adding more fields to it in the future.

Signed-off-by: Konstantin Shkolnyy <kshk@linux.ibm.com>
---
 include/hw/s390x/s390-pci-bus.h | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/include/hw/s390x/s390-pci-bus.h b/include/hw/s390x/s390-pci-bus.h
index e3cbee2695..17ecf3e0da 100644
--- a/include/hw/s390x/s390-pci-bus.h
+++ b/include/hw/s390x/s390-pci-bus.h
@@ -271,6 +271,17 @@ typedef struct S390PCIDMACount {
     QTAILQ_ENTRY(S390PCIDMACount) link;
 } S390PCIDMACount;
 
+/*
+ * This structure holds the PCI device AddressSpace that QEMU needs to link
+ * into its internal structures before the zPCI and PCI devices are fully
+ * initialized. QEMU wants to have this "root" AddressSpace before the PCI
+ * device is plugged in. It's only actually used for I/O while the PCI
+ * device is plugged in and configured by the guest, at which time it has
+ * additional memory subregions from zPCI device, that can do real work.
+ * In other words, S390PCIIOMMU holds fields that logically belong to
+ * S390PCIBusDevice but need to exist before S390PCIBusDevice exists.
+ * Therefore, no other kind of fields should be placed in S390PCIIOMMU.
+ */
 struct S390PCIIOMMU {
     Object parent_obj;
     AddressSpace as;
-- 
2.34.1



  parent reply	other threads:[~2026-08-07 17:09 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-07 17:07 [PATCH v6 00/15] s390x/pci: Implement migration for emulated devices Konstantin Shkolnyy
2026-08-07 17:07 ` [PATCH v6 01/15] s390x/pci: implement IOMMU replay Konstantin Shkolnyy
2026-08-07 17:07 ` [PATCH v6 02/15] s390x/pci: Create function to contain translation status check Konstantin Shkolnyy
2026-08-07 17:08 ` [PATCH v6 03/15] s390x/pci: Move iommu_mr from S390PCIIOMMU to S390PCIBusDevice Konstantin Shkolnyy
2026-08-07 17:08 ` [PATCH v6 04/15] s390x/pci: Move dm_mr " Konstantin Shkolnyy
2026-08-07 17:08 ` [PATCH v6 05/15] s390x/pci: Move iotlb " Konstantin Shkolnyy
2026-08-11 17:17   ` Farhan Ali
2026-08-07 17:08 ` [PATCH v6 06/15] s390x/pci: Remove a ptr to S390PCIBusDevice from S390PCIIOMMU Konstantin Shkolnyy
2026-08-11 17:17   ` Farhan Ali
2026-08-07 17:08 ` [PATCH v6 07/15] s390x/pci: Move/rename enabled from S390PCIIOMMU to S390PCIBusDevice Konstantin Shkolnyy
2026-08-11 17:18   ` Farhan Ali
2026-08-07 17:08 ` [PATCH v6 08/15] s390x/pci: Move dma_limit " Konstantin Shkolnyy
2026-08-11 17:23   ` Farhan Ali
2026-08-07 17:08 ` [PATCH v6 09/15] s390x/pci: Move g_iota " Konstantin Shkolnyy
2026-08-11 17:25   ` Farhan Ali
2026-08-07 17:08 ` [PATCH v6 10/15] s390x/pci: Move pba " Konstantin Shkolnyy
2026-08-11 17:27   ` Farhan Ali
2026-08-07 17:08 ` [PATCH v6 11/15] s390x/pci: Move pal " Konstantin Shkolnyy
2026-08-11 17:37   ` Farhan Ali
2026-08-07 17:08 ` [PATCH v6 12/15] s390x/pci: Move max_dma_limit " Konstantin Shkolnyy
2026-08-11 17:39   ` Farhan Ali
2026-08-07 17:08 ` Konstantin Shkolnyy [this message]
2026-08-11 17:46   ` [PATCH v6 13/15] s390x/pci: Add a comment explaining S390PCIIOMMU purpose Farhan Ali
2026-08-07 17:08 ` [PATCH v6 14/15] s390x/pci: Implement migration for emulated devices Konstantin Shkolnyy
2026-08-11 18:17   ` Farhan Ali
2026-08-11 18:41     ` Matthew Rosato
2026-08-07 17:08 ` [PATCH v6 15/15] s390x/pci: Create function to contain fmb_timer start Konstantin Shkolnyy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260807170812.658820-14-kshk@linux.ibm.com \
    --to=kshk@linux.ibm.com \
    --cc=alifm@linux.ibm.com \
    --cc=borntraeger@linux.ibm.com \
    --cc=cohuck@redhat.com \
    --cc=david@kernel.org \
    --cc=farman@linux.ibm.com \
    --cc=iii@linux.ibm.com \
    --cc=mjrosato@linux.ibm.com \
    --cc=pasic@linux.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox