From: Kevin Wolf <kwolf@redhat.com>
To: Bin Guo <guobin@linux.alibaba.com>
Cc: qemu-devel@nongnu.org, pbonzini@redhat.com, berrange@redhat.com,
hreitz@redhat.com, qemu-block@nongnu.org
Subject: Re: [PATCH 2/3] block/block-backend: delegate blk_co_preadv to blk_co_preadv_part
Date: Tue, 12 May 2026 14:58:30 +0200 [thread overview]
Message-ID: <agMj9nEEt8VpHCCx@redhat.com> (raw)
In-Reply-To: <20260429062004.36582-3-guobin@linux.alibaba.com>
Am 29.04.2026 um 08:20 hat Bin Guo geschrieben:
> blk_co_preadv() and blk_co_preadv_part() share identical bodies except
> that blk_co_preadv() always passes qiov_offset=0. blk_co_pwritev()
> already uses this pattern and simply calls blk_co_pwritev_part() with
> qiov_offset=0. Apply the same simplification to the read side so that
> both pairs are consistent and the shared logic lives in a single place.
>
> Before this change blk_co_preadv() duplicated the
> blk_inc_in_flight / blk_co_do_preadv_part / blk_dec_in_flight
> sequence. After this change it is a one-liner wrapper, matching the
> write side.
>
> Signed-off-by: Bin Guo <guobin@linux.alibaba.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
next prev parent reply other threads:[~2026-05-12 12:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-29 6:20 [PATCH 0/3] Minor cleanups: eliminate redundant code in QOM, block-backend and vl.c Bin Guo
2026-04-29 6:20 ` [PATCH 1/3] qom/object: merge double hash table traversal in object_property_del_child Bin Guo
2026-04-29 21:07 ` Richard Henderson
2026-04-30 9:24 ` Daniel P. Berrangé
2026-04-30 13:36 ` Philippe Mathieu-Daudé
2026-04-29 6:20 ` [PATCH 2/3] block/block-backend: delegate blk_co_preadv to blk_co_preadv_part Bin Guo
2026-04-29 21:07 ` Richard Henderson
2026-05-12 12:58 ` Kevin Wolf [this message]
2026-04-29 6:20 ` [PATCH 3/3] system/vl.c: inline qemu_opts_parse_noisily() result checks Bin Guo
2026-04-29 8:04 ` Philippe Mathieu-Daudé
2026-04-29 21:03 ` Richard Henderson
2026-04-30 6:07 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=agMj9nEEt8VpHCCx@redhat.com \
--to=kwolf@redhat.com \
--cc=berrange@redhat.com \
--cc=guobin@linux.alibaba.com \
--cc=hreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox