QEMU-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Bin Guo <guobin@linux.alibaba.com>
To: qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, berrange@redhat.com, kwolf@redhat.com,
	hreitz@redhat.com, qemu-block@nongnu.org
Subject: [PATCH 0/3] Minor cleanups: eliminate redundant code in QOM, block-backend and vl.c
Date: Wed, 29 Apr 2026 14:20:01 +0800	[thread overview]
Message-ID: <20260429062004.36582-1-guobin@linux.alibaba.com> (raw)

This series contains three independent cleanups that remove redundant
code and improve consistency across different subsystems.

Patch 1 merges a double hash-table traversal in object_property_del_child()
into a single pass, halving the number of hash table operations in the
common case.

Patch 2 makes blk_co_preadv() a one-liner wrapper around
blk_co_preadv_part(), matching the existing pattern already used by
the write side (blk_co_pwritev / blk_co_pwritev_part).

Patch 3 inlines qemu_opts_parse_noisily() return-value checks directly
into if-conditions for options that do not use the returned pointer,
matching the style already used by QEMU_OPTION_action.

All three patches are independent and can be applied in any order.

Bin Guo (3):
  qom/object: merge double hash table traversal in
    object_property_del_child
  block/block-backend: delegate blk_co_preadv to blk_co_preadv_part
  system/vl.c: inline qemu_opts_parse_noisily() result checks

 block/block-backend.c |  8 +-------
 qom/object.c          |  7 -------
 system/vl.c           | 37 +++++++++++++++----------------------
 3 files changed, 16 insertions(+), 36 deletions(-)

-- 
2.50.1 (Apple Git-155)



             reply	other threads:[~2026-04-29  6:21 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-29  6:20 Bin Guo [this message]
2026-04-29  6:20 ` [PATCH 1/3] qom/object: merge double hash table traversal in object_property_del_child Bin Guo
2026-04-29 21:07   ` Richard Henderson
2026-04-30  9:24     ` Daniel P. Berrangé
2026-04-30 13:36       ` Philippe Mathieu-Daudé
2026-04-29  6:20 ` [PATCH 2/3] block/block-backend: delegate blk_co_preadv to blk_co_preadv_part Bin Guo
2026-04-29 21:07   ` Richard Henderson
2026-05-12 12:58   ` Kevin Wolf
2026-04-29  6:20 ` [PATCH 3/3] system/vl.c: inline qemu_opts_parse_noisily() result checks Bin Guo
2026-04-29  8:04   ` Philippe Mathieu-Daudé
2026-04-29 21:03     ` Richard Henderson
2026-04-30  6:07       ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260429062004.36582-1-guobin@linux.alibaba.com \
    --to=guobin@linux.alibaba.com \
    --cc=berrange@redhat.com \
    --cc=hreitz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox