public inbox for qemu-trivial@nongnu.org
 help / color / mirror / Atom feed
From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
	qemu-block@nongnu.org, Hanna Reitz <hreitz@redhat.com>,
	qemu-devel@nongnu.org, qemu-trivial@nongnu.org
Subject: Re: [PATCH] tests/qemu-iotests: Use "gsed" for expressions that require GNU sed
Date: Tue, 13 Jan 2026 14:34:01 +0000	[thread overview]
Message-ID: <aWZX2c2q7BUgIFz3@redhat.com> (raw)
In-Reply-To: <20260113141415.97281-1-thuth@redhat.com>

On Tue, Jan 13, 2026 at 03:14:15PM +0100, Thomas Huth wrote:
> From: Thomas Huth <thuth@redhat.com>
> 
> A bunch of tests are currently failing e.g. on FreeBSD like this:
> 
>  082   fail       [13:38:58] [13:38:59]   0.5s                 output
>   mismatch (see .../build/tests/qemu-iotests/scratch/qcow2-file-082/082.out.bad)
>  --- .../src/tests/qemu-iotests/082.out
>  +++ .../build/tests/qemu-iotests/scratch/qcow2-file-082/082.out.bad
>  @@ -17,7 +17,7 @@
>   cluster_size: 4096
>   Format specific information:
>       compat: 1.1
>  -    compression type: COMPRESSION_TYPE
>  +    compression type: zlib
>       lazy refcounts: true
>       refcount bits: 16
>       corrupt: false
> 
> This happens because the sed statements require GNU sed. Let's use
> gsed in these spots to get it fixed.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  tests/qemu-iotests/286       | 2 +-
>  tests/qemu-iotests/common.rc | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|



  reply	other threads:[~2026-01-13 14:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-13 14:14 [PATCH] tests/qemu-iotests: Use "gsed" for expressions that require GNU sed Thomas Huth
2026-01-13 14:34 ` Daniel P. Berrangé [this message]
2026-01-14 18:40 ` Eric Blake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aWZX2c2q7BUgIFz3@redhat.com \
    --to=berrange@redhat.com \
    --cc=hreitz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox