From: Eric Blake <eblake@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-block@nongnu.org, Hanna Reitz <hreitz@redhat.com>,
qemu-devel@nongnu.org, qemu-trivial@nongnu.org
Subject: Re: [PATCH] tests/qemu-iotests: Use "gsed" for expressions that require GNU sed
Date: Wed, 14 Jan 2026 12:40:27 -0600 [thread overview]
Message-ID: <aWfifqfqWAYaVEsB@redhat.com> (raw)
In-Reply-To: <20260113141415.97281-1-thuth@redhat.com>
On Tue, Jan 13, 2026 at 03:14:15PM +0100, Thomas Huth wrote:
> From: Thomas Huth <thuth@redhat.com>
>
> A bunch of tests are currently failing e.g. on FreeBSD like this:
>
> This happens because the sed statements require GNU sed. Let's use
> gsed in these spots to get it fixed.
gsed is not installed by that name on all machines...
\me checks
Ah, common.rc defines a function gsed that calls the appropriate sed.
No objection to the patch as-is, although a mention of the common.rc
existence of gsed might help the next reader who sees just the commit
message and wonders about it like I did.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization: qemu.org | libguestfs.org
prev parent reply other threads:[~2026-01-14 18:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-13 14:14 [PATCH] tests/qemu-iotests: Use "gsed" for expressions that require GNU sed Thomas Huth
2026-01-13 14:34 ` Daniel P. Berrangé
2026-01-14 18:40 ` Eric Blake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aWfifqfqWAYaVEsB@redhat.com \
--to=eblake@redhat.com \
--cc=hreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox