From: Joel Fernandes <joel@joelfernandes.org>
To: "Paul E. McKenney" <paulmck@linux.ibm.com>
Cc: LKML <linux-kernel@vger.kernel.org>, rcu@vger.kernel.org
Subject: Re: [RFC 0/5] RCU fixes for rcu_assign_pointer usage
Date: Thu, 21 Feb 2019 11:50:22 -0500 [thread overview]
Message-ID: <20190221165022.GA103806@google.com> (raw)
In-Reply-To: <20190220182820.GO11787@linux.ibm.com>
On Wed, Feb 20, 2019 at 10:28:20AM -0800, Paul E. McKenney wrote:
> On Wed, Feb 20, 2019 at 01:09:52PM -0500, Joel Fernandes wrote:
> > On Wed, Feb 20, 2019 at 08:42:43AM -0800, Paul E. McKenney wrote:
> > > On Tue, Feb 19, 2019 at 08:11:36PM -0800, Joel Fernandes wrote:
> > > > On Tue, Feb 19, 2019 at 8:08 PM Joel Fernandes (Google)
> > > > <joel@joelfernandes.org> wrote:
> > > > >
> > > > > These patches fix various RCU API usage issues found due to sparse errors as a
> > > > > result of the recent check to add rcu_check_sparse() to rcu_assign_pointer().
> > > > >
> > > > > This is very early RFC stage, and is only build tested. I am also only sending
> > > > > to the RCU group for initial review before sending to LKML. Thanks for any feedback!
> > > > >
> > > > > There are still more usages that cause errors such as rbtree which I am
> > > > > looking into.
> > > >
> > > > Looks like it got sent to LKML anyway, ;-) That's Ok since it is
> > > > prefixed as RFC.
> > >
> > > As is only right and proper. ;-)
> > >
> > > I don't see an immediate problem with them, but it would be good to get
> > > the relevant developers and maintainers on CC for the next version. I
> > > cannot claim to know that code very well.
> >
> > Definitely will CC them next time, sorry about that. I'll stop being so shy
> > but I have some scars that are still healing ;-)
>
> If you don't get at least a few scars, you aren't trying hard enough! ;-)
Well said ;-) I noted this as a quote in my "famous quotes list" ;)
thanks,
- Joel
prev parent reply other threads:[~2019-02-21 16:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-20 4:08 [RFC 0/5] RCU fixes for rcu_assign_pointer usage Joel Fernandes (Google)
2019-02-20 4:08 ` [RFC 1/5] net: rtnetlink: Fix incorrect RCU API usage Joel Fernandes (Google)
2019-02-20 16:40 ` Paul E. McKenney
2019-02-20 18:08 ` Joel Fernandes
2019-02-20 4:08 ` [RFC 2/5] ixgbe: " Joel Fernandes (Google)
2019-02-20 4:08 ` [RFC 3/5] sched/cpufreq: " Joel Fernandes (Google)
2019-02-20 4:08 ` [RFC 4/5] sched/toplogy: Use smp_store_release() instead of rcu_assign_pointer Joel Fernandes (Google)
2019-02-20 4:08 ` [RFC 5/5] rcuwait: Replace rcu_assign_pointer with smp_store_release Joel Fernandes (Google)
2019-02-20 4:11 ` [RFC 0/5] RCU fixes for rcu_assign_pointer usage Joel Fernandes
2019-02-20 16:42 ` Paul E. McKenney
2019-02-20 18:09 ` Joel Fernandes
2019-02-20 18:28 ` Paul E. McKenney
2019-02-21 16:50 ` Joel Fernandes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190221165022.GA103806@google.com \
--to=joel@joelfernandes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@linux.ibm.com \
--cc=rcu@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox