* [PATCH v2 2/4] rcu: Replace 1 by true [not found] ` <20200330012450.312155-1-jbi.octave@gmail.com> @ 2020-03-30 1:24 ` Jules Irenge 2020-03-30 21:16 ` Paul E. McKenney 0 siblings, 1 reply; 2+ messages in thread From: Jules Irenge @ 2020-03-30 1:24 UTC (permalink / raw) To: linux-kernel Cc: julia.lawall, boqun.feng, Paul E. McKenney, Josh Triplett, Steven Rostedt, Mathieu Desnoyers, Lai Jiangshan, Joel Fernandes, open list:READ-COPY UPDATE (RCU) Coccinelle reports a warning at use_softirq declaration WARNING: Assignment of 0/1 to bool variable The root cause is use_softirq a variable of bool type is initialised with the integer 1 Replacing 1 with value true solve the issue. Signed-off-by: Jules Irenge <jbi.octave@gmail.com> --- kernel/rcu/tree.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c index d91c9156fab2..c2ffea31eae8 100644 --- a/kernel/rcu/tree.c +++ b/kernel/rcu/tree.c @@ -100,7 +100,7 @@ static struct rcu_state rcu_state = { static bool dump_tree; module_param(dump_tree, bool, 0444); /* By default, use RCU_SOFTIRQ instead of rcuc kthreads. */ -static bool use_softirq = 1; +static bool use_softirq = true; module_param(use_softirq, bool, 0444); /* Control rcu_node-tree auto-balancing at boot time. */ static bool rcu_fanout_exact; -- 2.25.1 ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2 2/4] rcu: Replace 1 by true 2020-03-30 1:24 ` [PATCH v2 2/4] rcu: Replace 1 by true Jules Irenge @ 2020-03-30 21:16 ` Paul E. McKenney 0 siblings, 0 replies; 2+ messages in thread From: Paul E. McKenney @ 2020-03-30 21:16 UTC (permalink / raw) To: Jules Irenge Cc: linux-kernel, julia.lawall, boqun.feng, Josh Triplett, Steven Rostedt, Mathieu Desnoyers, Lai Jiangshan, Joel Fernandes, open list:READ-COPY UPDATE (RCU) On Mon, Mar 30, 2020 at 02:24:48AM +0100, Jules Irenge wrote: > Coccinelle reports a warning at use_softirq declaration > > WARNING: Assignment of 0/1 to bool variable > > The root cause is > use_softirq a variable of bool type is initialised with the integer 1 > Replacing 1 with value true solve the issue. > > Signed-off-by: Jules Irenge <jbi.octave@gmail.com> Queued for review and testing, thank you! Thanx, Paul > --- > kernel/rcu/tree.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c > index d91c9156fab2..c2ffea31eae8 100644 > --- a/kernel/rcu/tree.c > +++ b/kernel/rcu/tree.c > @@ -100,7 +100,7 @@ static struct rcu_state rcu_state = { > static bool dump_tree; > module_param(dump_tree, bool, 0444); > /* By default, use RCU_SOFTIRQ instead of rcuc kthreads. */ > -static bool use_softirq = 1; > +static bool use_softirq = true; > module_param(use_softirq, bool, 0444); > /* Control rcu_node-tree auto-balancing at boot time. */ > static bool rcu_fanout_exact; > -- > 2.25.1 > ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-03-30 21:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <0/4>
[not found] ` <20200330012450.312155-1-jbi.octave@gmail.com>
2020-03-30 1:24 ` [PATCH v2 2/4] rcu: Replace 1 by true Jules Irenge
2020-03-30 21:16 ` Paul E. McKenney
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox