[PATCH] doc: rcu: update printed dynticks counter bits

[PATCH] doc: rcu: update printed dynticks counter bits

[Baruch Siach]

The stall warning prints 16 bits since commit 171476775d32
("context_tracking: Convert state to atomic_t").

Fixes: 171476775d32 ("context_tracking: Convert state to atomic_t")
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
 Documentation/RCU/stallwarn.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/RCU/stallwarn.rst b/Documentation/RCU/stallwarn.rst
index ca7b7cd806a1..30080ff6f406 100644
--- a/Documentation/RCU/stallwarn.rst
+++ b/Documentation/RCU/stallwarn.rst
@@ -249,7 +249,7 @@ ticks this GP)" indicates that this CPU has not taken any scheduling-clock
 interrupts during the current stalled grace period.
 
 The "idle=" portion of the message prints the dyntick-idle state.
-The hex number before the first "/" is the low-order 12 bits of the
+The hex number before the first "/" is the low-order 16 bits of the
 dynticks counter, which will have an even-numbered value if the CPU
 is in dyntick-idle mode and an odd-numbered value otherwise.  The hex
 number between the two "/"s is the value of the nesting, which will be
-- 
2.43.0

Re: [PATCH] doc: rcu: update printed dynticks counter bits

[Paul E. McKenney]

On Sun, Aug 18, 2024 at 11:18:17AM +0300, Baruch Siach wrote:
> The stall warning prints 16 bits since commit 171476775d32
> ("context_tracking: Convert state to atomic_t").
> 
> Fixes: 171476775d32 ("context_tracking: Convert state to atomic_t")
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>

Good eyes!

Reviewed-by: Paul E. McKenney <paulmck@kernel.org>

> ---
>  Documentation/RCU/stallwarn.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/RCU/stallwarn.rst b/Documentation/RCU/stallwarn.rst
> index ca7b7cd806a1..30080ff6f406 100644
> --- a/Documentation/RCU/stallwarn.rst
> +++ b/Documentation/RCU/stallwarn.rst
> @@ -249,7 +249,7 @@ ticks this GP)" indicates that this CPU has not taken any scheduling-clock
>  interrupts during the current stalled grace period.
>  
>  The "idle=" portion of the message prints the dyntick-idle state.
> -The hex number before the first "/" is the low-order 12 bits of the
> +The hex number before the first "/" is the low-order 16 bits of the
>  dynticks counter, which will have an even-numbered value if the CPU
>  is in dyntick-idle mode and an odd-numbered value otherwise.  The hex
>  number between the two "/"s is the value of the nesting, which will be
> -- 
> 2.43.0
> 

Re: [PATCH] doc: rcu: update printed dynticks counter bits

[Baruch Siach]

Hi Paul,

On Tue, Aug 20 2024, Paul E. McKenney wrote:
> On Sun, Aug 18, 2024 at 11:18:17AM +0300, Baruch Siach wrote:
>> The stall warning prints 16 bits since commit 171476775d32
>> ("context_tracking: Convert state to atomic_t").
>> 
>> Fixes: 171476775d32 ("context_tracking: Convert state to atomic_t")
>> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
>
> Good eyes!
>
> Reviewed-by: Paul E. McKenney <paulmck@kernel.org>

I remember seeing this patch queued in one of the rcu git trees, but I
can't find it anymore. I don't see it in Linus' tree either.

Thanks,
baruch

>>  Documentation/RCU/stallwarn.rst | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/Documentation/RCU/stallwarn.rst b/Documentation/RCU/stallwarn.rst
>> index ca7b7cd806a1..30080ff6f406 100644
>> --- a/Documentation/RCU/stallwarn.rst
>> +++ b/Documentation/RCU/stallwarn.rst
>> @@ -249,7 +249,7 @@ ticks this GP)" indicates that this CPU has not taken any scheduling-clock
>>  interrupts during the current stalled grace period.
>>  
>>  The "idle=" portion of the message prints the dyntick-idle state.
>> -The hex number before the first "/" is the low-order 12 bits of the
>> +The hex number before the first "/" is the low-order 16 bits of the
>>  dynticks counter, which will have an even-numbered value if the CPU
>>  is in dyntick-idle mode and an odd-numbered value otherwise.  The hex
>>  number between the two "/"s is the value of the nesting, which will be
>> -- 
>> 2.43.0
>> 

-- 
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -

Re: [PATCH] doc: rcu: update printed dynticks counter bits

[Neeraj Upadhyay]

Hi Baruch,

On Thu, Sep 26, 2024 at 12:05:38PM +0300, Baruch Siach wrote:
> Hi Paul,
> 
> On Tue, Aug 20 2024, Paul E. McKenney wrote:
> > On Sun, Aug 18, 2024 at 11:18:17AM +0300, Baruch Siach wrote:
> >> The stall warning prints 16 bits since commit 171476775d32
> >> ("context_tracking: Convert state to atomic_t").
> >> 
> >> Fixes: 171476775d32 ("context_tracking: Convert state to atomic_t")
> >> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> >
> > Good eyes!
> >
> > Reviewed-by: Paul E. McKenney <paulmck@kernel.org>
> 
> I remember seeing this patch queued in one of the rcu git trees, but I
> can't find it anymore. I don't see it in Linus' tree either.
> 

This patch is included for v6.13 queue [1]

[1] https://git.kernel.org/pub/scm/linux/kernel/git/neeraj.upadhyay/linux-rcu.git/log/?h=dev


- Neeraj

> Thanks,
> baruch
> 
> >>  Documentation/RCU/stallwarn.rst | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >> 
> >> diff --git a/Documentation/RCU/stallwarn.rst b/Documentation/RCU/stallwarn.rst
> >> index ca7b7cd806a1..30080ff6f406 100644
> >> --- a/Documentation/RCU/stallwarn.rst
> >> +++ b/Documentation/RCU/stallwarn.rst
> >> @@ -249,7 +249,7 @@ ticks this GP)" indicates that this CPU has not taken any scheduling-clock
> >>  interrupts during the current stalled grace period.
> >>  
> >>  The "idle=" portion of the message prints the dyntick-idle state.
> >> -The hex number before the first "/" is the low-order 12 bits of the
> >> +The hex number before the first "/" is the low-order 16 bits of the
> >>  dynticks counter, which will have an even-numbered value if the CPU
> >>  is in dyntick-idle mode and an odd-numbered value otherwise.  The hex
> >>  number between the two "/"s is the value of the nesting, which will be
> >> -- 
> >> 2.43.0
> >> 
> 
> -- 
>                                                      ~. .~   Tk Open Systems
> =}------------------------------------------------ooO--U--Ooo------------{=
>    - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -