From: "Paul E. McKenney" <paulmck@kernel.org>
To: rcu@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, kernel-team@meta.com,
rostedt@goodmis.org, "Paul E. McKenney" <paulmck@kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
Peter Zijlstra <peterz@infradead.org>,
Mark Rutland <mark.rutland@arm.com>,
Boqun Feng <boqun.feng@gmail.com>,
linux-doc@vger.kernel.org
Subject: [PATCH rcu 2/7] docs: Improve discussion of this_cpu_ptr(), add raw_cpu_ptr()
Date: Thu, 16 Jan 2025 12:02:34 -0800 [thread overview]
Message-ID: <20250116200239.3782374-2-paulmck@kernel.org> (raw)
In-Reply-To: <a2c2793d-771a-436e-8c42-4cb38def0e2f@paulmck-laptop>
Most of the this_cpu_*() operations may be used in preemptible code,
but not this_cpu_ptr(), and for good reasons. Therefore, better explain
the reasons and call out raw_cpu_ptr() as an alternative in certain very
special cases.
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Cc: Jonathan Corbet <corbet@lwn.net>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Boqun Feng <boqun.feng@gmail.com>
Cc: <linux-doc@vger.kernel.org>
---
Documentation/core-api/this_cpu_ops.rst | 22 ++++++++++++++++------
1 file changed, 16 insertions(+), 6 deletions(-)
diff --git a/Documentation/core-api/this_cpu_ops.rst b/Documentation/core-api/this_cpu_ops.rst
index 91acbcf30e9bd..11e3e48731553 100644
--- a/Documentation/core-api/this_cpu_ops.rst
+++ b/Documentation/core-api/this_cpu_ops.rst
@@ -138,12 +138,22 @@ get_cpu/put_cpu sequence requires. No processor number is
available. Instead, the offset of the local per cpu area is simply
added to the per cpu offset.
-Note that this operation is usually used in a code segment when
-preemption has been disabled. The pointer is then used to
-access local per cpu data in a critical section. When preemption
-is re-enabled this pointer is usually no longer useful since it may
-no longer point to per cpu data of the current processor.
-
+Note that this operation can only be used in code segments where
+smp_processor_id() may be used, for example, where preemption has been
+disabled. The pointer is then used to access local per cpu data in a
+critical section. When preemption is re-enabled this pointer is usually
+no longer useful since it may no longer point to per cpu data of the
+current processor.
+
+The special cases where it makes sense do obtain a per-CPU pointer in
+preemptible code are addressed by raw_cpu_ptr(), but please note that such
+use cases need to handle cases where two different CPUs are accessing
+the same per cpu variable, which might well be that of a third CPU.
+These use cases are typically performance optimizations. For example,
+SRCU implements a pair of counters as a pair of per-CPU variables,
+and rcu_read_lock_nmisafe() uses raw_cpu_ptr() to get a pointer to some
+CPU's counter, and uses atomic_inc_long() to handle migration between
+the raw_cpu_ptr() and the atomic_inc_long().
Per cpu variables and offsets
-----------------------------
--
2.40.1
next prev parent reply other threads:[~2025-01-16 20:02 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-16 20:02 [PATCH rcu 0/7] Documentation upates Paul E. McKenney
2025-01-16 20:02 ` [PATCH rcu 1/7] doc: Add broken-timing possibility to stallwarn.rst Paul E. McKenney
2025-01-16 20:02 ` Paul E. McKenney [this message]
2025-01-16 21:02 ` [PATCH rcu 2/7] docs: Improve discussion of this_cpu_ptr(), add raw_cpu_ptr() Matthew Wilcox
2025-01-16 22:57 ` Paul E. McKenney
2025-01-16 20:02 ` [PATCH rcu 3/7] rcu: Document self-propagating callbacks Paul E. McKenney
2025-01-16 21:38 ` Jens Axboe
2025-01-16 20:02 ` [PATCH rcu 4/7] srcu: Point call_srcu() to call_rcu() for detailed memory ordering Paul E. McKenney
2025-01-16 20:02 ` [PATCH rcu 5/7] rcu: Add CONFIG_RCU_LAZY delays to call_rcu() kernel-doc header Paul E. McKenney
2025-01-16 20:02 ` [PATCH rcu 6/7] rcu: Clarify RCU_LAZY and RCU_LAZY_DEFAULT_OFF help text Paul E. McKenney
2025-01-16 20:02 ` [PATCH rcu 7/7] rcu: Remove references to old grace-period-wait primitives Paul E. McKenney
2025-01-30 18:47 ` [PATCH rcu 0/7] Documentation upates Paul E. McKenney
2025-01-30 18:49 ` [PATCH rcu v2 1/7] doc: Add broken-timing possibility to stallwarn.rst Paul E. McKenney
2025-01-30 18:49 ` [PATCH rcu v2 2/7] docs: Improve discussion of this_cpu_ptr(), add raw_cpu_ptr() Paul E. McKenney
2025-01-30 18:49 ` [PATCH rcu v2 3/7] rcu: Document self-propagating callbacks Paul E. McKenney
2025-01-30 18:49 ` [PATCH rcu v2 4/7] srcu: Point call_srcu() to call_rcu() for detailed memory ordering Paul E. McKenney
2025-01-30 18:49 ` [PATCH rcu v2 5/7] rcu: Add CONFIG_RCU_LAZY delays to call_rcu() kernel-doc header Paul E. McKenney
2025-01-30 18:49 ` [PATCH rcu v2 6/7] rcu: Clarify RCU_LAZY and RCU_LAZY_DEFAULT_OFF help text Paul E. McKenney
2025-01-30 18:49 ` [PATCH rcu v2 7/7] rcu: Remove references to old grace-period-wait primitives Paul E. McKenney
-- strict thread matches above, loose matches on Subject: below --
2025-02-18 5:45 [PATCH rcu 0/7] RCU documentation changes for v6.15 Boqun Feng
2025-02-18 5:45 ` [PATCH rcu 2/7] docs: Improve discussion of this_cpu_ptr(), add raw_cpu_ptr() Boqun Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250116200239.3782374-2-paulmck@kernel.org \
--to=paulmck@kernel.org \
--cc=boqun.feng@gmail.com \
--cc=corbet@lwn.net \
--cc=kernel-team@meta.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=peterz@infradead.org \
--cc=rcu@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox