Linux RCU subsystem development
 help / color / mirror / Atom feed
From: "Paul E. McKenney" <paulmck@kernel.org>
To: rcu@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, kernel-team@meta.com,
	rostedt@goodmis.org,
	Kaushlendra Kumar <kaushlendra.kumar@intel.com>,
	"Paul E . McKenney" <paulmck@kernel.org>
Subject: [PATCH v2 10/11] refperf: Remove redundant kfree() after torture_stop_kthread()
Date: Thu, 18 Sep 2025 03:29:51 -0700	[thread overview]
Message-ID: <20250918102952.2593045-10-paulmck@kernel.org> (raw)
In-Reply-To: <c0edd79a-f988-432c-b08a-18793b2e15d9@paulmck-laptop>

From: Kaushlendra Kumar <kaushlendra.kumar@intel.com>

Remove unnecessary kfree(main_task) call in ref_scale_cleanup() as
torture_stop_kthread() already handles the memory cleanup for the
task structure internally.

The additional kfree(main_task) call after torture_stop_kthread()
is redundant and confusing since torture_stop_kthread() sets the
pointer to NULL, making this a no-op.

This pattern is consistent with other torture test modules where
torture_stop_kthread() is called without explicit kfree() of the
task pointer, as the torture framework manages the task lifecycle
internally.

Signed-off-by: Kaushlendra Kumar <kaushlendra.kumar@intel.com>
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
---
 kernel/rcu/refscale.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/kernel/rcu/refscale.c b/kernel/rcu/refscale.c
index 5840fac06feb7d..7f3d23762ef7c7 100644
--- a/kernel/rcu/refscale.c
+++ b/kernel/rcu/refscale.c
@@ -1135,7 +1135,6 @@ ref_scale_cleanup(void)
 	kfree(reader_tasks);
 
 	torture_stop_kthread("main_task", main_task);
-	kfree(main_task);
 
 	// Do scale-type-specific cleanup operations.
 	if (cur_ops->cleanup != NULL)
-- 
2.40.1


  parent reply	other threads:[~2025-09-18 10:29 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-18 10:29 [PATCH v2 0/11] RCU torture-test updates for v6.18 Paul E. McKenney
2025-09-18 10:29 ` [PATCH v2 01/11] rcutorture: Fix jitter.sh spin time Paul E. McKenney
2025-09-18 10:29 ` [PATCH v2 02/11] torture: Add --do-normal parameter to torture.sh help text Paul E. McKenney
2025-09-18 10:29 ` [PATCH v2 03/11] torture: Announce kernel boot status at torture-test startup Paul E. McKenney
2025-09-18 10:29 ` [PATCH v2 04/11] rcutorture: Suppress "Writer stall state" reports during boot Paul E. McKenney
2025-09-18 10:29 ` [PATCH v2 05/11] rcutorture: Delay rcutorture readers and writers until boot completes Paul E. McKenney
2025-09-18 10:29 ` [PATCH v2 06/11] torture: Delay CPU-hotplug operations " Paul E. McKenney
2025-09-18 10:29 ` [PATCH v2 07/11] rcutorture: Delay forward-progress testing " Paul E. McKenney
2025-09-18 10:29 ` [PATCH v2 08/11] rcutorture: Use kcalloc() instead of kzalloc() Paul E. McKenney
2025-09-18 10:29 ` [PATCH v2 09/11] refscale: " Paul E. McKenney
2025-09-18 10:29 ` Paul E. McKenney [this message]
2025-09-18 10:29 ` [PATCH v2 11/11] refperf: Set reader_tasks to NULL after kfree() Paul E. McKenney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250918102952.2593045-10-paulmck@kernel.org \
    --to=paulmck@kernel.org \
    --cc=kaushlendra.kumar@intel.com \
    --cc=kernel-team@meta.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rcu@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox