From: "Paul E. McKenney" <paulmck@kernel.org>
To: rcu@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, kernel-team@meta.com,
rostedt@goodmis.org, Qianfeng Rong <rongqianfeng@vivo.com>,
"Paul E . McKenney" <paulmck@kernel.org>
Subject: [PATCH v2 08/11] rcutorture: Use kcalloc() instead of kzalloc()
Date: Thu, 18 Sep 2025 03:29:49 -0700 [thread overview]
Message-ID: <20250918102952.2593045-8-paulmck@kernel.org> (raw)
In-Reply-To: <c0edd79a-f988-432c-b08a-18793b2e15d9@paulmck-laptop>
From: Qianfeng Rong <rongqianfeng@vivo.com>
Use kcalloc() in rcu_torture_writer() to gain built-in overflow protection,
making memory allocation safer when calculating allocation size compared to
explicit multiplication.
Change sizeof(ulo[0]) and sizeof(rgo[0]) to sizeof(*ulo) and sizeof(*rgo),
as this is more consistent with coding conventions.
Signed-off-by: Qianfeng Rong <rongqianfeng@vivo.com>
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
---
kernel/rcu/rcutorture.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/rcu/rcutorture.c b/kernel/rcu/rcutorture.c
index b8a684459381f2..29fe3c01312f60 100644
--- a/kernel/rcu/rcutorture.c
+++ b/kernel/rcu/rcutorture.c
@@ -1572,12 +1572,12 @@ rcu_torture_writer(void *arg)
return 0;
}
if (cur_ops->poll_active > 0) {
- ulo = kzalloc(cur_ops->poll_active * sizeof(ulo[0]), GFP_KERNEL);
+ ulo = kcalloc(cur_ops->poll_active, sizeof(*ulo), GFP_KERNEL);
if (!WARN_ON(!ulo))
ulo_size = cur_ops->poll_active;
}
if (cur_ops->poll_active_full > 0) {
- rgo = kzalloc(cur_ops->poll_active_full * sizeof(rgo[0]), GFP_KERNEL);
+ rgo = kcalloc(cur_ops->poll_active_full, sizeof(*rgo), GFP_KERNEL);
if (!WARN_ON(!rgo))
rgo_size = cur_ops->poll_active_full;
}
--
2.40.1
next prev parent reply other threads:[~2025-09-18 10:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-18 10:29 [PATCH v2 0/11] RCU torture-test updates for v6.18 Paul E. McKenney
2025-09-18 10:29 ` [PATCH v2 01/11] rcutorture: Fix jitter.sh spin time Paul E. McKenney
2025-09-18 10:29 ` [PATCH v2 02/11] torture: Add --do-normal parameter to torture.sh help text Paul E. McKenney
2025-09-18 10:29 ` [PATCH v2 03/11] torture: Announce kernel boot status at torture-test startup Paul E. McKenney
2025-09-18 10:29 ` [PATCH v2 04/11] rcutorture: Suppress "Writer stall state" reports during boot Paul E. McKenney
2025-09-18 10:29 ` [PATCH v2 05/11] rcutorture: Delay rcutorture readers and writers until boot completes Paul E. McKenney
2025-09-18 10:29 ` [PATCH v2 06/11] torture: Delay CPU-hotplug operations " Paul E. McKenney
2025-09-18 10:29 ` [PATCH v2 07/11] rcutorture: Delay forward-progress testing " Paul E. McKenney
2025-09-18 10:29 ` Paul E. McKenney [this message]
2025-09-18 10:29 ` [PATCH v2 09/11] refscale: Use kcalloc() instead of kzalloc() Paul E. McKenney
2025-09-18 10:29 ` [PATCH v2 10/11] refperf: Remove redundant kfree() after torture_stop_kthread() Paul E. McKenney
2025-09-18 10:29 ` [PATCH v2 11/11] refperf: Set reader_tasks to NULL after kfree() Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250918102952.2593045-8-paulmck@kernel.org \
--to=paulmck@kernel.org \
--cc=kernel-team@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rcu@vger.kernel.org \
--cc=rongqianfeng@vivo.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox