Re: [PATCH 7.2 0000/1815] 7.2.6-rc1 review

Re: [PATCH 7.2 0000/1815] 7.2.6-rc1 review

[Thorsten Leemhuis]

On 9/12/26 08:29, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 7.2.6 release.
> There are 1815 patches in this series, all will be posted as a response
> to this one.  If anyone has any issues with these being applied, please
> let me know.
> [...]

My builds failed while compiling perf:

>> ui/browsers/hists.c: In function ‘evsel__hists_browse’:
>> ui/browsers/hists.c:3191:41: error: ‘hotkey_act’ undeclared (first use in this function)
>>  3191 |                                 memset(&hotkey_act, 0, sizeof(hotkey_act));
>>       |                                         ^~~~~~~~~~
>> ui/browsers/hists.c:3191:41: note: each undeclared identifier is reported only once for each function it appears in
Reverting "perf ui hists: In report UI ensure thread is set with
reference counting" fixes this. Haven't tried, but maybe including
bd86119c3ee6ed ("perf ui hists: Fix dso_filter reference leak and exit
zoom cleanup") will fix this, too.

That got me a little further, but then I ran into this:

>> tools/perf/util/python.c: In function ‘pyrf_evsel__open’:
>> tools/perf/util/python.c:1104:9: error: implicit declaration of function ‘CHECK_INITIALIZED’ [-Wimplicit-function-declaration]
>>  1104 |         CHECK_INITIALIZED(evsel, "evsel");
>>       |         ^~~~~~~~~~~~~~~~~
>> tools/perf/util/python.c: In function ‘pyrf_evsel__set_tracking’:
>> tools/perf/util/python.c:1295:9: error: implicit declaration of function ‘CHECK_INITIALIZED_INT’ [-Wimplicit-function-declaration]
>>  1295 |         CHECK_INITIALIZED_INT(pevsel->evsel, "evsel");
>>       |         ^~~~~~~~~~~~~~~~~~~~~

Only looked briefly, but didn't spot a simple way to work around that
through a simple revert or two (but it's quite likely I missed something).

Ciao, Thorsten

Re: [PATCH 7.2 0000/1815] 7.2.6-rc1 review

[Benjamin Boortz]

On Sat, Sep 12, 2026 at 12:18:56PM +0200, Thorsten Leemhuis wrote:

>On 9/12/26 08:29, Greg Kroah-Hartman wrote:
>> This is the start of the stable review cycle for the 7.2.6 release.
>> There are 1815 patches in this series, all will be posted as a response
>> to this one.  If anyone has any issues with these being applied, please
>> let me know.
>> [...]
>
>My builds failed while compiling perf:
>
>>> ui/browsers/hists.c: In function ‘evsel__hists_browse’:
>>> ui/browsers/hists.c:3191:41: error: ‘hotkey_act’ undeclared (first use in this function)
>>>  3191 |                                 memset(&hotkey_act, 0, sizeof(hotkey_act));
>>>       |                                         ^~~~~~~~~~
>>> ui/browsers/hists.c:3191:41: note: each undeclared identifier is reported only once for each function it appears in
>Reverting "perf ui hists: In report UI ensure thread is set with
>reference counting" fixes this. Haven't tried, but maybe including
>bd86119c3ee6ed ("perf ui hists: Fix dso_filter reference leak and exit
>zoom cleanup") will fix this, too.
>
>That got me a little further, but then I ran into this:
>
>>> tools/perf/util/python.c: In function ‘pyrf_evsel__open’:
>>> tools/perf/util/python.c:1104:9: error: implicit declaration of function ‘CHECK_INITIALIZED’ [-Wimplicit-function-declaration]
>>>  1104 |         CHECK_INITIALIZED(evsel, "evsel");
>>>       |         ^~~~~~~~~~~~~~~~~
>>> tools/perf/util/python.c: In function ‘pyrf_evsel__set_tracking’:
>>> tools/perf/util/python.c:1295:9: error: implicit declaration of function ‘CHECK_INITIALIZED_INT’ [-Wimplicit-function-declaration]
>>>  1295 |         CHECK_INITIALIZED_INT(pevsel->evsel, "evsel");
>>>       |         ^~~~~~~~~~~~~~~~~~~~~
>
>Only looked briefly, but didn't spot a simple way to work around that
>through a simple revert or two (but it's quite likely I missed something).
>
>Ciao, Thorsten
>


build-tested and reproduced the 2 issues on x86_64 with:

   make -j$(nproc) -C ./tools/perf O=/tmp/perf-build

observed errors:

1) tools/perf/ui/browsers/hists.c:3191:41: error: 'hotkey_act' undeclared

2ec3b9858725 — "perf hists browser: Increase MAX_OPTIONS to prevent stack buffer overflow"
   prerequisite: bd86119c3ee6 expects MAX_OPTIONS=32; stable-rc still has 16
   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=2ec3b985872594031cc1000b830344de5c26633d
bd86119c3ee6 — declares hotkey_act, fixes dso_filter reference leak
   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=bd86119c3ee6ed7b8fc9be8298fe49f1a5355a46


2) tools/perf/util/python.c:1104:9: error: implicit declaration of function 'CHECK_INITIALIZED'

01fa2d416ace — defines CHECK_INITIALIZED
   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=01fa2d416aceab51f97ec2769e8da9971a605eeb


With the 3 patches applied, perf build successful.

Benni

Re: [PATCH 7.2 0000/1815] 7.2.6-rc1 review

[Greg Kroah-Hartman]

On Sun, Sep 13, 2026 at 02:54:39PM +0200, Benjamin Boortz wrote:
> On Sat, Sep 12, 2026 at 12:18:56PM +0200, Thorsten Leemhuis wrote:
> 
> > On 9/12/26 08:29, Greg Kroah-Hartman wrote:
> > > This is the start of the stable review cycle for the 7.2.6 release.
> > > There are 1815 patches in this series, all will be posted as a response
> > > to this one.  If anyone has any issues with these being applied, please
> > > let me know.
> > > [...]
> > 
> > My builds failed while compiling perf:
> > 
> > > > ui/browsers/hists.c: In function ‘evsel__hists_browse’:
> > > > ui/browsers/hists.c:3191:41: error: ‘hotkey_act’ undeclared (first use in this function)
> > > >  3191 |                                 memset(&hotkey_act, 0, sizeof(hotkey_act));
> > > >       |                                         ^~~~~~~~~~
> > > > ui/browsers/hists.c:3191:41: note: each undeclared identifier is reported only once for each function it appears in
> > Reverting "perf ui hists: In report UI ensure thread is set with
> > reference counting" fixes this. Haven't tried, but maybe including
> > bd86119c3ee6ed ("perf ui hists: Fix dso_filter reference leak and exit
> > zoom cleanup") will fix this, too.
> > 
> > That got me a little further, but then I ran into this:
> > 
> > > > tools/perf/util/python.c: In function ‘pyrf_evsel__open’:
> > > > tools/perf/util/python.c:1104:9: error: implicit declaration of function ‘CHECK_INITIALIZED’ [-Wimplicit-function-declaration]
> > > >  1104 |         CHECK_INITIALIZED(evsel, "evsel");
> > > >       |         ^~~~~~~~~~~~~~~~~
> > > > tools/perf/util/python.c: In function ‘pyrf_evsel__set_tracking’:
> > > > tools/perf/util/python.c:1295:9: error: implicit declaration of function ‘CHECK_INITIALIZED_INT’ [-Wimplicit-function-declaration]
> > > >  1295 |         CHECK_INITIALIZED_INT(pevsel->evsel, "evsel");
> > > >       |         ^~~~~~~~~~~~~~~~~~~~~
> > 
> > Only looked briefly, but didn't spot a simple way to work around that
> > through a simple revert or two (but it's quite likely I missed something).
> > 
> > Ciao, Thorsten
> > 
> 
> 
> build-tested and reproduced the 2 issues on x86_64 with:
> 
>   make -j$(nproc) -C ./tools/perf O=/tmp/perf-build
> 
> observed errors:
> 
> 1) tools/perf/ui/browsers/hists.c:3191:41: error: 'hotkey_act' undeclared
> 
> 2ec3b9858725 — "perf hists browser: Increase MAX_OPTIONS to prevent stack buffer overflow"
>   prerequisite: bd86119c3ee6 expects MAX_OPTIONS=32; stable-rc still has 16
>   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=2ec3b985872594031cc1000b830344de5c26633d
> bd86119c3ee6 — declares hotkey_act, fixes dso_filter reference leak
>   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=bd86119c3ee6ed7b8fc9be8298fe49f1a5355a46
> 
> 
> 2) tools/perf/util/python.c:1104:9: error: implicit declaration of function 'CHECK_INITIALIZED'
> 
> 01fa2d416ace — defines CHECK_INITIALIZED
>   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=01fa2d416aceab51f97ec2769e8da9971a605eeb
> 
> 
> With the 3 patches applied, perf build successful.

Thanks for that, it fixes it for me too, I'll go queue these up now.

greg k-h